Re: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition

From: Guenter Roeck <linux@roeck-us.net>
To: "liuxp11@chinatelecom.cn" <liuxp11@chinatelecom.cn>,
	wim <wim@linux-watchdog.org>, Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux-watchdog <linux-watchdog@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition
Date: Tue, 26 Apr 2022 01:35:18 -0700	[thread overview]
Message-ID: <275d7e40-a4bf-624a-6072-9750c6cb1ff0@roeck-us.net> (raw)
In-Reply-To: <2022042616273282549226@chinatelecom.cn>

On 4/26/22 01:27, liuxp11@chinatelecom.cn wrote:
>     On 4/26/22 00:10, Liu Xinpeng wrote:
>      > Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.
>      >
>      > Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
>      > Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
>     Also, Tzung-Bi never sent a Reviewed-by: tag. As with the other patches,
>     this is completely inappropriate. Really, who gave you that idea ?
>     You adding such tags without receiving them means we can never trust
>     your patches again since you are making things up.
>     Guenter
>     -->Very sorry about this. I am not clearly when need to add "Reviewed-by: tag",
>     Just expressing thanks.
> 

If you get a Reviewed-by: tag for a patch, you keep it in the next version of
that patch unless there are substantial changes. You _never_ add one yourself.

Guenter