All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v4 03/11] rtc: fall back to ->{read,write} if ->{read,write}8 are not provided
Date: Thu, 9 Jul 2020 10:36:29 +0200	[thread overview]
Message-ID: <276a35b2-0e90-08b8-3102-a5ff797865bf@denx.de> (raw)
In-Reply-To: <20200706200120.23093-4-rasmus.villemoes@prevas.dk>

Hello Rasmus,

Am 06.07.2020 um 22:01 schrieb Rasmus Villemoes:
> Similar to how the dm_rtc_{read,write} functions fall back to using
> the {read,write}8 methods, do the opposite in the rtc_{read,write}8
> functions.
> 
> This way, each driver only needs to provide either ->read8 or ->read
> to make both rtc_read8() and dm_rtc_read() work - without this, a
> driver that provides ->read() would most likely just duplicate the
> logic here for implementing a ->read8() method in term of its ->read()
> method. The same remarks of course apply to the write case.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
>   drivers/rtc/rtc-uclass.c | 25 +++++++++++++++++++------
>   1 file changed, 19 insertions(+), 6 deletions(-)

Applied to u-boot-i2c.git master

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

  reply	other threads:[~2020-07-09  8:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 20:01 [PATCH v4 00/11] new rtc methods, rtc command, and tests Rasmus Villemoes
2020-07-06 20:01 ` [PATCH v4 01/11] rtc: add dm_rtc_read helper and ->read method Rasmus Villemoes
2020-07-09  8:35   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 02/11] rtc: add dm_rtc_write() helper Rasmus Villemoes
2020-07-09  8:36   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 03/11] rtc: fall back to ->{read, write} if ->{read, write}8 are not provided Rasmus Villemoes
2020-07-09  8:36   ` Heiko Schocher [this message]
2020-07-06 20:01 ` [PATCH v4 04/11] rtc: pcf2127: provide ->read method Rasmus Villemoes
2020-07-09  8:36   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 05/11] rtc: pcf2127: provide ->write method Rasmus Villemoes
2020-07-09  8:37   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 06/11] rtc: add rtc command Rasmus Villemoes
2020-07-09  8:37   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 07/11] rtc: sandbox-rtc: fix set method Rasmus Villemoes
2020-07-09  8:37   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 08/11] rtc: i2c_rtc_emul: catch any write to the "reset" register Rasmus Villemoes
2020-07-09  8:38   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 09/11] test: dm: rtc: add test of dm_rtc_read, dm_rtc_write Rasmus Villemoes
2020-07-09  8:38   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 10/11] sandbox: add rtc command to defconfigs Rasmus Villemoes
2020-07-09  8:38   ` Heiko Schocher
2020-07-06 20:01 ` [PATCH v4 11/11] test: dm: rtc: add tests of rtc shell command Rasmus Villemoes
2020-07-09  8:39   ` Heiko Schocher
2020-07-07  5:02 ` [PATCH v4 00/11] new rtc methods, rtc command, and tests Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=276a35b2-0e90-08b8-3102-a5ff797865bf@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.