* [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow
@ 2019-10-23 19:39 Tom Rini
2019-10-23 20:07 ` Simon Goldschmidt
2019-11-01 13:31 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2019-10-23 19:39 UTC (permalink / raw)
To: u-boot
When we have an excess size growth, fix the "limit" printf call to pass
in just the limit variable rather than the string bytes to the format
character.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index cbacf1cfe2c9..f09023a3977f 100644
--- a/Makefile
+++ b/Makefile
@@ -346,7 +346,7 @@ define size_check
limit=$$( printf "%d" $2 ); \
if test $$actual -gt $$limit; then \
echo "$1 exceeds file size limit:" >&2; \
- echo " limit: $$(printf %#x bytes $$limit) bytes" >&2; \
+ echo " limit: $$(printf %#x $$limit) bytes" >&2; \
echo " actual: $$(printf %#x $$actual) bytes" >&2; \
echo " excess: $$(printf %#x $$((actual - limit))) bytes" >&2;\
exit 1; \
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow
2019-10-23 19:39 [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow Tom Rini
@ 2019-10-23 20:07 ` Simon Goldschmidt
2019-11-01 13:31 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Goldschmidt @ 2019-10-23 20:07 UTC (permalink / raw)
To: u-boot
Am 23.10.2019 um 21:39 schrieb Tom Rini:
> When we have an excess size growth, fix the "limit" printf call to pass
> in just the limit variable rather than the string bytes to the format
> character.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index cbacf1cfe2c9..f09023a3977f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -346,7 +346,7 @@ define size_check
> limit=$$( printf "%d" $2 ); \
> if test $$actual -gt $$limit; then \
> echo "$1 exceeds file size limit:" >&2; \
> - echo " limit: $$(printf %#x bytes $$limit) bytes" >&2; \
> + echo " limit: $$(printf %#x $$limit) bytes" >&2; \
> echo " actual: $$(printf %#x $$actual) bytes" >&2; \
> echo " excess: $$(printf %#x $$((actual - limit))) bytes" >&2;\
> exit 1; \
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow
2019-10-23 19:39 [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow Tom Rini
2019-10-23 20:07 ` Simon Goldschmidt
@ 2019-11-01 13:31 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-11-01 13:31 UTC (permalink / raw)
To: u-boot
On Wed, Oct 23, 2019 at 03:39:41PM -0400, Tom Rini wrote:
> When we have an excess size growth, fix the "limit" printf call to pass
> in just the limit variable rather than the string bytes to the format
> character.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191101/4d04e839/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-01 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 19:39 [U-Boot] [PATCH] Makefile: Fix printing problem in size_check on overflow Tom Rini
2019-10-23 20:07 ` Simon Goldschmidt
2019-11-01 13:31 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.