From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper Date: Fri, 30 Oct 2015 17:23:29 +0100 Message-ID: <2771291.DI3Lyk6PGI@xps13> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <2182686.Rj6sEZi19Z@xps13> <20151030161640.GA5284@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 633589222 for ; Fri, 30 Oct 2015 17:24:41 +0100 (CET) Received: by wmff134 with SMTP id f134so15632916wmf.1 for ; Fri, 30 Oct 2015 09:24:40 -0700 (PDT) In-Reply-To: <20151030161640.GA5284@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-30 16:16, Bruce Richardson: > Another request, can you perhaps also fix the script for situations where > checkpatch.pl is not in the kernel tree. I've used this script now to check a > couple of patchsets, which came back clean, but it turns out that because I was > using checkpatch.pl outside the kernel directory, it is passing things it > shouldn't. [Thanks to Sergio for pointing this out]. > > Testing with a known-broken patch, this script indicates all ok, and only > reports an error with the --no-tree added to the options inside the script. :-( OK I prefer using it in the Linux tree because it is updated with "git pull".