From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755768Ab1BRHUn (ORCPT ); Fri, 18 Feb 2011 02:20:43 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:41333 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656Ab1BRHUm (ORCPT ); Fri, 18 Feb 2011 02:20:42 -0500 Message-ID: <2774EB35C1E04E299E5BF2E60CC956B7@subhasishg> From: "Subhasish Ghosh" To: "Sergei Shtylyov" Cc: , , "Russell King" , "Kevin Hilman" , , "open list" , , References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com> <1297435892-28278-7-git-send-email-subhasish@mistralsolutions.com> <4D5583CF.8010905@mvista.com> In-Reply-To: <4D5583CF.8010905@mvista.com> Subject: Re: [PATCH v2 06/13] da850: pruss CAN board specific additions. Date: Fri, 18 Feb 2011 12:49:49 +0530 Organization: Mistral Solutions MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -------------------------------------------------- From: "Sergei Shtylyov" Sent: Saturday, February 12, 2011 12:15 AM To: "Subhasish Ghosh" Cc: ; ; "Russell King" ; "Kevin Hilman" ; ; "open list" ; ; Subject: Re: [PATCH v2 06/13] da850: pruss CAN board specific additions. > Subhasish Ghosh wrote: > >> This patch adds the pruss CAN pin mux and registers the device >> with the pruss mfd driver. > >> Signed-off-by: Subhasish Ghosh > [...] > >> diff --git a/arch/arm/mach-davinci/board-da850-evm.c >> b/arch/arm/mach-davinci/board-da850-evm.c >> index 242d1ed..2ce5536 100644 >> --- a/arch/arm/mach-davinci/board-da850-evm.c >> +++ b/arch/arm/mach-davinci/board-da850-evm.c >> @@ -1053,8 +1053,43 @@ static __init int da850_evm_init_cpufreq(void) > [...] >> static struct da8xx_pruss_devices pruss_devices[] = { >> - {.dev_name = NULL,}, >> + { >> + .dev_name = "da8xx_pruss_can", >> + .pdata = &can_data, >> + .pdata_size = sizeof(can_data), >> + .setup = da850_evm_setup_pruss_can, >> + }, >> + { >> + .dev_name = NULL, >> + }, > > No need to explicitly initialize to NULL. SG -- ok, Will remove > > WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: subhasish@mistralsolutions.com (Subhasish Ghosh) Date: Fri, 18 Feb 2011 12:49:49 +0530 Subject: [PATCH v2 06/13] da850: pruss CAN board specific additions. In-Reply-To: <4D5583CF.8010905@mvista.com> References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com> <1297435892-28278-7-git-send-email-subhasish@mistralsolutions.com> <4D5583CF.8010905@mvista.com> Message-ID: <2774EB35C1E04E299E5BF2E60CC956B7@subhasishg> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org -------------------------------------------------- From: "Sergei Shtylyov" Sent: Saturday, February 12, 2011 12:15 AM To: "Subhasish Ghosh" Cc: ; ; "Russell King" ; "Kevin Hilman" ; ; "open list" ; ; Subject: Re: [PATCH v2 06/13] da850: pruss CAN board specific additions. > Subhasish Ghosh wrote: > >> This patch adds the pruss CAN pin mux and registers the device >> with the pruss mfd driver. > >> Signed-off-by: Subhasish Ghosh > [...] > >> diff --git a/arch/arm/mach-davinci/board-da850-evm.c >> b/arch/arm/mach-davinci/board-da850-evm.c >> index 242d1ed..2ce5536 100644 >> --- a/arch/arm/mach-davinci/board-da850-evm.c >> +++ b/arch/arm/mach-davinci/board-da850-evm.c >> @@ -1053,8 +1053,43 @@ static __init int da850_evm_init_cpufreq(void) > [...] >> static struct da8xx_pruss_devices pruss_devices[] = { >> - {.dev_name = NULL,}, >> + { >> + .dev_name = "da8xx_pruss_can", >> + .pdata = &can_data, >> + .pdata_size = sizeof(can_data), >> + .setup = da850_evm_setup_pruss_can, >> + }, >> + { >> + .dev_name = NULL, >> + }, > > No need to explicitly initialize to NULL. SG -- ok, Will remove > > WBR, Sergei