From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: yocto@yoctoproject.org
Subject: [layerindex-web][PATCH 5/7] update: ignore recommends when ordering layers
Date: Tue, 3 Jul 2018 10:58:49 +1200 [thread overview]
Message-ID: <2774b95ad7f971714498b5d35885225af873da03.1530569567.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1530569567.git.paul.eggleton@linux.intel.com>
We don't actually need to consider recommended layers when preparing the
order - just the depends. If we do then we can get into circular
dependency situation e.g. currently with meta-intel and meta-intel-qat
where meta-intel recommends meta-intel-qat and meta-intel-qat depends on
meta-intel. (Likely the latter dependency is erroneous since the content
of meta-intel-qat doesn't appear to depend on meta-intel, but there
could be other scenarios where it is legitimate).
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
layerindex/update.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/layerindex/update.py b/layerindex/update.py
index 06c61a79..a4b96e24 100755
--- a/layerindex/update.py
+++ b/layerindex/update.py
@@ -399,7 +399,7 @@ def main():
deps = re.search("^LAYERDEPENDS = \"(.*)\"", output, re.M).group(1) or ''
recs = re.search("^LAYERRECOMMENDS = \"(.*)\"", output, re.M).group(1) or ''
- deps_dict = utils.explode_dep_versions2(bitbakepath, deps + ' ' + recs)
+ deps_dict = utils.explode_dep_versions2(bitbakepath, deps)
if len(deps_dict) == 0:
# No depends, add it firstly
layerquery_sorted.append(layer)
--
2.17.1
next prev parent reply other threads:[~2018-07-02 23:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:58 [layerindex-web][PATCH 0/7] Layer index fixes Paul Eggleton
2018-07-02 22:58 ` [layerindex-web][PATCH 1/7] settings: allow disabling layer publishing emails Paul Eggleton
2018-07-02 22:58 ` [layerindex-web][PATCH 2/7] update_layer: drop debug message for deleting recipe file dependencies Paul Eggleton
2018-07-02 22:58 ` [layerindex-web][PATCH 3/7] update_layer: avoid errors on modified & renamed files Paul Eggleton
2018-07-02 22:58 ` [layerindex-web][PATCH 4/7] recipeparse: don't error out on missing layer recommends Paul Eggleton
2018-07-02 22:58 ` Paul Eggleton [this message]
2018-07-03 2:45 ` [layerindex-web][PATCH 5/7] update: ignore recommends when ordering layers Robert Yang
2018-07-03 2:58 ` Paul Eggleton
2018-07-03 3:08 ` Robert Yang
2018-07-04 7:52 ` Robert Yang
2018-07-06 5:28 ` Paul Eggleton
2018-07-06 6:49 ` Robert Yang
2018-07-09 4:07 ` Robert Yang
2018-07-02 22:58 ` [layerindex-web][PATCH 6/7] utils: fix missing dependency logic in _add_dependency() Paul Eggleton
2018-07-02 22:58 ` [layerindex-web][PATCH 7/7] Add site-wide notice support Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2774b95ad7f971714498b5d35885225af873da03.1530569567.git.paul.eggleton@linux.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.