From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 3/5] xen/domain: Stricter configuration checking Date: Tue, 13 Nov 2018 15:07:48 +0000 Message-ID: <277a9d4b-0684-74ad-4928-5c41606f37f9@citrix.com> References: <1542039391-32406-1-git-send-email-andrew.cooper3@citrix.com> <1542039391-32406-4-git-send-email-andrew.cooper3@citrix.com> <5BEADC4002000078001FB7F7@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5BEADC4002000078001FB7F7@prv1-mh.provo.novell.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMTMvMTEvMjAxOCAxNDoxNCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4gT24gMTIuMTEuMTgg YXQgMTc6MTYsIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToKPj4gQ3VycmVudGx5 LCBhIG51bWJlciBvZiBvcHRpb25zIHBhc3NlZCBmb3IgZG9tYWluIGNyZWF0aW9uIGFyZSBpZ25v cmVkLCBvciBoYXZlCj4+IGltcGxpY2l0IGZhbGxiYWNrIGJlaGF2aW91ci4gIFRoaXMgaXMgYmFk IGZvciBmb3J3YXJkcyBjb21wYXRpYmlsaXR5LCBhbmQgZm9yCj4+IGVuZCB1c2VycyB0byBiZSBj ZXJ0YWluIHRoYXQgdGhleSBnb3QgdGhlIGNvbmZpZ3VyYXRpb24gdGhleSBhc2tlZCBmb3IuCj4+ Cj4+IFdpdGggdGhpcyBjaGFuZ2U6Cj4+ICAqIEFSTSBub3cgc3RyaWN0bHkgcmVxdWlyZXMgdGhh dCBYRU5fRE9NQ1RMX0NERl9oYXAgaXMgcGFzc2VkLiAgUHJldmlvdXNseSwKPj4gICAgb25seSBY RU5fRE9NQ1RMX0NERl9odm1fZ3Vlc3Qgd2FzIGNoZWNrZWQuCj4+ICAqIEZvciB4ODYsIHJlcXVl c3RpbmcgSEFQIHdpdGhvdXQgSFZNIGlzIG5vdyBwcm9oaWJpdGVkLCBhcyB0aGUgY29tYmluYXRp b24KPj4gICAgbWFrZXMgbm8gc2Vuc2UuCj4+ICAqIEZvciB4ODYsIHJlcXVlc3RpbmcgSEFQIG9u IGEgbm9uLUhBUCBjYXBhYmxlIHN5c3RlbSB3aWxsIGZhaWwsIHJhdGhlciB0aGFuCj4+ICAgIHNp bGVudGx5IGZhbGwgYmFjayB0byBTaGFkb3cuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4+IC0tLQo+PiBDQzogSmFuIEJldWxp Y2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+PiBDQzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNv bT4KPj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPj4g Q0M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4+IENDOiBJYW4gSmFja3Nv biA8SWFuLkphY2tzb25AY2l0cml4LmNvbT4KPj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJp eC5jb20+Cj4+Cj4+IFNlbWkgUkZDIGJlY2F1c2UgdGhpcyBtYXkgY2F1c2UgYSB1c2VyLXZpc2li bGUgY2hhbmdlIGluIGJlaGF2aW91ci4gIEhvd2V2ZXIsCj4+IGlmIHRoZSB1c2VyIGhhcyBnb25l IHRvIHRoZSBlZmZvcnQgb2Ygc3BlY2lmeWluZyBoYXA9MSwgc2lsZW50bHkgZmFsbGluZyBiYWNr Cj4+IHRvIHNoYWRvdyBpcyB1bmV4cGVjdGVkLCBhbmQgSU1PLCBhIGJ1Zy4KPiBNeSB2aWV3IG9u IHRoaXMgdG8gYSBmYWlyIHBhcnQgZGVwZW5kcyBvbiB3aGV0aGVyIHRoZSB0b29sIHN0YWNrCj4g d291bGQgZ3VhcmQgdXMgZnJvbSBhY3R1YWxseSBnZXR0aW5nIGludG8gc3VjaCBhIHNpdHVhdGlv biBpbiB0aGUKPiBoeXBlcnZpc29yLiBHZXR0aW5nIGFuIHVuc3BlY2lmaWMgLUVJTlZBTCBiYWNr IHdpdGhvdXQgZnVydGhlcgo+IGhlbHAgdG93YXJkcyBkaWFnbm9zaXMgYnkgdGhlIHRvb2wgc3Rh Y2sgd291bGQgbWFrZSBzdWNoIGEKPiBjaGFuZ2UgdW5kZXNpcmFibGUgaW1vLiBUaGlzIGFsc28g ZXh0ZW5kcyB0byBvdGhlciBjaGVja3MgeW91Cj4gYXBwZWFyIHRvIHRpZ2h0ZW4gLSBmb3IgZXhh bXBsZSBJIHdvdWxkbid0IHdhbnQgdG8gc2VlIGEgUFYKPiBndWVzdCBjb25maWcgd2l0aCAiaGFw PTEiIGluIGl0IHRvIG5vIGxvbmdlciB3b3JrIGlmIGN1cnJlbnRseSBpdAo+IGhhcHBlbnMgdG8g d29yaywgYXQgbGVhc3Qgbm90IHdpdGhvdXQgYSBjbGVhciBoaW50IHRvd2FyZHMgdGhlCj4gaXNz dWUuCgpIbW0gLSBpbiBhdHRlbXB0aW5nIHRvIGFuc3dlciB0aGlzLCBJJ3ZlIGRpc2NvdmVyZWQg dGhhdCB4bCBpc3N1ZXMgbm8Kd2FybmluZy9lcnJvciBhYm91dCBoYXAgb3IgbmVzdGVkaHZtIHdp dGggdHlwZT0icHYiLCBhbmQgdGhhdCBhIFBWLXNoaW0KWGVuIGJpbmFyeSB3aWxsIGJlIHN0YXJ0 ZWQgYXMgYSBQViBndWVzdCwgZGVzcGl0ZSB0aGUgZG9tYWluIGJ1aWxkZXIKaWRlbnRpZnlpbmcg dGhlIGJpbmFyeSBhcyBQVkguCgo+Cj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYwo+PiAr KysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKPj4gQEAgLTQyMCw2ICs0MjAsNDYgQEAgdm9pZCBh cmNoX3ZjcHVfZGVzdHJveShzdHJ1Y3QgdmNwdSAqdikKPj4gIAo+PiAgaW50IGFyY2hfc2FuaXRp c2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykK Pj4gIHsKPj4gKyAgICBib29sIGh2bTsKPj4gKwo+PiArICAgIGlmICggIUlTX0VOQUJMRUQoQ09O RklHX1BWKSAmJiAhKGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9odm1fZ3Vlc3QpICkK Pj4gKyAgICB7Cj4+ICsgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sICJQViBzdXBwb3J0IG5v dCBhdmFpbGFibGVcbiIpOwo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4gKyAgICB9Cj4+ ICsKPj4gKyAgICBpZiAoICFodm1fZW5hYmxlZCAmJiAoY29uZmlnLT5mbGFncyAmIFhFTl9ET01D VExfQ0RGX2h2bV9ndWVzdCkgKQo+PiArICAgIHsKPj4gKyAgICAgICAgZHByaW50ayhYRU5MT0df SU5GTywgIkhWTSBzdXBwb3J0IG5vdCBhdmFpbGFibGVcbiIpOwo+PiArICAgICAgICByZXR1cm4g LUVJTlZBTDsKPj4gKyAgICB9Cj4+ICsKPj4gKyAgICBodm0gPSBjb25maWctPmZsYWdzICYgWEVO X0RPTUNUTF9DREZfaHZtX2d1ZXN0Owo+IFdvdWxkIHlvdSBtaW5kIG1ha2luZyB0aGlzIHRoZSBp bml0aWFsaXplciBvZiB0aGUgdmFyaWFibGUgYW5kIHVzaW5nCj4gdGhlIHZhcmlhYmxlIGluIHRo ZSB0d28gaWYoKS1zIGFib3ZlPyBQZXJzb25hbGx5IEkgYWxzbyB0aGluayB0aGUgdHdvCj4gaWYo KS1zIHdvdWxkIGJldHRlciBiZSBmb2xkZWQsIHVzaW5nIGEgY29uZGl0aW9uYWwgZXhwcmVzc2lv biBhcyBpdHMKPiBjb25kaXRpb24uCgpJIGNhbiBtb3ZlIHRoZSBpbml0aWFsaXNlciwgYnV0IGhv dyBkbyB5b3UgcHJvcG9zZSBmb2xkaW5nIHRoZQpjb25kaXRpb25hbHMgZ2l2ZW4gdGhlaXIgZGlm ZmVyZW50IGNvbnRlbnRzPwoKfkFuZHJldwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3hlbi1kZXZlbA==