All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	wg@grandegger.com, robh+dt@kernel.org, linux-can@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	o.rempel@pengutronix.de
Subject: Re: [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver
Date: Wed, 16 Sep 2020 15:59:37 +0200	[thread overview]
Message-ID: <277ce2a5-b8fc-46f3-6695-4be445d52927@pengutronix.de> (raw)
In-Reply-To: <20200916040732.GA4281@linux>


[-- Attachment #1.1: Type: text/plain, Size: 1499 bytes --]

On 9/16/20 6:07 AM, Manivannan Sadhasivam wrote:
>>> Just a quick question: I don't see any activity on this specific driver for
>>> sometime (back in Martin days itself). Is it due to lack of reviewers or
>>> it is due to the patch size (lines of code) so that nobody is interested
>>> in reviewing?
>>
>> If you look around, there are currently several versions of mcp251x
>> driver around, shipped by hardware vendors who glue the chip on there
>> SOM etc.
>> Until something more-or-less clean becomes mainline, the effort remains
>> spread.
>>
>> A problem to import a complete driver is that ... its complete.
>> There was an suggestion to split into several patches, but that does not
>> really affect the review work.
>>
>> The original driver failed to initialize under a loaded CAN bus, on my
>> desk. The current driver is more cleanly written than the original
>> and it seems to survive more than 1 use case (although I have a MAB overflow
>> report pending to investigate).
>> So, this is a good candidate for mainline.
> 
> I just saw that you've pushed these patches to your testing branch. Does this
> mean that you're going to include it in v5.10 PR?

yes, that's the plan.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-09-16 20:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 13:38 [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver Manivannan Sadhasivam
2020-09-10 13:38 ` [PATCH 1/6] can: rx-offload: can_rx_offload_add_manual(): add new initialization function Manivannan Sadhasivam
2020-09-10 13:38 ` [PATCH 2/6] dt-bindings: can: mcp25xxfd: document device tree bindings Manivannan Sadhasivam
2020-09-22 19:32   ` Rob Herring
2020-09-29  9:46   ` Geert Uytterhoeven
2020-09-29 10:06     ` Marc Kleine-Budde
2020-09-29 11:25       ` Thomas.Kopp
2020-09-29 11:27         ` Marc Kleine-Budde
2020-09-10 13:38 ` [PATCH 3/6] can: mcp25xxfd: add regmap infrastructure Manivannan Sadhasivam
2020-09-10 13:38 ` [PATCH 4/6] can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN Manivannan Sadhasivam
2020-09-10 13:38 ` [PATCH 5/6] can: mcp25xxfd: add listen-only mode Manivannan Sadhasivam
2020-09-10 13:38 ` [PATCH 6/6] MAINTAINERS: Add entry for Microchip MCP25XXFD SPI-CAN network driver Manivannan Sadhasivam
2020-09-15 16:19 ` [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver Manivannan Sadhasivam
2020-09-15 17:58   ` Kurt Van Dijck
2020-09-16  4:07     ` Manivannan Sadhasivam
2020-09-16 13:59       ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=277ce2a5-b8fc-46f3-6695-4be445d52927@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.