All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
	Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 2/2] hw/mips/boston: Pack fdt in fdt filter
Date: Tue, 16 Aug 2022 02:44:41 +0200	[thread overview]
Message-ID: <277f1180-02f4-9372-2493-1954a250e35f@amsat.org> (raw)
In-Reply-To: <20220813162720.60008-3-jiaxun.yang@flygoat.com>

On 13/8/22 18:27, Jiaxun Yang wrote:
> FDT can be awfully fat after series of modifications in fdt
> filter. Just pack it up before add to ram.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   hw/mips/boston.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/mips/boston.c b/hw/mips/boston.c
> index 5145179951..a40f193f78 100644
> --- a/hw/mips/boston.c
> +++ b/hw/mips/boston.c
> @@ -400,6 +400,7 @@ static const void *boston_fdt_filter(void *opaque, const void *fdt_orig,
>                           1, boston_memmap[BOSTON_HIGHDDR].base + ram_low_sz,
>                           1, ram_high_sz);
>   
> +    fdt_pack(fdt);
>       fdt = g_realloc(fdt, fdt_totalsize(fdt));
>       qemu_fdt_dumpdtb(fdt, fdt_sz);
>   

Why not pack by default in qemu_fdt_dumpdtb()?


  reply	other threads:[~2022-08-16  0:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13 16:27 [PATCH 0/2] hw/mips/boston: Initrd support Jiaxun Yang
2022-08-13 16:27 ` [PATCH 1/2] hw/mips/boston: Support initrd for ELF kernel Jiaxun Yang
2022-08-13 16:27 ` [PATCH 2/2] hw/mips/boston: Pack fdt in fdt filter Jiaxun Yang
2022-08-16  0:44   ` Philippe Mathieu-Daudé via [this message]
2022-08-16 11:46     ` Jiaxun Yang
2022-08-18  2:48       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=277f1180-02f4-9372-2493-1954a250e35f@amsat.org \
    --to=qemu-devel@nongnu.org \
    --cc=alistair@alistair23.me \
    --cc=david@gibson.dropbear.id.au \
    --cc=f4bug@amsat.org \
    --cc=jiaxun.yang@flygoat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.