From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9428C433EF for ; Fri, 13 May 2022 06:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377353AbiEMG0j (ORCPT ); Fri, 13 May 2022 02:26:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377292AbiEMG0W (ORCPT ); Fri, 13 May 2022 02:26:22 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2925427FDA; Thu, 12 May 2022 23:26:01 -0700 (PDT) Received: from NTHCCAS04.nuvoton.com (NTHCCAS04.nuvoton.com [10.1.8.29]) by maillog.nuvoton.com (Postfix) with ESMTP id 5B9611C80D8E; Fri, 13 May 2022 14:25:59 +0800 (CST) Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 13 May 2022 14:25:58 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 13 May 2022 14:25:58 +0800 Message-ID: <2786221c-d0a5-9bce-70d3-385dc419591a@nuvoton.com> Date: Fri, 13 May 2022 14:25:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , , , References: <20220510032558.10304-1-ychuang3@nuvoton.com> <20220510032558.10304-3-ychuang3@nuvoton.com> From: Jacky Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/12 下午 10:04, Krzysztof Kozlowski wrote: > On 10/05/2022 05:25, Jacky Huang wrote: >> Add documentation to describe Nuvoton MA35D1 clock driver bindings. >> >> Signed-off-by: Jacky Huang >> Reviewed-by: Krzysztof Kozlowski >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + clk: clock-controller@40460200 { >> + compatible = "nuvoton,ma35d1-clk"; >> + reg = <0x0 0x40460200 0x0 0x100>; > I don't think you tested your bindings. This fails. > > clock-names below as well. Please do not send untested code. > > Testing is explained here: > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc6%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fwriting-schema.rst%23L111&data=05%7C01%7Cychuang3%40nuvoton.com%7C7f9b081f94a642e8b40b08da34204e53%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637879610603173566%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kqInjscLvZpOSWtsN%2BPW3s%2BPeaK5KCD1weTH2JiHqxg%3D&reserved=0 > > Best regards, > Krzysztof I run the test  make DT_CHECKER_FLAGS=-m dt_binding_check, but not run dtbs_check. I will fix it. Thank you. Sincerely, Jacky Huang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 680EEC433F5 for ; Fri, 13 May 2022 06:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ofA1X7NVuN4hXXNbX+Old2o5ewNtnVvf4118d0whGPs=; b=cYmQcCQuY08y7q b6Fg17qFXxaxIrGwc6lSb3pwLQdWf0q2h0wKwLfK3pb1cUlTJ9uPCAKZTEcKzw47gRjwEdYm0XqA8 gHEcH8zX5vN8sV37lrbyKwbap8Z7LoX/8hGbO1UgJ/g/MwlIeN7gOumP4xF9SVgsda+an+ygY63c/ qA1Ev+k1anij/dOyiOMn35MkYqDLRJ6anCmycKXVXXOFM9OafHfLc/kYpSUJm/XvwmkGQ5FX6FbTJ dP1EcYo99LCNo5KTFoijKc/8roSguDJb7RAud6ita1oLp69eYee4qlRiFJAIMR9LyldQMNMvSO7Oj THCnjDsvHwuo69Vu9J+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npOke-00Efwb-4Q; Fri, 13 May 2022 06:26:12 +0000 Received: from maillog.nuvoton.com ([202.39.227.15]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npOkZ-00EfuC-Tl for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 06:26:10 +0000 Received: from NTHCCAS04.nuvoton.com (NTHCCAS04.nuvoton.com [10.1.8.29]) by maillog.nuvoton.com (Postfix) with ESMTP id 5B9611C80D8E; Fri, 13 May 2022 14:25:59 +0800 (CST) Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 13 May 2022 14:25:58 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 13 May 2022 14:25:58 +0800 Message-ID: <2786221c-d0a5-9bce-70d3-385dc419591a@nuvoton.com> Date: Fri, 13 May 2022 14:25:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , , , References: <20220510032558.10304-1-ychuang3@nuvoton.com> <20220510032558.10304-3-ychuang3@nuvoton.com> From: Jacky Huang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220512_232608_156463_CDA8CC98 X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIyLzUvMTIg5LiL5Y2IIDEwOjA0LCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+ IE9uIDEwLzA1LzIwMjIgMDU6MjUsIEphY2t5IEh1YW5nIHdyb3RlOgo+PiBBZGQgZG9jdW1lbnRh dGlvbiB0byBkZXNjcmliZSBOdXZvdG9uIE1BMzVEMSBjbG9jayBkcml2ZXIgYmluZGluZ3MuCj4+ Cj4+IFNpZ25lZC1vZmYtYnk6IEphY2t5IEh1YW5nIDx5Y2h1YW5nM0BudXZvdG9uLmNvbT4KPj4g UmV2aWV3ZWQtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGlu YXJvLm9yZz4KPj4gKwo+PiArYWRkaXRpb25hbFByb3BlcnRpZXM6IGZhbHNlCj4+ICsKPj4gK2V4 YW1wbGVzOgo+PiArICAtIHwKPj4gKyAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvY2xvY2svbnV2 b3RvbixtYTM1ZDEtY2xrLmg+Cj4+ICsKPj4gKyAgICBjbGs6IGNsb2NrLWNvbnRyb2xsZXJANDA0 NjAyMDAgewo+PiArICAgICAgICBjb21wYXRpYmxlID0gIm51dm90b24sbWEzNWQxLWNsayI7Cj4+ ICsgICAgICAgIHJlZyA9IDwweDAgMHg0MDQ2MDIwMCAweDAgMHgxMDA+Owo+IEkgZG9uJ3QgdGhp bmsgeW91IHRlc3RlZCB5b3VyIGJpbmRpbmdzLiBUaGlzIGZhaWxzLgo+Cj4gY2xvY2stbmFtZXMg YmVsb3cgYXMgd2VsbC4gUGxlYXNlIGRvIG5vdCBzZW5kIHVudGVzdGVkIGNvZGUuCj4KPiBUZXN0 aW5nIGlzIGV4cGxhaW5lZCBoZXJlOgo+IGh0dHBzOi8vYXBjMDEuc2FmZWxpbmtzLnByb3RlY3Rp b24ub3V0bG9vay5jb20vP3VybD1odHRwcyUzQSUyRiUyRmVsaXhpci5ib290bGluLmNvbSUyRmxp bnV4JTJGdjUuMTgtcmM2JTJGc291cmNlJTJGRG9jdW1lbnRhdGlvbiUyRmRldmljZXRyZWUlMkZi aW5kaW5ncyUyRndyaXRpbmctc2NoZW1hLnJzdCUyM0wxMTEmYW1wO2RhdGE9MDUlN0MwMSU3Q3lj aHVhbmczJTQwbnV2b3Rvbi5jb20lN0M3ZjliMDgxZjk0YTY0MmU4YjQwYjA4ZGEzNDIwNGU1MyU3 Q2EzZjI0OTMxZDQwMzRiNGE5NGYxN2Q4M2FjNjM4ZTA3JTdDMCU3QzAlN0M2Mzc4Nzk2MTA2MDMx NzM1NjYlN0NVbmtub3duJTdDVFdGcGJHWnNiM2Q4ZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpv aVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4wJTNEJTdDMzAwMCU3QyU3QyU3QyZh bXA7c2RhdGE9a3FJbmpzY0x2WnBPU1d0c04lMkJQVzNzJTJCUGVhSzVLQ0Qxd2VUSDJKaUhxeGcl M0QmYW1wO3Jlc2VydmVkPTAKPgo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKCkkgcnVuIHRo ZSB0ZXN0wqAgbWFrZSBEVF9DSEVDS0VSX0ZMQUdTPS1tIGR0X2JpbmRpbmdfY2hlY2ssIGJ1dCBu b3QgcnVuIApkdGJzX2NoZWNrLgpJIHdpbGwgZml4IGl0LiBUaGFuayB5b3UuCgpTaW5jZXJlbHks CkphY2t5IEh1YW5nCgoKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==