From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6A9C05027 for ; Mon, 23 Jan 2023 15:31:31 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 191EF400D4; Mon, 23 Jan 2023 16:31:30 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1316B4003F for ; Mon, 23 Jan 2023 16:31:29 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2E0CB5C012F; Mon, 23 Jan 2023 10:31:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 23 Jan 2023 10:31:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674487888; x= 1674574288; bh=Oo3OWL/7/o7GNlBBf1AJnhQlkeEwBF+uxMG7/qcHWMg=; b=J 3JL8Gd6xm/wVhWBs02ELFe7pL6Ue9u2gPGKB9q+pKmNtkgZLYqHiZIcn7yN17Yhn M8UauEV2U9HRlEYB/tdJruf+YlFlADCy8Zh76oEyqJm5otfNFIM3eNg9v1Itlc1T QI/6/i2GzzHEjNAQqHnv02fsBGRg6NQ+/j1oyYrnuli6tEXIl1ClwwnE2RUGnfPb N2vLzqeHxrVjQ5YjiXpccm87kOa3gvYCi8ALDiC3FzdA1B05gkcw7DK9kQ9IosUP v4YkzanyL5vi/iBizfnWkWOQlgEIkl8nttRgbp/1HGc4f1ZAGYzRWg0ntaFJx2xm gtbxhz4cXAC6l0O66IBFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674487888; x= 1674574288; bh=Oo3OWL/7/o7GNlBBf1AJnhQlkeEwBF+uxMG7/qcHWMg=; b=s 6dzJDwWd5NqyDt2rPaylCsTCMjxShsSubODCeNp4lOktHIsxAsExzoap90TIysIY bJKXa9VLjDvlR5mDWQU7SnZYARos4AtBUbxnxzuxkOIhckpi8UoQhsTeTEyg/lRm WwSOrGkG5h2O2vRQ0SzAma9JahLRswpTqnCyVweUVQZzy5wFH+20mfph/KJ/wA6Y l/LlIqtMXpSd43VuEACbAgKfZ+8NNiPFNqQ7psQnWsKqSVVZ1yGP9XXlfwpvSLvP 2aKqXVdTcEYkkQ7aW6eWjbwQhL/ETZMy+ZL+KXeWNuUDNrLiAGn3wNRF1kwGP5Vr aGvzPiiCf+a/3pI3vcmaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddukedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpefhieeufeffvdeffedvheeuudfhteetvdeiffehfeetheehjeev vdeitddvgfdvieenucffohhmrghinhepphhrohhofhhpohhinhhtrdgtohhmpdguphgukh drohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Jan 2023 10:31:26 -0500 (EST) From: Thomas Monjalon To: Anoob Joseph Cc: Akhil Goyal , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Olivier Matz , "dev@dpdk.org" , Volodymyr Fialko , Hemant Agrawal , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Kiran Kumar Kokkilagadda , "dev@dpdk.org" Subject: Re: [EXT] Re: [PATCH 1/5] net: add PDCP header Date: Mon, 23 Jan 2023 16:31:23 +0100 Message-ID: <2786687.kdYZ1jHi8b@thomas> In-Reply-To: References: <20221027052140.155-1-anoobj@marvell.com> <28193101.czjnFlTdjD@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2023 10:21, Anoob Joseph: > Hi Thomas, > > Please see inline. > > Thanks, > Anoob > > > Subject: Re: [EXT] Re: [PATCH 1/5] net: add PDCP header > > > > 18/01/2023 18:39, Anoob Joseph: > > > > 22/12/2022 10:25, Anoob Joseph: > > > > > --- /dev/null > > > > > +++ b/lib/net/rte_pdcp_hdr.h > > > > > @@ -0,0 +1,93 @@ > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > + * Copyright(C) 2022 Marvell. > > > > > + */ > > > > > + > > > > > +#ifndef _RTE_PDCP_HDR_H_ > > > > > +#define _RTE_PDCP_HDR_H_ > > > > > > > > No need of extra underscores before and after. > > > > > > [Anoob] I was following the example quoted in > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__doc.dpdk.org_guides_contributing_coding- > > 5Fstyle.html&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyL > > Ws2n6B-WYLn1v9SyTMrT5EQqh2TU&m=Btr0wWqHo_dHGchyRWTnjO6xY- > > 7p33pUSKSBLIXtL4DOAv-GsZmL2lZ2OHyJWoiZ&s=- > > AQhSWF0bWFXTyxL0rPCW6fz6I7GYhwyQ9qjYG3FFn0&e= . > > > > Oh thanks for the reference, I will fix it. > > > > > Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same. > > > > Some other files don't have underscores. > > > > > Isn't it better to have a uniform coding style? > > > > No really I prefer no underscores, > > they are supposed to be used for standard libraries. > > [Anoob] I see that most of the files do have underscores. While I do not have any personal preference, I would really prefer new code to not stand out from the rest. If you have considered this already, then I'll make the change in next version. Please confirm. I prefer no underscore, and I will probably propose to change all files while updating the contributing guide. For new patch, I gave my opinion, now you can choose it is not a big deal.