From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FC4C282DA for ; Fri, 19 Apr 2019 18:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5EE420645 for ; Fri, 19 Apr 2019 18:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="eYM1PhT1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727531AbfDSS4m (ORCPT ); Fri, 19 Apr 2019 14:56:42 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41393 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfDSS4m (ORCPT ); Fri, 19 Apr 2019 14:56:42 -0400 Received: by mail-wr1-f65.google.com with SMTP id c12so1761093wrt.8 for ; Fri, 19 Apr 2019 11:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=nHn3FD1Cu5lDI1f8I4w/j3iX2znhqSHvINOhrbN1emw=; b=eYM1PhT1YHfhjla2Z2TZPdH3eCSfdoxj7zY5HgbkgnDf19RJTXGzSYEbbeTG8jU3rc 6Ccs1zwoLsN8Pjuz5q/xlMl1/nBbWdglyExqVsMyV2xYukLJP2OJR2ivS8EgbWBw8By8 mBGZoMapBkY5dcm4L5v+axYjDKzaZ1b5jtb/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nHn3FD1Cu5lDI1f8I4w/j3iX2znhqSHvINOhrbN1emw=; b=E0i+Q4mr8fsJq4NSahU4MDttWq8lhbPnzRngSLyIZ87vXUIbdL4jGAuAi/0loppKt3 +3327di45gBBEG+T6VAn6C7nekYc7eV92rc9Sg0E5wdPqJ71vbG7LSmR8h+dSuZMtrxu KsDUJSU7o9tosCq/A6wiZNyu6nJhnK2pq8F5fg7S/tHpLWxGQveL9XS6vdcIK0xBzG+z WlXC0ZSnAPjjbCOskx/NjaLVgJG0/ZcRpd+pYBf+Ii5/L7oAa6RIpbejww6Tzim6fXng sT1F5zBD/EGpsHqmdQF/LhRUTvKJO02EMDmf+T6dgtKvlH7bzQV9hyc3l3/lBmamRikA HxKw== X-Gm-Message-State: APjAAAXgqeixoJ8tOSZghTuaYJikMBqE4i6am6JRr3qqH8xUyb2sRrTr tA4ETeRHvCntuQpeql2G/3+JhphVwzQ= X-Google-Smtp-Source: APXvYqwOxW44bv0s9ZFT48R6aTmCYVioknGQzlf2vjTUOlm0cAVXd0Wtp0B9g915Tm5TNvv4cEHAwQ== X-Received: by 2002:adf:e747:: with SMTP id c7mr951104wrn.114.1555675146825; Fri, 19 Apr 2019 04:59:06 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id y125sm7660380wmc.39.2019.04.19.04.59.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 04:59:06 -0700 (PDT) Subject: Re: [PATCH net-next v3 5/5] bridge: update vlan dev link state for bridge netdev changes To: Mike Manning , netdev@vger.kernel.org, roopa@cumulusnetworks.com References: <20190418173535.22925-1-mmanning@vyatta.att-mail.com> <20190418173535.22925-6-mmanning@vyatta.att-mail.com> From: Nikolay Aleksandrov Message-ID: <2788b34d-900d-ccf9-0c82-d1fe4dae31cf@cumulusnetworks.com> Date: Fri, 19 Apr 2019 14:59:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418173535.22925-6-mmanning@vyatta.att-mail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/04/2019 20:35, Mike Manning wrote: > If vlan bridge binding is enabled, then the link state of a vlan device > that is an upper device of the bridge tracks the state of bridge ports > that are members of that vlan. But this can only be done when the link > state of the bridge is up. If it is down, then the link state of the > vlan devices must also be down. This is to maintain existing behavior > for when STP is enabled and there are no live ports, in which case the > link state for the bridge and any vlan devices is down. > > Signed-off-by: Mike Manning > --- > net/bridge/br_vlan.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 47 insertions(+), 3 deletions(-) > Acked-by: Nikolay Aleksandrov