From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] linux-firmware: be consistent with license package naming
Date: Mon, 01 Jul 2013 11:05:29 +0100 [thread overview]
Message-ID: <2792708.QFB8vqRtCT@helios> (raw)
In-Reply-To: <20130628195100.GO3261@jama>
On Friday 28 June 2013 21:51:00 Martin Jansa wrote:
> On Fri, Jun 28, 2013 at 06:56:47PM +0100, Paul Eggleton wrote:
> > Much as I prefer en_GB spelling, we need to be consistent with the other
> > package names in this recipe. Thanks to Trevor Woerner for pointing this
> > out.
> >
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> >
> > meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> > b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb index
> > f586321..81795f2 100644
> > --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> > +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> > @@ -58,7 +58,7 @@ PACKAGES =+ "${PN}-ralink ${PN}-sd8686 ${PN}-wl12xx
> > ${PN}-vt6656 \>
> > ${PN}-rtl-license ${PN}-rtl8192cu ${PN}-rtl8192ce
> > ${PN}-rtl8192su \
> > ${PN}-broadcom-license ${PN}-bcm4329 ${PN}-bcm4330
> > ${PN}-bcm4334 \
> > ${PN}-atheros-license ${PN}-ar9170 ${PN}-ar3k ${PN}-ath6k
> > ${PN}-ath9k \
> >
> > - ${PN}-iwlwifi-licence ${PN}-iwlwifi-6000g2a-5
> > ${PN}-iwlwifi-6000g2b-6" + ${PN}-iwlwifi-license
> > ${PN}-iwlwifi-6000g2a-5 ${PN}-iwlwifi-6000g2b-6">
> > FILES_${PN}-atheros-license = "/lib/firmware/LICENCE.atheros_firmware"
> >
> > @@ -170,10 +170,10 @@ RDEPENDS_${PN}-bcm4334 += "${PN}-broadcom-license"
> >
> > ALTERNATIVE_linux-firmware-bcm4334 = "brcmfmac-sdio.bin"
> > ALTERNATIVE_TARGET_linux-firmware-bcm4334[brcmfmac-sdio.bin] =
> > "/lib/firmware/brcm/brcmfmac4334.bin">
> > -RDEPENDS_${PN}-iwlwifi-6000g2a-5 = "${PN}-iwlwifi-licence"
> > -RDEPENDS_${PN}-iwlwifi-6000g2b-6 = "${PN}-iwlwifi-licence"
> > +RDEPENDS_${PN}-iwlwifi-6000g2a-5 = "${PN}-iwlwifi-license"
> > +RDEPENDS_${PN}-iwlwifi-6000g2b-6 = "${PN}-iwlwifi-license"
> >
> > -FILES_${PN}-iwlwifi-licence = "/lib/firmware/LICENCE.iwlwifi_firmware"
> > +FILES_${PN}-iwlwifi-license = "/lib/firmware/LICENCE.iwlwifi_firmware"
> >
> > FILES_${PN}-iwlwifi-6000g2a-5 = "/lib/firmware/iwlwifi-6000g2a-5.ucode"
> > FILES_${PN}-iwlwifi-6000g2b-6 = "/lib/firmware/iwlwifi-6000g2b-6.ucode"
>
> FWIW there is also -lic suffix in license.bbclass:
> LICENSE_CREATE_PACKAGE ??= "0"
> LICENSE_PACKAGE_SUFFIX ??= "-lic"
>
> I don't know if it would cause some collision between package created
> here and automatically by license.bbclass, but I guess not as the later
> creates only ${PN}-lic.
There's even a comment in the recipe itself that this recipe is a bit of a
mess because of all of the different licenses. I suspect a more automated
approach for this recipe specifically might be better (although upstream file
naming makes this a bit more difficult).
For the moment I just wanted to clean up the more obvious issues.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-07-01 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 17:56 [PATCH 0/2] linux-firmware fixes Paul Eggleton
2013-06-28 17:56 ` [PATCH 1/2] linux-firmware: be consistent with license package naming Paul Eggleton
2013-06-28 19:51 ` Martin Jansa
2013-07-01 10:05 ` Paul Eggleton [this message]
2013-06-28 17:56 ` [PATCH 2/2] linux-firmware: fix ralink license file name Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2792708.QFB8vqRtCT@helios \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.