From: Haakon Bugge <haakon.bugge@oracle.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Prabhakar Kushwaha <pkushwaha@marvell.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"mkalderon@marvell.com" <mkalderon@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"smalin@marvell.com" <smalin@marvell.com>,
"aelior@marvell.com" <aelior@marvell.com>,
"prabhakar.pkin@gmail.com" <prabhakar.pkin@gmail.com>,
"malin1024@gmail.com" <malin1024@gmail.com>
Subject: Re: [PATCH for-next] qedr: Move variables reset to qedr_set_common_qp_params()
Date: Wed, 11 Aug 2021 11:50:39 +0000 [thread overview]
Message-ID: <27B07D29-E863-4561-BDE1-4D687004C782@oracle.com> (raw)
In-Reply-To: <20210811114458.GA7008@nvidia.com>
> On 11 Aug 2021, at 13:44, Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> On Wed, Aug 11, 2021 at 08:16:50AM +0300, Prabhakar Kushwaha wrote:
>> Qedr code is tightly coupled with existing both INIT transitions.
>> Here, during first INIT transition all variables are reset and
>> the RESET state is checked in post_recv() before any posting.
>>
>> Commit dc70f7c3ed34 ("RDMA/cma: Remove unnecessary INIT->INIT
>> transition") exposed this bug.
>
>
> Since we are reverting this the patch still makse sense? Certainly
> having a driver depend on two init->init transitions seems wrong to me
If what I wrote about adhering to the IBTA spec and transition the QP to INIT during rdma_{connect,accept} makes sense, I think we need a two-phased approach.
1. Get the ULPs to adhere. That would not demand any changes in cma.
2. Once 1 has been proven working, we can fix cma and make the transition to INIT in rdma_{connect,accept}.
OK?
Thxs, Håkon
next prev parent reply other threads:[~2021-08-11 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 5:16 [PATCH for-next] qedr: Move variables reset to qedr_set_common_qp_params() Prabhakar Kushwaha
2021-08-11 11:44 ` Jason Gunthorpe
2021-08-11 11:50 ` Haakon Bugge [this message]
2021-08-12 9:44 ` Prabhakar Kushwaha
2021-08-19 17:28 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27B07D29-E863-4561-BDE1-4D687004C782@oracle.com \
--to=haakon.bugge@oracle.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=malin1024@gmail.com \
--cc=mkalderon@marvell.com \
--cc=pkushwaha@marvell.com \
--cc=prabhakar.pkin@gmail.com \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.