All of lore.kernel.org
 help / color / mirror / Atom feed
From: "jack wang" <jack_wang@usish.com>
To: ayan@marvell.com, james.bottomley@hansenpartnership.com,
	jeff@garzik.org, linux-scsi@vger.kernel.org
Cc: qswang@marvell.com, jfeng@marvell.com
Subject: Re: [PATCH 6/7]MVSAS: Enhanced hot plug handling
Date: Tue, 10 Nov 2009 09:38:35 +0800	[thread overview]
Message-ID: <27D4B599214A4AE693D4D01B2AD74FF7@usish.com.cn> (raw)
In-Reply-To: <20091109122713.GE32336@Andy.marvell.com>

@@ -914,13 +911,22 @@ static int mvs_task_exec(struct sas_task *task, const
int num, gfp_t gfp_flags,
 			tei.port = &mvi->port[dev->port->id -
mvi->chip->n_phy];
 		else
 			tei.port = &mvi->port[dev->port->id];
-
-		if (!tei.port->port_attached) {
+		if (tei.port && !tei.port->port_attached) {
 			if (sas_protocol_ata(t->task_proto)) {
-				mv_dprintk("port %d does not"
-					"attached device.\n",
dev->port->id);
-				rc = SAS_PHY_DOWN;
-				goto out_done;
+				struct task_status_struct *ts =
&t->task_status;
+				ts->stat = SAS_PROTO_RESPONSE;
+				ts->stat = SAS_PHY_DOWN;


[Jack] Here ts->stat was double set. Maybe the first one is unnessary.


  reply	other threads:[~2009-11-10  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 12:27 [PATCH 6/7]MVSAS: Enhanced hot plug handling Andy Yan
2009-11-10  1:38 ` jack wang [this message]
2009-11-10  2:51 ` jack wang
2009-12-17 13:44 Caspar Smit
     [not found] ` <e938503f0912201737r1296c47k4518fbeecd48ff00@mail.gmail.com>
2009-12-23 12:13   ` Caspar Smit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27D4B599214A4AE693D4D01B2AD74FF7@usish.com.cn \
    --to=jack_wang@usish.com \
    --cc=ayan@marvell.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jeff@garzik.org \
    --cc=jfeng@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qswang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.