From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ramirez Luna, Omar" Subject: RE: [PATCH 6/8] DSPBRIDGE: Use dspbridge to initialize platform data Date: Fri, 8 Jan 2010 10:48:27 -0600 Message-ID: <27F9C60D11D683428E133F85D2BB4A53042DC9524E@dlee03.ent.ti.com> References: <1262912450-30100-1-git-send-email-omar.ramirez@ti.com> <4B469884.1080209@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:48276 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753899Ab0AHQsd convert rfc822-to-8bit (ORCPT ); Fri, 8 Jan 2010 11:48:33 -0500 In-Reply-To: <4B469884.1080209@ti.com> Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Menon, Nishanth" Cc: linux-omap , Hiroshi Doyu , Ameya Palande , Felipe Contreras , "Guzman Lugo, Fernando" , "Ramos Falcon, Ernesto" >From: Menon, Nishanth > >Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following: >> Include dspbridge compilation whenever bridge driver is selected to >> be compiled, either as a module or part of the kernel. This will >> initialize platform data specific PM functions. >?? are you intending to state that dspbridge.c can now not be a module? Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to be installed depending on selected option (module or built in) >can you elaborate more as to why? Lately EXPORT_SYMBOL has been removed from pm functions, bridge depends on those symbols and now that they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break. > >> >> Signed-off-by: Omar Ramirez Luna >> --- >> arch/arm/mach-omap2/Makefile | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile >> index d1cf986..0881470 100644 >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) >> # Debobs >> obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o >?? I dont find this in l-o master/2.6.32.. something I am missing? > >> >> -obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o >> +ifneq ($(CONFIG_MPU_BRIDGE),) >> +obj-y += dspbridge.o >> +endif > >> >> # Specific board support >> obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o > > >-- >Regards, >Nishanth Menon