From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1E5D-0001g7-Nt for qemu-devel@nongnu.org; Tue, 05 Mar 2019 12:42:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1E5D-0001Ca-4s for qemu-devel@nongnu.org; Tue, 05 Mar 2019 12:42:27 -0500 References: <20190303172343.13406-1-mark.cave-ayland@ilande.co.uk> <20190303172343.13406-8-mark.cave-ayland@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <27b017d4-7573-f857-0e77-087eee7fe9e8@ilande.co.uk> Date: Tue, 5 Mar 2019 17:42:23 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au On 03/03/2019 23:33, Richard Henderson wrote: > On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: >> -static inline int fpr_offset(int i) >> +static inline int vsrh_offset(int i) > > I don't agree with this. The original is clearer for its uses. Well as the patchset was coming from a VSX perspective, I took the approach that more people would be familiar with high/low pair rather than understanding that VSX was evolution of the original FPRs. But again for me, I'm happy with either way so I don't mind changing it. ATB, Mark.