From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0807C7618B for ; Thu, 25 Jul 2019 17:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8185122C7E for ; Thu, 25 Jul 2019 17:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbfGYRAc (ORCPT ); Thu, 25 Jul 2019 13:00:32 -0400 Received: from mga14.intel.com ([192.55.52.115]:54474 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbfGYRAb (ORCPT ); Thu, 25 Jul 2019 13:00:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 10:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,307,1559545200"; d="scan'208";a="345497434" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by orsmga005.jf.intel.com with ESMTP; 25 Jul 2019 10:00:28 -0700 Subject: Re: [PATCH bpf-next v3 08/11] samples/bpf: add unaligned chunks mode support to xdpsock To: Maxim Mikityanskiy Cc: "netdev@vger.kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "Topel, Bjorn" , "Karlsson, Magnus" , "jakub.kicinski@netronome.com" , "jonathan.lemon@gmail.com" , Saeed Mahameed , "stephen@networkplumber.org" , "Richardson, Bruce" , "Loftus, Ciara" , "bpf@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" References: <20190716030637.5634-1-kevin.laatz@intel.com> <20190724051043.14348-1-kevin.laatz@intel.com> <20190724051043.14348-9-kevin.laatz@intel.com> From: "Laatz, Kevin" Message-ID: <27c5c008-def3-d9dc-792c-e5a500103be8@intel.com> Date: Thu, 25 Jul 2019 18:00:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 25/07/2019 10:43, Maxim Mikityanskiy wrote: > On 2019-07-24 08:10, Kevin Laatz wrote: >> This patch adds support for the unaligned chunks mode. The addition of the >> unaligned chunks option will allow users to run the application with more >> relaxed chunk placement in the XDP umem. >> >> Unaligned chunks mode can be used with the '-u' or '--unaligned' command >> line options. >> >> Signed-off-by: Kevin Laatz >> Signed-off-by: Ciara Loftus >> --- >> samples/bpf/xdpsock_user.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) > <...> > >> @@ -372,6 +378,7 @@ static void usage(const char *prog) >> " -z, --zero-copy Force zero-copy mode.\n" >> " -c, --copy Force copy mode.\n" >> " -f, --frame-size=n Set the frame size (must be a power of two, default is %d).\n" > Help text for -f has to be updated, it doesn't have to be a power of two > if -u is specified. Will fix in the v4, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laatz, Kevin Date: Thu, 25 Jul 2019 18:00:27 +0100 Subject: [Intel-wired-lan] [PATCH bpf-next v3 08/11] samples/bpf: add unaligned chunks mode support to xdpsock In-Reply-To: References: <20190716030637.5634-1-kevin.laatz@intel.com> <20190724051043.14348-1-kevin.laatz@intel.com> <20190724051043.14348-9-kevin.laatz@intel.com> Message-ID: <27c5c008-def3-d9dc-792c-e5a500103be8@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 25/07/2019 10:43, Maxim Mikityanskiy wrote: > On 2019-07-24 08:10, Kevin Laatz wrote: >> This patch adds support for the unaligned chunks mode. The addition of the >> unaligned chunks option will allow users to run the application with more >> relaxed chunk placement in the XDP umem. >> >> Unaligned chunks mode can be used with the '-u' or '--unaligned' command >> line options. >> >> Signed-off-by: Kevin Laatz >> Signed-off-by: Ciara Loftus >> --- >> samples/bpf/xdpsock_user.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) > <...> > >> @@ -372,6 +378,7 @@ static void usage(const char *prog) >> " -z, --zero-copy Force zero-copy mode.\n" >> " -c, --copy Force copy mode.\n" >> " -f, --frame-size=n Set the frame size (must be a power of two, default is %d).\n" > Help text for -f has to be updated, it doesn't have to be a power of two > if -u is specified. Will fix in the v4, thanks!