From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC00C433FE for ; Tue, 7 Sep 2021 08:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8225610C8 for ; Tue, 7 Sep 2021 08:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241634AbhIGIBu (ORCPT ); Tue, 7 Sep 2021 04:01:50 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:39262 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231366AbhIGIBs (ORCPT ); Tue, 7 Sep 2021 04:01:48 -0400 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 312245765; Tue, 07 Sep 2021 16:00:39 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from mtksdccf07 (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Sep 2021 16:00:37 +0800 Message-ID: <27ca1a1e99193b543102df03f7c256063468f693.camel@mediatek.com> Subject: Re: [PATCH] ASoC: mediatek: mt8195: Fix unused initialization of pointer etdm_data From: Trevor Wu To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , CC: , Date: Tue, 7 Sep 2021 16:00:37 +0800 In-Reply-To: <20210903114928.11743-1-colin.king@canonical.com> References: <20210903114928.11743-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-09-03 at 12:49 +0100, Colin King wrote: > From: Colin Ian King > > The pointer etdm_data is being inintialized with a value that is > never > read, it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > index 7378e42f2766..ac591d453e1e 100644 > --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > @@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct > snd_soc_dai *dai, > { > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > struct mt8195_afe_private *afe_priv = afe->platform_priv; > - struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai- > >id]; > + struct mtk_dai_etdm_priv *etdm_data; > int dai_id; > > dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n", Acked-by: Trevor Wu Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848C7C433F5 for ; Tue, 7 Sep 2021 08:01:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4893B61051 for ; Tue, 7 Sep 2021 08:01:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4893B61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RR9dA7YwU8pC/4HRntz3wftmpe7PoSGFny1yEvWiqXc=; b=fCLZ0ADKhfNVBp xtOEUXKvSOsiVRgjhTgJudVfBVXvjHPTkvlsch1jO9eb9lYOEHmsmfdlfgQlRDrPnKCwPJ16lw5S6 HV588SPNJwCziQxQaBWNJKpvZYB3oQXJ8TTcsPhZc6bf4cnqWoxDyElKVZxaDxWwxRzVOGAUOBqDh pvm94/U8ZIv2qebxZSVcOUPD6pHkiHD9YSmpOdknmNSjq7lGbeauG5JnUgRNMoWXfhGpnR155WJPx mSGou31fSFJcg83Hlo0NfvLH5DwAl+T7QscVrw+wTgCgGz/ZwIvbLgi5ouX/tLRaMLJZuuPSMPZ7/ g8hKLuWOAqgeIbxwA7ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNW2N-002oOe-51; Tue, 07 Sep 2021 08:00:59 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNW28-002oNQ-8U; Tue, 07 Sep 2021 08:00:47 +0000 X-UUID: 1d10811026b24436a2383bc4ac050239-20210907 X-UUID: 1d10811026b24436a2383bc4ac050239-20210907 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1004632168; Tue, 07 Sep 2021 01:00:40 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 01:00:38 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from mtksdccf07 (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Sep 2021 16:00:37 +0800 Message-ID: <27ca1a1e99193b543102df03f7c256063468f693.camel@mediatek.com> Subject: Re: [PATCH] ASoC: mediatek: mt8195: Fix unused initialization of pointer etdm_data From: Trevor Wu To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , CC: , Date: Tue, 7 Sep 2021 16:00:37 +0800 In-Reply-To: <20210903114928.11743-1-colin.king@canonical.com> References: <20210903114928.11743-1-colin.king@canonical.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_010044_355048_5B5EEE4E X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-09-03 at 12:49 +0100, Colin King wrote: > From: Colin Ian King > > The pointer etdm_data is being inintialized with a value that is > never > read, it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > index 7378e42f2766..ac591d453e1e 100644 > --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > @@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct > snd_soc_dai *dai, > { > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > struct mt8195_afe_private *afe_priv = afe->platform_priv; > - struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai- > >id]; > + struct mtk_dai_etdm_priv *etdm_data; > int dai_id; > > dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n", Acked-by: Trevor Wu Thanks. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968E6C433F5 for ; Tue, 7 Sep 2021 08:01:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6734861102 for ; Tue, 7 Sep 2021 08:01:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6734861102 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 65D2E1720; Tue, 7 Sep 2021 10:00:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 65D2E1720 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1631001708; bh=WlkMT4XmOwNwUh4+R6ZRlMFJj6L4Tmm3xl8mgaZlTWk=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fOwJYwoiuknH6AnG2TJdLigh93wsO7x3pHrz9uTjwQMHrF7cZuc83afGvvVouNonL pHEB5J0qTP+rVlLx6W8i9wU67Z/45UTkVtF6iQuPJSLRlRktphQtntiKH5tcVkIIxs lnI5+jte1hxVh4U0/aMCVjUa8+pmtTQh/l7AgHhY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D69DBF80103; Tue, 7 Sep 2021 10:00:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C31F6F80224; Tue, 7 Sep 2021 10:00:55 +0200 (CEST) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 30F42F80103 for ; Tue, 7 Sep 2021 10:00:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 30F42F80103 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 X-UUID: 289a8e123b5d49daab79ec2ce6a8031d-20210907 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 312245765; Tue, 07 Sep 2021 16:00:39 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from mtksdccf07 (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Sep 2021 16:00:37 +0800 Message-ID: <27ca1a1e99193b543102df03f7c256063468f693.camel@mediatek.com> Subject: Re: [PATCH] ASoC: mediatek: mt8195: Fix unused initialization of pointer etdm_data From: Trevor Wu To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , Date: Tue, 7 Sep 2021 16:00:37 +0800 In-Reply-To: <20210903114928.11743-1-colin.king@canonical.com> References: <20210903114928.11743-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 2021-09-03 at 12:49 +0100, Colin King wrote: > From: Colin Ian King > > The pointer etdm_data is being inintialized with a value that is > never > read, it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > index 7378e42f2766..ac591d453e1e 100644 > --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > @@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct > snd_soc_dai *dai, > { > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > struct mt8195_afe_private *afe_priv = afe->platform_priv; > - struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai- > >id]; > + struct mtk_dai_etdm_priv *etdm_data; > int dai_id; > > dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n", Acked-by: Trevor Wu Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC740C433EF for ; Tue, 7 Sep 2021 08:03:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A28986108E for ; Tue, 7 Sep 2021 08:03:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A28986108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oJ4qsgLhV7wVcdNPgtRMHFTAhr+JJ9he1xuB+8tgvOs=; b=1v3oktTkhNkueD CgvhR54sXRYJxIktTwpLCsN3LP5NRN+etI3kljmbVPDFlhGMzfsJXCergKn52cK0bOCtiW63tIIBG jrCqr0AoBGS5Z9wXtG0TxlXldPWRyUiTwt7/PFYr+Y0O+M+wGiOdz35SWEp1LQBE1SGVHQ7DzC03T sSjVVjYFZqfQjnGkGrT2qgOsWP+WX9dZo/T/2TvC3ym+WdbtpkdizB6+OVAMD1U9a5k6RobQlhoTn HDlE3dgpFUzhgWmLlWrGUJdWFK3v8PK3PFNimzmY2qbyDOWTkmWcwfOQ8EwvBNqvYqN1Ke7/vDHIA A6xJg0WTJsFXcVsn17hQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNW2E-002oOB-AG; Tue, 07 Sep 2021 08:00:50 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNW28-002oNQ-8U; Tue, 07 Sep 2021 08:00:47 +0000 X-UUID: 1d10811026b24436a2383bc4ac050239-20210907 X-UUID: 1d10811026b24436a2383bc4ac050239-20210907 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1004632168; Tue, 07 Sep 2021 01:00:40 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 01:00:38 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas07.mediatek.inc (172.21.101.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Sep 2021 16:00:37 +0800 Received: from mtksdccf07 (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Sep 2021 16:00:37 +0800 Message-ID: <27ca1a1e99193b543102df03f7c256063468f693.camel@mediatek.com> Subject: Re: [PATCH] ASoC: mediatek: mt8195: Fix unused initialization of pointer etdm_data From: Trevor Wu To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , CC: , Date: Tue, 7 Sep 2021 16:00:37 +0800 In-Reply-To: <20210903114928.11743-1-colin.king@canonical.com> References: <20210903114928.11743-1-colin.king@canonical.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_010044_355048_5B5EEE4E X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-09-03 at 12:49 +0100, Colin King wrote: > From: Colin Ian King > > The pointer etdm_data is being inintialized with a value that is > never > read, it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > index 7378e42f2766..ac591d453e1e 100644 > --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c > @@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct > snd_soc_dai *dai, > { > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > struct mt8195_afe_private *afe_priv = afe->platform_priv; > - struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai- > >id]; > + struct mtk_dai_etdm_priv *etdm_data; > int dai_id; > > dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n", Acked-by: Trevor Wu Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel