All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@skidata.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-java][PATCH] java-library: make easy to override jar package name
Date: Mon, 17 Dec 2018 15:53:55 +0100	[thread overview]
Message-ID: <27d7d7bf-e203-5f67-0d19-0207f4adc970@skidata.com> (raw)
In-Reply-To: <CABPh3UPXB=MzAUwMgmfaKZ100Fqgp7juiv1R61AaYfpFCFeefw@mail.gmail.com>

Hi,
thanks for the patch.

Two things:

First can you please use your real name in the From: (or prepend the From: line to the email body).

Second: would you please describe the reasons for changing = to ?= in more detail?
What's the purpose/benefit you get from it?

thanks & regards;Richard.L

On 23.11.18 16:09, nick83ola wrote:
> define JARFILENAME and ALTJARFILENAMES with ?= to make simple
> to override them
> 
> Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
> ---
> classes/java-library.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
> index ce1cd28..c69cf6b 100644
> --- a/classes/java-library.bbclass
> +++ b/classes/java-library.bbclass
> @@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
> FILES_${JPN} = "${datadir_java}"
> # File name of the libraries' main Jar file
> -JARFILENAME = "${BP}.jar"
> +JARFILENAME ?= "${BP}.jar"
> # Space-separated list of alternative file names.
> -ALTJARFILENAMES = "${BPN}.jar"
> +ALTJARFILENAMES ?= "${BPN}.jar"
> # Java "source" distributions often contain precompiled things
> # we want to delete first.
> 


  reply	other threads:[~2018-12-17 14:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 15:09 [meta-java][PATCH] java-library: make easy to override jar package name nick83ola
2018-12-17 14:53 ` Richard Leitner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-11-23 14:57 Nicola Lunghi
2018-11-23 14:53 Nicola Lunghi
2018-11-23 14:38 Nicola Lunghi
2018-11-23 14:37 Nicola Lunghi
2018-11-23 14:31 Nicola Lunghi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27d7d7bf-e203-5f67-0d19-0207f4adc970@skidata.com \
    --to=richard.leitner@skidata.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.