From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH V2 2/4] Utilize the vmx preemption timer Date: Tue, 14 Jun 2016 15:41:07 +0200 Message-ID: <27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com> References: <1464128852-14138-1-git-send-email-yunhong.jiang@linux.intel.com> <1464128852-14138-3-git-send-email-yunhong.jiang@linux.intel.com> <20160614125537.b3qlcjytjb64ezht@rkaganb.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Roman Kagan , Yunhong Jiang , kvm@vger.kernel.org, mtosatti@redhat.com, rkrcmar@redhat.com, kernellwp@gmail.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45594 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbcFNNlS (ORCPT ); Tue, 14 Jun 2016 09:41:18 -0400 In-Reply-To: <20160614125537.b3qlcjytjb64ezht@rkaganb.sw.ru> Sender: kvm-owner@vger.kernel.org List-ID: On 14/06/2016 15:23, Roman Kagan wrote: >> > >> > +static int cpu_preemption_timer_multi; >> > +static bool __read_mostly enable_hv_timer; >> > +module_param_named(enable_hv_timer, enable_hv_timer, bool, S_IRUGO); >> > + > Non-techincal issue: I think the naming for the parameter is > unfortunate, as it looks similar to a number of CPU properties in QEMU > that start with "hv-", which are all related to MS Hyper-V compatibility > features. Non-technical but important. Let's change it to preemption_timer (and the variable to enable_preemption_timer). The code can keep the "hv_timer" moniker though. Paolo