From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71BC9C433EF for ; Thu, 10 Feb 2022 00:52:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 11DA960E5F; Thu, 10 Feb 2022 00:52:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y4uCLzp0m9zm; Thu, 10 Feb 2022 00:52:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id E04EC60E46; Thu, 10 Feb 2022 00:52:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A0C4EC001A; Thu, 10 Feb 2022 00:52:28 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id CE010C000B for ; Thu, 10 Feb 2022 00:52:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C953B60E5E for ; Thu, 10 Feb 2022 00:52:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rP9_qg3uZBCG for ; Thu, 10 Feb 2022 00:52:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by smtp3.osuosl.org (Postfix) with ESMTPS id D834D60E5A for ; Thu, 10 Feb 2022 00:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644454345; x=1675990345; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=3TVWAm9LlhlLa2IkCVU8wnRmJGrW+1uk41RrCt4p/Tc=; b=PERytT4rZuUuJxcR8dsxSXtK7gJYlKRsYVkbc+2p0eWUTsivHtGLsINT w966UFL76ejPV6plQc4Fn5dXbfqxCutee8qZl0nZNYGJ3DaPbIv5xYbGY uSWM5ymqEyUzSkgrFReX7WdtQDNtkJhjFLHnt9dqN6eSLNxcnt3Rggb6f 3Pbj2k4MXHENFGNC/acGGSa7qRK7giDWzJNs28fG5j+ZfrVa0lkV9gpDc qj2g7ypTZRAB4bFj8KrFslRSyNOFDujDfZ/RwtEf7+jtrc83kqw2iBhpS T1g+YJXHHQGn4ZyoQ6spp3DknXWj9kzO3MPot46JiizXuy9sEcvQXvvZ0 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="248210953" X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="248210953" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 16:52:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="678968070" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2022 16:52:21 -0800 Message-ID: <27fbcb02-4f13-3377-eadd-e689ce063348@linux.intel.com> Date: Thu, 10 Feb 2022 08:51:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred Content-Language: en-US To: Robin Murphy , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Ben Skeggs , Kevin Tian , Ashok Raj , Will Deacon References: <20220208012559.1121729-1-baolu.lu@linux.intel.com> <20220208012559.1121729-9-baolu.lu@linux.intel.com> <290a89f0-8318-6130-468c-6412add62cfb@arm.com> From: Lu Baolu In-Reply-To: <290a89f0-8318-6130-468c-6412add62cfb@arm.com> Cc: David Airlie , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jonathan Hunter , Alex Williamson , Thierry Reding , Jacob jun Pan , Daniel Vetter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMi85LzIyIDk6NTIgUE0sIFJvYmluIE11cnBoeSB3cm90ZToKPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvaW50ZWwvaW9tbXUuYyBiL2RyaXZlcnMvaW9tbXUvaW50ZWwvaW9tbXUuYwo+ PiBpbmRleCAyYjVmNGU1N2E4YmIuLjgwZjEyOTRiZTYzNCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9pb21tdS9pbnRlbC9pb21tdS5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvaW50ZWwvaW9tbXUu Ywo+PiBAQCAtNTA1Miw4ICs1MDUyLDcgQEAgaW50ZWxfaW9tbXVfZGV2X2Rpc2FibGVfZmVhdChz dHJ1Y3QgZGV2aWNlICpkZXYsIAo+PiBlbnVtIGlvbW11X2Rldl9mZWF0dXJlcyBmZWF0KQo+PiDC oMKgwqDCoMKgIH0KPj4gwqAgfQo+PiAtc3RhdGljIGJvb2wgaW50ZWxfaW9tbXVfaXNfYXR0YWNo X2RlZmVycmVkKHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwKPj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2UgKmRldikKPj4gK3N0 YXRpYyBib29sIGludGVsX2lvbW11X2lzX2F0dGFjaF9kZWZlcnJlZChzdHJ1Y3QgZGV2aWNlICpk ZXYpCj4+IMKgIHsKPj4gwqDCoMKgwqDCoCByZXR1cm4gYXR0YWNoX2RlZmVycmVkKGRldik7Cj4g Cj4gU2VlbXMgbGlrZSB0aGVyZSdzIG5vIG5lZWQgdG8gd3JhcCB0aGlzIG5vdz8KClllcy4gSXQn cyBwb2ludGxlc3MuCgpCZXN0IHJlZ2FyZHMsCmJhb2x1CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE160C433F5 for ; Thu, 10 Feb 2022 01:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbiBJBXs (ORCPT ); Wed, 9 Feb 2022 20:23:48 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:44400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231857AbiBJBXm (ORCPT ); Wed, 9 Feb 2022 20:23:42 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 650931EC7D for ; Wed, 9 Feb 2022 17:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644456220; x=1675992220; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=3TVWAm9LlhlLa2IkCVU8wnRmJGrW+1uk41RrCt4p/Tc=; b=nIveuFRjgR54ayuDiKg1FgrmA2M6tKaD/CUQGoG1yYChZZzEqGEfDYzt +SnpZkf6dVZMf9lzR7Cp8/V/vsrgKjapPuwNtmneUShkNqkcJZs2WS5Hg bi/TT9Nx1iMaCVtcmmYZIjWMXhtyQieE5epfa2CQSMoFgsaWILmB3N2rM ILoLDMyib7eF5tH1DclwpLKvnekhLd8GuoT4d1VkyTItTsC+GUM+X5lgr MOWAR5gnuqCgfDaCT2PXZu1Wykg7Q0jKiF3KmcIl336oB99QyipfqYWar E5BKL3lUIG44ScRU41CUytJpDYz7F1bJWlI1kMGCT6td9UklYhQT+fr8g w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="273923635" X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="273923635" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 16:52:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="678968070" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2022 16:52:21 -0800 Message-ID: <27fbcb02-4f13-3377-eadd-e689ce063348@linux.intel.com> Date: Thu, 10 Feb 2022 08:51:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: baolu.lu@linux.intel.com, Alex Williamson , Eric Auger , Liu Yi L , Jacob jun Pan , David Airlie , Daniel Vetter , Thierry Reding , Jonathan Hunter , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred Content-Language: en-US To: Robin Murphy , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Ben Skeggs , Kevin Tian , Ashok Raj , Will Deacon References: <20220208012559.1121729-1-baolu.lu@linux.intel.com> <20220208012559.1121729-9-baolu.lu@linux.intel.com> <290a89f0-8318-6130-468c-6412add62cfb@arm.com> From: Lu Baolu In-Reply-To: <290a89f0-8318-6130-468c-6412add62cfb@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 9:52 PM, Robin Murphy wrote: >> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c >> index 2b5f4e57a8bb..80f1294be634 100644 >> --- a/drivers/iommu/intel/iommu.c >> +++ b/drivers/iommu/intel/iommu.c >> @@ -5052,8 +5052,7 @@ intel_iommu_dev_disable_feat(struct device *dev, >> enum iommu_dev_features feat) >>       } >>   } >> -static bool intel_iommu_is_attach_deferred(struct iommu_domain *domain, >> -                       struct device *dev) >> +static bool intel_iommu_is_attach_deferred(struct device *dev) >>   { >>       return attach_deferred(dev); > > Seems like there's no need to wrap this now? Yes. It's pointless. Best regards, baolu