From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 36/41] net/dpaa: add support for packet
	type parsing
Date: Thu, 21 Sep 2017 18:46:01 +0530
Message-ID: <280151f6-407e-70d3-d8d6-9405a2134e13@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-37-shreyansh.jain@nxp.com>
 <2d5f1c10-5f8d-6f65-f70c-a886528ca23d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0080.outbound.protection.outlook.com [104.47.32.80])
 by dpdk.org (Postfix) with ESMTP id E41DE1B1B7
 for <dev@dpdk.org>; Thu, 21 Sep 2017 15:05:09 +0200 (CEST)
In-Reply-To: <2d5f1c10-5f8d-6f65-f70c-a886528ca23d@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:26 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Add support for parsing the packet type and L2/L3 checksum offload
>> capability information.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>>   doc/guides/nics/features/dpaa.ini |   2 +
>>   drivers/net/dpaa/dpaa_ethdev.c    |  27 +++++
>>   drivers/net/dpaa/dpaa_rxtx.c      | 116 +++++++++++++++++++++
>>   drivers/net/dpaa/dpaa_rxtx.h      | 206 ++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 351 insertions(+)
>>
>> diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini
>> index 1ba6b11..2ef1b56 100644
>> --- a/doc/guides/nics/features/dpaa.ini
>> +++ b/doc/guides/nics/features/dpaa.ini
>> @@ -11,7 +11,9 @@ MTU update           = Y
>>   Promiscuous mode     = Y
>>   Allmulticast mode    = Y
>>   Unicast MAC filter   = Y
>> +RSS hash             = Y
> 
> Not sure about claiming this support yet. Iss mbuf rss hash field set in
> Rx path, or is packets distributed to multiple queues using rss hash
> functions at this point?

For DPAA, distribution is enabled through configuration prior to running 
DPDK binary. At this point, the code is fetching the current state and 
filling in the mbuf support.

So, this is not about enabling RSS only when dev_conf.rxmode.mq_mode is 
set. Does this change the way we look at "RSS hash" support? If that is 
not what this feature is intended for, I will remove this support tag.

> 
> <...>
>