From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8126C433DF for ; Thu, 2 Jul 2020 20:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0BB120884 for ; Thu, 2 Jul 2020 20:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="d3SGD0CB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbgGBUtl (ORCPT ); Thu, 2 Jul 2020 16:49:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBUtl (ORCPT ); Thu, 2 Jul 2020 16:49:41 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2CBC08C5C1 for ; Thu, 2 Jul 2020 13:49:40 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k6so30039361wrn.3 for ; Thu, 02 Jul 2020 13:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=wom8WLHjfL3Q8VlfcUPECxzZe9g1W+gEf0ik/X56Z/Q=; b=d3SGD0CBMF/xD10eb7Ube4/02nWKnG5B2G/Qo/a2Ht860voJLXOnDIO0bmS3dNyq91 zQQaOHymx7jDdyKsA9wgIZKhiuEedFmsZlv93IPfP2HXZcG+3foqg/lEK5eXZYHBUPQ1 mlNMjDIW1m0Ksccj1zdN/vCfsx2UxgbN9gct4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wom8WLHjfL3Q8VlfcUPECxzZe9g1W+gEf0ik/X56Z/Q=; b=UP15FPYrNrILgJCRoLq4g4kX20AVAwvH4nZKQb5NjCttCes8luiclSHUrUrHDov7Vt ircZxDmfI8ARBi/3E/8tR1p6fXogBdwMOY7qtnKCOwitVcBjUH/UDVLfpY96NtXHGyBH E1et8qXMzERNKCzcYSjWAzaucScQkAbEp0flIs0kOOVsrIsemcwA3Gz+OqXk67dfe9pa gBA7QgTzauCjKyBh0ozdQY7rD/7h1YUGXyicDGtjndHq9oe3uO2XXGv/FCtajJuxfzLm 66R5LxfzWr4eVgm1aM9d8aXJjsde1FWki9bURtDRW+s97ECprJFP/JeE1KtnjxIFadfi NoGw== X-Gm-Message-State: AOAM531TB0MoOf80JDuSnh7uuUxwb7JfHlTJlhhVoeBWVlHjxIO2kMRK wYnSru6Q42WtQlNcHHXyZ7FvM74OFjs8LA== X-Google-Smtp-Source: ABdhPJxtA/2UYvPFmcoCOjprUjTVjn63lRIydkAoEW2AsGRYSN1zgGxBHlr0G2YhtBN0+mtt9RC0RQ== X-Received: by 2002:a5d:4d8b:: with SMTP id b11mr33438657wru.341.1593722979286; Thu, 02 Jul 2020 13:49:39 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id t4sm12192617wmf.4.2020.07.02.13.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 13:49:38 -0700 (PDT) Subject: Re: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used To: Lee Jones Cc: ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrian Hunter , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> <3a32b98c-45c6-6f8d-0853-161f91e65b57@broadcom.com> <20200702201348.GT1179328@dell> From: Scott Branden Message-ID: <28024d96-5687-cb5a-e3c9-86e9831f6ca5@broadcom.com> Date: Thu, 2 Jul 2020 13:49:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702201348.GT1179328@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-02 1:13 p.m., Lee Jones wrote: > On Thu, 02 Jul 2020, Scott Branden wrote: > >> Hi Lee, >> >> On 2020-07-01 5:47 a.m., Lee Jones wrote: >>> ... as is the case when !CONFIG_ACPI. >>> >>> Fixes the following W=1 kernel build warning: >>> >>> mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=] >>> >>> Cc: Adrian Hunter >>> Cc: Ray Jui >>> Cc: Scott Branden >>> Cc: bcm-kernel-feedback-list@broadcom.com >>> Signed-off-by: Lee Jones >>> --- >>> drivers/mmc/host/sdhci-iproc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c >>> index 225603148d7de..9c7d130205edd 100644 >>> --- a/drivers/mmc/host/sdhci-iproc.c >>> +++ b/drivers/mmc/host/sdhci-iproc.c >>> @@ -294,7 +294,7 @@ static const struct of_device_id sdhci_iproc_of_match[] = { >>> }; >>> MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match); >> Would it better to compile this in if CONFIG_ACPI is defined instead? >> #if CONFIG_ACPI > Literally can't win. > > https://lore.kernel.org/linux-arm-kernel/CAGb2v66Ws4WNPZbOYQvikKoozj_2WjzS-Jq-o2VxT77=k0vODw@mail.gmail.com/ > > Damned if we do, damned if we don't. ;) This is very minor in this one change here, but it's just more bloat of things that really should be compiled out if they're not used. I don't understand why __maybe_unused would be preferred approach - unless it is not linked in when it is not used? > >>> -static const struct acpi_device_id sdhci_iproc_acpi_ids[] = { >>> +static const struct acpi_device_id __maybe_unused sdhci_iproc_acpi_ids[] = { >>> { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data }, >>> { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data }, >>> { /* sentinel */ } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE42C433DF for ; Thu, 2 Jul 2020 20:51:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1669520672 for ; Thu, 2 Jul 2020 20:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZVCRWhZU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="d3SGD0CB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1669520672 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QNR9eG+IswtKTQ78Aky5cYRRWdBKr5/EFLHqEhV+6MA=; b=ZVCRWhZUcEQEXY2dy10E62pCO X2hLgyBsaVV6V6N+sU8LOgvDmrxe05aFdtRv7uyzG1NzlOQHHsGGeLzaVIDBn9ksXcgSwGUGek0st EfRaUYgvcYgt/x4m6Uz3QJjPiCNusrBUXeWSpHjhMBTU6VpBmaLdQR2RRY7meh5GicaCFd6LF1xSD tXly/qsD0s4W9lX25IVQC6RcKzHcL91pRe0GU4IjFo5y8v02Wob5f+V8Znj3L4kw2uhN632zr9N6g UlwqjX5NlQq4hZGcbPvUUkBj3mFf7EgaqHVjectlF19fYL8Uz4gXI3g7JyzutcTDV4JJsMdWjCy/Y dQT1yBPJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr69Q-0000ow-H7; Thu, 02 Jul 2020 20:49:44 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr69M-0000oP-PJ for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 20:49:43 +0000 Received: by mail-wr1-x442.google.com with SMTP id f2so2057417wrp.7 for ; Thu, 02 Jul 2020 13:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=wom8WLHjfL3Q8VlfcUPECxzZe9g1W+gEf0ik/X56Z/Q=; b=d3SGD0CBMF/xD10eb7Ube4/02nWKnG5B2G/Qo/a2Ht860voJLXOnDIO0bmS3dNyq91 zQQaOHymx7jDdyKsA9wgIZKhiuEedFmsZlv93IPfP2HXZcG+3foqg/lEK5eXZYHBUPQ1 mlNMjDIW1m0Ksccj1zdN/vCfsx2UxgbN9gct4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wom8WLHjfL3Q8VlfcUPECxzZe9g1W+gEf0ik/X56Z/Q=; b=XvprY3Bxg34c1Ze8KpEhiYGR3Vp9lbSNbWrnG6kEgc4ftBBUY7GrPvua7xGXkwjCmO 7R8tCnRhNX22yANrUtfZxSQHAlKMNzgxHtc5za5wY/s0PvFBIhij6/AREdQpq2z7/2cG bL+qW8mFU9HDOxpA09ocCUK4UKItLtkB6eKYkQehgfGX62/PoZ3mgkSypgVSAwUqXpoD zjnNMYpnVuA5YIq14ZFLJbmelFL4vfk/41TEe3RbZDRCLYOIf3S8FTDchmzDVxtmi5qP fIabSshwMPHsM3TRc81tX7k1W9c+aKePAvs4y1A494iwxwCrXpxTugHsS28M1MZqz6R/ RmFg== X-Gm-Message-State: AOAM530hR/kFi9LqJjlrdAuhylgfAyV1r1ve90HR8e84UeBzjoya+YHx IfnGApK3vFcP8vzxkMqTQMo8Sw== X-Google-Smtp-Source: ABdhPJxtA/2UYvPFmcoCOjprUjTVjn63lRIydkAoEW2AsGRYSN1zgGxBHlr0G2YhtBN0+mtt9RC0RQ== X-Received: by 2002:a5d:4d8b:: with SMTP id b11mr33438657wru.341.1593722979286; Thu, 02 Jul 2020 13:49:39 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id t4sm12192617wmf.4.2020.07.02.13.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 13:49:38 -0700 (PDT) Subject: Re: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used To: Lee Jones References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> <3a32b98c-45c6-6f8d-0853-161f91e65b57@broadcom.com> <20200702201348.GT1179328@dell> From: Scott Branden Message-ID: <28024d96-5687-cb5a-e3c9-86e9831f6ca5@broadcom.com> Date: Thu, 2 Jul 2020 13:49:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702201348.GT1179328@dell> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_164941_117095_57B1118B X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Adrian Hunter , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIwLTA3LTAyIDE6MTMgcC5tLiwgTGVlIEpvbmVzIHdyb3RlOgo+IE9uIFRodSwgMDIg SnVsIDIwMjAsIFNjb3R0IEJyYW5kZW4gd3JvdGU6Cj4KPj4gSGkgTGVlLAo+Pgo+PiBPbiAyMDIw LTA3LTAxIDU6NDcgYS5tLiwgTGVlIEpvbmVzIHdyb3RlOgo+Pj4gLi4uIGFzIGlzIHRoZSBjYXNl IHdoZW4gIUNPTkZJR19BQ1BJLgo+Pj4KPj4+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5l bCBidWlsZCB3YXJuaW5nOgo+Pj4KPj4+ICAgIG1tYy9ob3N0L3NkaGNpLWlwcm9jLmM6Mjk3OjM2 OiB3YXJuaW5nOiDigJhzZGhjaV9pcHJvY19hY3BpX2lkc+KAmSBkZWZpbmVkIGJ1dCBub3QgdXNl ZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+Pj4KPj4+IENjOiBBZHJpYW4gSHVudGVyIDxh ZHJpYW4uaHVudGVyQGludGVsLmNvbT4KPj4+IENjOiBSYXkgSnVpIDxyanVpQGJyb2FkY29tLmNv bT4KPj4+IENjOiBTY290dCBCcmFuZGVuIDxzYnJhbmRlbkBicm9hZGNvbS5jb20+Cj4+PiBDYzog YmNtLWtlcm5lbC1mZWVkYmFjay1saXN0QGJyb2FkY29tLmNvbQo+Pj4gU2lnbmVkLW9mZi1ieTog TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPj4+IC0tLQo+Pj4gICAgZHJpdmVycy9t bWMvaG9zdC9zZGhjaS1pcHJvYy5jIHwgMiArLQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbW1j L2hvc3Qvc2RoY2ktaXByb2MuYyBiL2RyaXZlcnMvbW1jL2hvc3Qvc2RoY2ktaXByb2MuYwo+Pj4g aW5kZXggMjI1NjAzMTQ4ZDdkZS4uOWM3ZDEzMDIwNWVkZCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZl cnMvbW1jL2hvc3Qvc2RoY2ktaXByb2MuYwo+Pj4gKysrIGIvZHJpdmVycy9tbWMvaG9zdC9zZGhj aS1pcHJvYy5jCj4+PiBAQCAtMjk0LDcgKzI5NCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2Zf ZGV2aWNlX2lkIHNkaGNpX2lwcm9jX29mX21hdGNoW10gPSB7Cj4+PiAgICB9Owo+Pj4gICAgTU9E VUxFX0RFVklDRV9UQUJMRShvZiwgc2RoY2lfaXByb2Nfb2ZfbWF0Y2gpOwo+PiBXb3VsZCBpdCBi ZXR0ZXIgdG8gY29tcGlsZSB0aGlzIGluIGlmIENPTkZJR19BQ1BJIGlzIGRlZmluZWQgaW5zdGVh ZD8KPj4gI2lmIENPTkZJR19BQ1BJCj4gTGl0ZXJhbGx5IGNhbid0IHdpbi4KPgo+ICAgaHR0cHM6 Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC9DQUdiMnY2NldzNFdOUFpiT1lRdmlr S29vempfMldqelMtSnEtbzJWeFQ3Nz1rMHZPRHdAbWFpbC5nbWFpbC5jb20vCj4KPiBEYW1uZWQg aWYgd2UgZG8sIGRhbW5lZCBpZiB3ZSBkb24ndC4gOykKVGhpcyBpcyB2ZXJ5IG1pbm9yIGluIHRo aXMgb25lIGNoYW5nZSBoZXJlLCBidXQgaXQncyBqdXN0IG1vcmUgYmxvYXQgb2YgCnRoaW5ncyB0 aGF0IHJlYWxseSBzaG91bGQgYmUgY29tcGlsZWQgb3V0IGlmIHRoZXkncmUgbm90IHVzZWQuCkkg ZG9uJ3QgdW5kZXJzdGFuZCB3aHkgX19tYXliZV91bnVzZWQgd291bGQgYmUgcHJlZmVycmVkIGFw cHJvYWNoIC0gCnVubGVzcyBpdCBpcyBub3QgbGlua2VkIGluIHdoZW4gaXQgaXMgbm90IHVzZWQ/ Cj4KPj4+IC1zdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZGV2aWNlX2lkIHNkaGNpX2lwcm9jX2Fj cGlfaWRzW10gPSB7Cj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBhY3BpX2RldmljZV9pZCBfX21h eWJlX3VudXNlZCBzZGhjaV9pcHJvY19hY3BpX2lkc1tdID0gewo+Pj4gICAgCXsgLmlkID0gIkJS Q001ODcxIiwgLmRyaXZlcl9kYXRhID0gKGtlcm5lbF91bG9uZ190KSZpcHJvY19jeWdudXNfZGF0 YSB9LAo+Pj4gICAgCXsgLmlkID0gIkJSQ001ODcyIiwgLmRyaXZlcl9kYXRhID0gKGtlcm5lbF91 bG9uZ190KSZpcHJvY19kYXRhIH0sCj4+PiAgICAJeyAvKiBzZW50aW5lbCAqLyB9CgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=