From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Rafael J. Wysocki" To: Dave Chinner Cc: "Rafael J. Wysocki" , Jan Kara , "Luis R. Rodriguez" , Al Viro , bart.vanassche@wdc.com, ming.lei@redhat.com, Ted Ts'o , "Darrick J. Wong" , Jiri Kosina , Pavel Machek , Len Brown , linux-fsdevel@vger.kernel.org, Boris Ostrovsky , Juergen Gross , Todd Brandt , nborisov@suse.com, "Martin K. Petersen" , Oliver Neukum , oleksandr@natalenko.name, Oleg Antonyan , Yu Chen , Dan Williams , Linux PM , linux-block@vger.kernel.org, linux-xfs@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 07/11] xfs: remove not needed freezing calls Date: Fri, 01 Dec 2017 00:40:31 +0100 Message-ID: <28033585.qtnqnMzzMp@aspire.rjw.lan> In-Reply-To: <20171130233033.GO5858@dastard> References: <20171129232356.28296-1-mcgrof@kernel.org> <20171130233033.GO5858@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Friday, December 1, 2017 12:30:33 AM CET Dave Chinner wrote: > On Thu, Nov 30, 2017 at 09:32:53PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara wrote: > > > On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote: > > >> This removes superflous freezer calls as they are no longer needed > > >> as the VFS now performs filesystem freezing/thaw if the filesystem has > > >> support for it. > > >> > > >> The following Coccinelle rule was used as follows: > > >> > > >> spatch --sp-file fs-freeze-cleanup.cocci --in-place fs/$FS/ > > > > > > I think your rule misses WQ_FREEZABLE flag for workqueues? That would be > > > also good to get rid of... > > > > We need that one (or equivalent) for the runtime PM workqueue at least. > > I think Jan was talking about all the WQ_FREEZABLE flags in > filesystem workqueues (such as all the XFS wqs) that are no longer > necessary once filesystems are frozen appropriately. I see, thanks. That was unclear to me, sorry for the confusion. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 07/11] xfs: remove not needed freezing calls Date: Fri, 01 Dec 2017 00:40:31 +0100 Message-ID: <28033585.qtnqnMzzMp@aspire.rjw.lan> References: <20171129232356.28296-1-mcgrof@kernel.org> <20171130233033.GO5858@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from cloudserver094114.home.net.pl ([79.96.170.134]:51940 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbdK3XlC (ORCPT ); Thu, 30 Nov 2017 18:41:02 -0500 In-Reply-To: <20171130233033.GO5858@dastard> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Dave Chinner Cc: "Rafael J. Wysocki" , Jan Kara , "Luis R. Rodriguez" , Al Viro , bart.vanassche@wdc.com, ming.lei@redhat.com, Ted Ts'o , "Darrick J. Wong" , Jiri Kosina , Pavel Machek , Len Brown , linux-fsdevel@vger.kernel.org, Boris Ostrovsky , Juergen Gross , Todd Brandt , nborisov@suse.com, "Martin K. Petersen" , Oliver Neukum , oleksandr@natalenko.name, Oleg Antonyan , Yu Chen , Dan Williams , Linux PM On Friday, December 1, 2017 12:30:33 AM CET Dave Chinner wrote: > On Thu, Nov 30, 2017 at 09:32:53PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 30, 2017 at 5:21 PM, Jan Kara wrote: > > > On Wed 29-11-17 15:23:52, Luis R. Rodriguez wrote: > > >> This removes superflous freezer calls as they are no longer needed > > >> as the VFS now performs filesystem freezing/thaw if the filesystem has > > >> support for it. > > >> > > >> The following Coccinelle rule was used as follows: > > >> > > >> spatch --sp-file fs-freeze-cleanup.cocci --in-place fs/$FS/ > > > > > > I think your rule misses WQ_FREEZABLE flag for workqueues? That would be > > > also good to get rid of... > > > > We need that one (or equivalent) for the runtime PM workqueue at least. > > I think Jan was talking about all the WQ_FREEZABLE flags in > filesystem workqueues (such as all the XFS wqs) that are no longer > necessary once filesystems are frozen appropriately. I see, thanks. That was unclear to me, sorry for the confusion. Thanks, Rafael