From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48913C433E0 for ; Sun, 21 Feb 2021 14:39:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1846864EF2 for ; Sun, 21 Feb 2021 14:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230042AbhBUOjI (ORCPT ); Sun, 21 Feb 2021 09:39:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbhBUOjE (ORCPT ); Sun, 21 Feb 2021 09:39:04 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9143DC061574; Sun, 21 Feb 2021 06:38:24 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id BCB32425BE; Sun, 21 Feb 2021 14:38:18 +0000 (UTC) To: Marc Zyngier , Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> From: Hector Martin Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource Message-ID: <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> Date: Sun, 21 Feb 2021 23:38:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2021 04.17, Marc Zyngier wrote: > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: >>>>> Also fix a bug checking the return value, which should use IS_ERR(). >>>> >>>> No, no, no. We never, never combine fixing bugs with some rework. >>>> However devm_ioremap() returns NULL so where is the error? >>> >>> Sorry, this was a commit message mistake. The code is correct and so >>> is the >>> patch: just the NULL check is correct for the previous variant and >>> IS_ERR is >>> correct for devm_ioremap_resource. I confused myself while writing the >>> commit message after the fact. >>> >>>> Did you test your patches on existing platforms? If not, please mark all >>>> of them as RFT on next submission, so Greg does not pick them too fast. >>> >>> I unfortunately don't have any Exynos devices where I could test the >>> code (I >>> have a couple but no serial connections, and I have no idea if mailine >>> would >>> run on them). I'll mark v3 as RFT. >> >> If you have one of Odroid boards with Exynos, then you can nicely test >> Exynos. Others - depends, on board. >> Anyway I can test them for you. I just want to be sure that Greg waits >> for this testing. > > Worse case, QEMU has some Exynos4210 emulation that is usable. That's a good point; better than nothing, certainly. Does anyone have a known good example of booting an exynos kernel under qemu? I tried building a plain 5.11 arm exynos_defconfig and booting it, but without much luck: $ qemu-system-arm -kernel arch/arm/boot/zImage -append "console=ttySAC0,115200n8 debug" -dtb arch/arm/boot/dts/exynos4210-universal_c210.dtb -nographic -serial mon:stdio -M smdkc210 -smp 2 (I also tried without the -dtb option, in case qemu provides something usable) Of course I'll still mark v3 as RFT, I just thought I might as well try qemu. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B66BC433E0 for ; Sun, 21 Feb 2021 14:40:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DAFC64E86 for ; Sun, 21 Feb 2021 14:40:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DAFC64E86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A2NKYo9hFb6/vihN2mxzhaz1hK3M2rYH7uoK78Ohz9E=; b=pUczjGXKZm70WbA8VgJE/exrj QsZvo94jfStARk5ZTAlEuyVAgVz8Z4IDymcNXUphzm4IRZD5GdP91sIoFCpY95GCqgAWwjQv/ObU9 tWFf2TD1j8CqtrJTiogMyBYSKCF+vdlNtfxa5AnXISQhE4lDh5N3Mv8i47LTtHh6KXDV5zI7ExZUN X5chXproGokNKtvL+f2bCLmMQCz0tDx78gEkTvOXRTy51FQud3JF7+2DhVPfrmGzCqGpZxKQAmMcJ eK8nRu5m7+KHdmFB3ITzEISRHvZhbGwyzWHVEgjI+W8tUZ5d21+2MTFl3QDiQhegNIRwKGzYFmUbI nxYchz3Gw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDpsU-0004QT-Eq; Sun, 21 Feb 2021 14:38:30 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDpsS-0004Q2-3Z for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 14:38:29 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id BCB32425BE; Sun, 21 Feb 2021 14:38:18 +0000 (UTC) To: Marc Zyngier , Krzysztof Kozlowski References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> From: Hector Martin Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource Message-ID: <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> Date: Sun, 21 Feb 2021 23:38:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_093828_377435_36599408 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Arnd Bergmann , Tony Lindgren , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/02/2021 04.17, Marc Zyngier wrote: > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: >>>>> Also fix a bug checking the return value, which should use IS_ERR(). >>>> >>>> No, no, no. We never, never combine fixing bugs with some rework. >>>> However devm_ioremap() returns NULL so where is the error? >>> >>> Sorry, this was a commit message mistake. The code is correct and so >>> is the >>> patch: just the NULL check is correct for the previous variant and >>> IS_ERR is >>> correct for devm_ioremap_resource. I confused myself while writing the >>> commit message after the fact. >>> >>>> Did you test your patches on existing platforms? If not, please mark all >>>> of them as RFT on next submission, so Greg does not pick them too fast. >>> >>> I unfortunately don't have any Exynos devices where I could test the >>> code (I >>> have a couple but no serial connections, and I have no idea if mailine >>> would >>> run on them). I'll mark v3 as RFT. >> >> If you have one of Odroid boards with Exynos, then you can nicely test >> Exynos. Others - depends, on board. >> Anyway I can test them for you. I just want to be sure that Greg waits >> for this testing. > > Worse case, QEMU has some Exynos4210 emulation that is usable. That's a good point; better than nothing, certainly. Does anyone have a known good example of booting an exynos kernel under qemu? I tried building a plain 5.11 arm exynos_defconfig and booting it, but without much luck: $ qemu-system-arm -kernel arch/arm/boot/zImage -append "console=ttySAC0,115200n8 debug" -dtb arch/arm/boot/dts/exynos4210-universal_c210.dtb -nographic -serial mon:stdio -M smdkc210 -smp 2 (I also tried without the -dtb option, in case qemu provides something usable) Of course I'll still mark v3 as RFT, I just thought I might as well try qemu. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel