From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] rte_ring: add newline to error message
Date: Wed, 27 Mar 2019 12:21:25 +0100
Message-ID: <2813505.FGjIkkUpHa@xps>
References: <20190321230341.6576-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com, pablo.de.lara.guarch@intel.com,
 ramirose@gmail.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EC12C5F2A
 for <dev@dpdk.org>; Wed, 27 Mar 2019 12:21:29 +0100 (CET)
In-Reply-To: <20190321230341.6576-1-stephen@networkplumber.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/03/2019 00:03, Stephen Hemminger:
> Log message should end with newline.
> 
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> -		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
> +		RTE_LOG(ERR, RING,
> +			"Cannot free ring (not created with rte_ring_create()\n");

While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.