From: Joseph Reynolds <jrey@linux.ibm.com>
To: James Feist <james.feist@linux.intel.com>,
Bruce Mitchell <Bruce_Mitchell@phoenix.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: OpenBMC and https Vulnerable issue.
Date: Fri, 15 Nov 2019 16:45:23 -0600 [thread overview]
Message-ID: <2814674f-6cf8-5687-64ff-7b88a39d7d60@linux.ibm.com> (raw)
In-Reply-To: <50bba79d-db07-5ced-23e0-dfe3552b9687@linux.intel.com>
On 11/6/19 4:43 PM, James Feist wrote:
> On 11/6/19 2:38 PM, Bruce Mitchell wrote:
>>
>>
>>> -----Original Message-----
>>> From: openbmc [mailto:openbmc-
>>> bounces+bruce_mitchell=phoenix.com@lists.ozlabs.org] On Behalf Of Bruce
>>> Mitchell
>>> Sent: Wednesday, November 6, 2019 14:19
>>> To: James Feist; OpenBMC Maillist
>>> Subject: RE: OpenBMC and https Vulnerable issue.
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: openbmc [mailto:openbmc-
>>>> bounces+bruce_mitchell=phoenix.com@lists.ozlabs.org] On Behalf Of
>>>> James Feist
>>>> Sent: Wednesday, November 6, 2019 13:52
>>>> To: Bruce Mitchell; OpenBMC Maillist
>>>> Subject: Re: OpenBMC and https Vulnerable issue.
>>>>
>>>> On 11/6/19 11:31 AM, Bruce Mitchell wrote:
>>>>> From my investigations on TLS there seems to be 2 issues that
>>>>> could be
>>>> corrected with OpenBMC's https:
>>>>> 1 Secure Client-Initiated Renegotiation VULNERABLE (NOT
>>>>> ok), DoS
>>>> threat
>>>>
>>>> This CVE is disputed https://www.cvedetails.com/cve/CVE-2011-1473/ due
>>>> to CPU consumption issues that might make it easier to cause a DOS
>>>> (which is arguably already not that difficult on a BMC). That being
>>>> said
>>>> the fix is a 1 liner, so I implemented it and it seems to work, but I
>>>> need to see if there are any consequences.
>>>>
>>>> https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/26992
Thanks for looking at this. Sorry about my delayed response. The fix
looks good to me, and it has merged already anyway.
I don't see any negative consequences.
FWIW, to address the ongoing issue of what ciphers to support, an
OpenBMC network security considerations document was created to discuss
relevant standards and the OpenBMC implementation. Feel free to improve
it with additional information. It is here:
https://github.com/openbmc/docs/blob/master/security/network-security-considerations.md
- Joseph
>>>>
>>>>
>>>>
>>>>> 2 LUCKY13 (CVE-2013-0169), experimental potentially
>>>>> VULNERABLE,
>>>> uses cipher block chaining (CBC) ciphers with TLS
>>>>> and xc023 ECDHE-ECDSA-AES128-SHA256 ECDH 521 AES 128
>>>> TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256
>>>>
>>>> Based on this https://wiki.crashtest-security.com/prevent-ssl-lucky13,
>>>> we are using the recommended ciphers,
>>>>
>>> https://github.com/openbmc/bmcweb/blob/1f8c7b5d6a679a38b8226106031
>>>> 0b876079d0f8b/include/ssl_key_handler.hpp#L330.
>>>> And based on this comment from the maintainer of test ssl, no tool can
>>>> determine this externally, and it's just a warning:
>>>> https://github.com/drwetter/testssl.sh/issues/1011#issuecomment-
>>>> 372953654.
>>>> Do you have any suggestions on if there is anything to change for
>>>> this one?
>>>>
>>>> Thanks
>>>>
>>>> -James
>>>>
>>>
>>> Thanks James, I accept your assessment.
>>>
>>> -Bruce
>>>
>>
>> There are Mozilla Recommended configurations as well.
>> https://wiki.mozilla.org/Security/Server_Side_TLS#Recommended_configurations
>>
>>
>
> I believe that's what was originally copied based on the variable name
> in ssl_key_handler.hpp.
>
>> - Bruce
>>
>>>>
>>>>>
>>>>> Present standard of practice seems to be to not allow Secure Client-
>>>> Initiated Renegotiation and to not allow CBC ciphers.
>>>>>
>>>>> Is this your understanding as well?
>>>>>
>>>>> Thank you!
>>>>>
>>
prev parent reply other threads:[~2019-11-15 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 19:31 OpenBMC and https Vulnerable issue Bruce Mitchell
2019-11-06 21:52 ` James Feist
2019-11-06 22:18 ` Bruce Mitchell
2019-11-06 22:38 ` Bruce Mitchell
2019-11-06 22:43 ` James Feist
2019-11-15 22:45 ` Joseph Reynolds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2814674f-6cf8-5687-64ff-7b88a39d7d60@linux.ibm.com \
--to=jrey@linux.ibm.com \
--cc=Bruce_Mitchell@phoenix.com \
--cc=james.feist@linux.intel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.