From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BITCOIN_SPAM_02,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CC3C04AB4 for ; Tue, 14 May 2019 08:43:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5C2BE20818 for ; Tue, 14 May 2019 08:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kth.se header.i=@kth.se header.b="WyGid4FC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2BE20818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kth.se Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16C124F91; Tue, 14 May 2019 10:43:06 +0200 (CEST) Received: from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193]) by dpdk.org (Postfix) with ESMTP id 747C14D3A for ; Tue, 14 May 2019 10:43:05 +0200 (CEST) Received: from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-4.sys.kth.se (Postfix) with ESMTP id 278902BC2; Tue, 14 May 2019 10:43:05 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-4.sys.kth.se ([127.0.0.1]) by smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id X83AdYsMdYYm; Tue, 14 May 2019 10:43:04 +0200 (CEST) X-KTH-Auth: barbette [130.237.20.142] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1557823384; bh=TXSmp1famG+Cv6j8k12GOYHHUg4ToWH+nQZ8kAFcdVk=; h=Subject:From:To:Cc:References:Date:In-Reply-To; b=WyGid4FCiHWOOs9s871YisWW4/pZm9I/eFCGe+HfnqN+vQq6LycB2LgkMCUy5d4yt UicLZrO35KiSpkJimhNvhR17XPUqODRY92kNe4CJBScX4K1z9FFF3lTk7OnlyHgqNO LYR/kjeP+WFwzpbK1s4sXStoQCsQ0egbWj8F2t9U= X-KTH-mail-from: barbette@kth.se Received: from [130.237.20.142] (s2587.it.kth.se [130.237.20.142]) by smtp-4.sys.kth.se (Postfix) with ESMTPSA id AD5BA2938; Tue, 14 May 2019 10:43:03 +0200 (CEST) From: Tom Barbette To: Ali Alnubani Cc: "dev@dpdk.org" , Erez Scop , Olga Shern , Yongseok Koh , Shahaf Shuler , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" References: <20181119124645.11705-1-shahafs@mellanox.com> <20181119124645.11705-2-shahafs@mellanox.com> <19660f3d-6735-1689-4de6-a4f4fd173f52@kth.se> <7f5998c2-59d8-cefc-1aa5-28122b6c95a6@kth.se> Message-ID: <28165f2c-61f3-ac78-fe70-26c94e5dc24c@kth.se> Date: Tue, 14 May 2019 10:43:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <7f5998c2-59d8-cefc-1aa5-28122b6c95a6@kth.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sorry to revamp the old thread, but I found the conditions to create the bug. It does affect 19.05 with OFED 4.5, but is fixed in 4.6. It happens when I build with CONFIG_RTE_IBVERBS_LINK_STATIC=y. I forgot I enabled that one specifically... System: Ubuntu 18.04.2 LTS / 4.15.1-ubuntu gcc: Ubuntu 7.3.0-3ubuntu1 7.3.0 Steps: Install OFED 4.5 (4.6 is fixed) Checkout DPDK 19.05 (19.02 confirmed too) Enable MLX5 in config/common_base Enable CONFIG_RTE_IBVERBS_LINK_STATIC=y in config/common_base ./usertools/dpdk-setup.sh 37 (compile x86_64-native-linux-gcc) ... Error in linking either the test library or your own application. Workaround: Update to OFED 4.6, or do not use STATIC linking We could have disabled STATIC if the OFED is 4.5, I guess it's too late now... Sorry about that timing... Tom On 2019-03-20 18:13, Tom Barbette wrote: > I completely removed with apt remove --purge all packages installed by > the OFED, deleted with rm -rf /usr/include/infiniband/ and then > installed the OFED with --dpdk --upstream-libs (--force) and nothing > else and I get the compilation error (with 19.02). > > Indeed /usr/include/infiniband/mlx5_api.h defines : > mlx5_ib_uapi_flow_action_packet_reformat_type > > Which is also in 19.02's mlx5_glue.h: > enum  mlx5dv_flow_action_packet_reformat_type > > Is the MD5SUM of the (result of the install of the) last OFED that one? > 35cb5be56993977f1d9d912e263428c8  /usr/include/infiniband/mlx5_api.h > > If it is, then I would bet the problem is around the ifndef enclosing > the re-definition in mlx5_glue.hh : #ifndef HAVE_IBV_FLOW_DV_SUPPORT > > > Thanks, > > Tom > > > > On 2019-03-20 13:54, Ali Alnubani wrote: >> Hi Tom, >> >> I couldn't reproduce that. I'm on (master 239912fa7) and testing with: >> Ubuntu 18.04.2 LTS / 4.15.1-ubuntu >> gcc: Ubuntu 7.3.0-3ubuntu1 7.3.0 >> >> Can you make sure that OFED was installed successfully, and that it's >> not conflicting with rdma-core >> libraries already installed on your system (if there are)? >> Please try uninstalling OFED and rdma-core (if installed) and install >> OFED again with --force. >> >> Let me know if that works. >> >> Regards, >> Ali >> >>> -----Original Message----- >>> From: Tom Barbette >>> Sent: Tuesday, March 19, 2019 11:34 AM >>> To: Ali Alnubani >>> Cc: dev@dpdk.org; Erez Scop ; Olga Shern >>> ; Yongseok Koh ; Shahaf >>> Shuler ; john.mcnamara@intel.com; >>> marko.kovacevic@intel.com >>> Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED >>> version >>> >>> Hi Ali, >>> >>> Ubuntu 18.04 >>> Linux XXX 4.15.0-46-generic #49-Ubuntu SMP Wed Feb 6 09:33:07 UTC 2019 >>> x86_64 x86_64 x86_64 GNU/Linux >>> >>> MLNX_OFED_LINUX-4.5-1.0.1.0-ubuntu18.04-x86_64 >>> mft-4.11.0-103-x86_64-deb >>> >>>     Device Type:      ConnectX5 >>>     Part Number:      MCX556A-ECA_Ax >>>     Description:      ConnectX-5 VPI adapter card; EDR IB (100Gb/s) and >>> 100GbE; dual-port QSFP28; PCIe3.0 x16; tall bracket; ROHS R6 >>>     PSID:             MT_0000000008 >>>     PCI Device Name:  0000:73:00.0 >>>     Base MAC:         XXXX >>>     Versions:         Current        Available >>>        FW             16.24.1000     N/A >>>        PXE            3.5.0603       N/A >>>        UEFI           14.17.0011     N/A >>> >>> >>> gcc version 7.3.0 (Ubuntu 7.3.0-27ubuntu1~18.04) >>> >>> Thanks, >>> Tom >>> >>> On 2019-03-17 16:27, Ali Alnubani wrote: >>>> Hi Tom, >>>> >>>> Can you please provide more information? (OS/kernel versions, gcc >>>> version and full ofed version) >>>> >>>> Thanks, >>>> Ali >>>> >>>>> -----Original Message----- >>>>> From: dev On Behalf Of Tom Barbette >>>>> Sent: Thursday, March 14, 2019 1:20 PM >>>>> To: Shahaf Shuler ; john.mcnamara@intel.com; >>>>> marko.kovacevic@intel.com >>>>> Cc: dev@dpdk.org; Erez Scop ; Olga Shern >>>>> ; Yongseok Koh >>>>> Subject: Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported >>>>> OFED version >>>>> >>>>> A bit of an old thread, but I just tried to update the OFED 4.5 as >>>>> this doc patch suggests and DPDK (19.02 or master) do not compile >>> anymore for mlx5? >>>>> >>>>> Was the doc updated too soon or should I do something special to >>>>> clean >>>>> 4.4 and update 4.5? >>>>> >>>>> I did install the OFED with --upsteam-libs and --dpdk (4.4 works >>>>> fine). >>>>> >>>>> Error sample: >>>>> In file included from /usr/include/infiniband/mlx5dv.h:48:0, >>>>>                     from >>>>> /home/tom/dpdk-skylake/drivers/net/mlx5/mlx5_glue.c:21: >>>>> /home/tom/dpdk-skylake/drivers/net/mlx5/mlx5_glue.h:54:6: error: >>>>> nested redefinition of ‘enum >>> mlx5_ib_uapi_flow_action_packet_reformat_type’ >>>>>     enum mlx5dv_flow_action_packet_reformat_type { >>>>> packet_reformat_type = 0, }; >>>>>          ^ >>>>> /home/tom/dpdk-skylake/drivers/net/mlx5/mlx5_glue.h:54:6: error: >>>>> redeclaration of ‘enum >>> mlx5_ib_uapi_flow_action_packet_reformat_type’ >>>>> In file included from /usr/include/infiniband/mlx5_api.h:36:0, >>>>>                     from /usr/include/infiniband/mlx5dv.h:48, >>>>>                     from >>>>> /home/tom/dpdk-skylake/drivers/net/mlx5/mlx5_glue.c:21: >>>>> >>>>> >>>>> On 2018-11-19 13:46, Shahaf Shuler wrote: >>>>>> Signed-off-by: Shahaf Shuler >>>>>> --- >>>>>>     doc/guides/nics/mlx4.rst | 2 +- >>>>>>     doc/guides/nics/mlx5.rst | 2 +- >>>>>>     2 files changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst >>>>>> index >>>>>> 4a57c7a6aa..5326d916e1 100644 >>>>>> --- a/doc/guides/nics/mlx4.rst >>>>>> +++ b/doc/guides/nics/mlx4.rst >>>>>> @@ -213,7 +213,7 @@ Current RDMA core package and Linux kernel >>>>> (recommended) >>>>>>     Mellanox OFED as a fallback >>>>>>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> >>>>>> -- `Mellanox OFED`_ version: **4.3, 4.4**. >>>>>> +- `Mellanox OFED`_ version: **4.4, 4.5**. >>>>>>     - firmware version: **2.42.5000** and above. >>>>>> >>>>>>     .. _`Mellanox OFED`: >>>>>> >>>>> >>> http://www.mellanox.com/page/products_dyn?product_family=26&mtag=li >>>>> nux >>>>>> _sw_drivers diff --git a/doc/guides/nics/mlx5.rst >>>>>> b/doc/guides/nics/mlx5.rst index 3610e00862..b52f8af708 100644 >>>>>> --- a/doc/guides/nics/mlx5.rst >>>>>> +++ b/doc/guides/nics/mlx5.rst >>>>>> @@ -557,7 +557,7 @@ RMDA Core with Linux Kernel >>>>>>     Mellanox OFED >>>>>>     ^^^^^^^^^^^^^ >>>>>> >>>>>> -- Mellanox OFED version: **4.3, 4.4**. >>>>>> +- Mellanox OFED version: **4.4, 4.5**. >>>>>>     - firmware version: >>>>>> >>>>>>       - ConnectX-4: **12.21.1000** and above. >>>>>>