From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9C2C00A5A for ; Thu, 19 Jan 2023 08:05:10 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A65F410DD; Thu, 19 Jan 2023 09:05:09 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 968BB4068E for ; Thu, 19 Jan 2023 09:05:07 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 81076320094C; Thu, 19 Jan 2023 03:05:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 19 Jan 2023 03:05:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674115505; x= 1674201905; bh=DufJc2U/qNhT/9bhXZDqQd7wHBmM4KoAfuFecaZLJG0=; b=e AqNCmQ0mwjyi28Snc8KPdvuGWUqraTUwJuTL5u8Tvuhg5YfZoRxjo83XPr8UKv0m 2aCo/KRAHd8DQTZRo1lI9i9zR6PXgSHewvodVdyMMGqTR0lLorRY4eaAyE8gdO4k tqtTC4zynnuyfe00KFFAT++0cpdqme3ynMmvbSqDjHHEDY0xC6r/fQ+cTZth3bWH 6PG7BQBBXo7cIYl/XehI+e+Nmoe+r/+h9rjTrSD/WUWTIaAx1i+bJ+I+sMoCJT0i cYaSn7hp0KNFLiH5oDymBwlbZKz1vpxIrarp9R7kAGLBqs60M+rTCf+nxGr8fIjF Cl6UW/lzxl+MVWe4d14hQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674115505; x= 1674201905; bh=DufJc2U/qNhT/9bhXZDqQd7wHBmM4KoAfuFecaZLJG0=; b=N 59S5KpBE32jlB+oxdcyLcJdNdlC9B28yRtmfO3fTxqtezsO80Lf4TLx3dw8SUYfr ljAPsdxn/JRCxHUTN4wJwHiGuyPCdscAsfz2VXDYddrdeVYgBNtto+jHFciCejTM iwymqjyrpMdpamOKjfQpFawUPTksU00xn9K4aa5l/HEq+XtuKphbUHiGJ4EIXHR+ KjBTZOlfGOiyBpBbLdG3P2rSQuKOaaI8wnQ4e7XWqGqEdEvk2YLnjsDDnGtDAdJ9 9uBYJBINjNZWVttG7OgnOXHa/PObrRZUl14H5v2TL6sb3FI/Nosat+4GiKtd329k fpxAuHb7h0Ai8v8aWkIFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtledgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleff teehveduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Jan 2023 03:05:03 -0500 (EST) From: Thomas Monjalon To: Anoob Joseph Cc: Akhil Goyal , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Olivier Matz , "dev@dpdk.org" , Volodymyr Fialko , Hemant Agrawal , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Kiran Kumar Kokkilagadda , "dev@dpdk.org" Subject: Re: [EXT] Re: [PATCH 1/5] net: add PDCP header Date: Thu, 19 Jan 2023 09:05:01 +0100 Message-ID: <28193101.czjnFlTdjD@thomas> In-Reply-To: References: <20221027052140.155-1-anoobj@marvell.com> <2293639.0S5aU1g85B@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/01/2023 18:39, Anoob Joseph: > > 22/12/2022 10:25, Anoob Joseph: > > > --- /dev/null > > > +++ b/lib/net/rte_pdcp_hdr.h > > > @@ -0,0 +1,93 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(C) 2022 Marvell. > > > + */ > > > + > > > +#ifndef _RTE_PDCP_HDR_H_ > > > +#define _RTE_PDCP_HDR_H_ > > > > No need of extra underscores before and after. > > [Anoob] I was following the example quoted in https://doc.dpdk.org/guides/contributing/coding_style.html. Oh thanks for the reference, I will fix it. > Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same. Some other files don't have underscores. > Isn't it better to have a uniform coding style? No really I prefer no underscores, they are supposed to be used for standard libraries.