From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC147C433EF for ; Thu, 9 Dec 2021 01:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbhLICCt (ORCPT ); Wed, 8 Dec 2021 21:02:49 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]:29107 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbhLICCs (ORCPT ); Wed, 8 Dec 2021 21:02:48 -0500 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J8cZt1sw4z1DK2C; Thu, 9 Dec 2021 09:56:22 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 09:59:13 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 09:59:12 +0800 Subject: Re: [PATCH v16 10/11] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" From: "Leizhen (ThunderTown)" To: Rob Herring CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , "Will Deacon" , , "Frank Rowand" , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-11-thunder.leizhen@huawei.com> <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Message-ID: <281c8196-2a5c-28cf-346a-0ae2f7182f1b@huawei.com> Date: Thu, 9 Dec 2021 09:59:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/12/1 10:55, Leizhen (ThunderTown) wrote: >>> + } >>> >>> - memblock_cap_memory_range(cap_mem_addr, cap_mem_size); >>> + memblock_cap_memory_range(rgn[0].base, rgn[0].size); >>> + for (i = 1; i < MAX_USABLE_RANGES && rgn[i].size; i++) >> s/ &&/,/ Hi Rob: I want to keep "&&" unchanged, do you mind? I'm going to post an updated version tomorrow, hopefully the last. > Hi Rob: > > The comma operator may not be suitable for logical judgment. The logical judgment > before commas (,) is ignored. > > Here's my test： > > C code： > int main() > { > int i, j; > > printf("&&:\n"); > for (i = 0, j = 0; i < 2 && j < 3; i++, j++) > printf("i=%d, j=%d\n", i, j); > > printf("\ncomma:\n"); > for (i = 0, j = 0; i < 2, j < 3; i++, j++) //(i < 2） before comma is ignored > printf("i=%d, j=%d\n", i, j); > > return 0; > } > > Output： > &&: > i=0, j=0 > i=1, j=1 > > comma: > i=0, j=0 > i=1, j=1 > i=2, j=2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11B0FC433F5 for ; Thu, 9 Dec 2021 02:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:CC:To:From:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jRQ40PcRRL/0CNsWX5p2ZwGlVRr7QUSuDTP+8NOBScE=; b=AgrmEQfmFZJR9tfcEklWMuyHeE pBAS1qH7EP5WsIdB+tUR6Mu6RiM7yf3wyH5O+2di0OsxPqs/5DWX56oHQ1YF8oA5FIcxiOxrMbdrW GFSxC6aC27qGtkYMhvPx1j/kg1XpwwlTg1c8bIfka8WDbbJYHd6apAmhKsnbP4WXJjGOJeV+urC22 RrfqGT3QTf7TMM26d8PwIghIgXQyccxDVkmElrP+JpDoowFCC0E+2BibJW0QrkRQxA6rWOQgnXMZl VZHpxSHznxNmvzvi3L8nQUqeJmjQ/cEYiTwwc8amPz0VX2hVwVK2nMgkQGCOF/2ctFQReeFIm9X1/ 59esN1IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv8iP-00Ej49-BM; Thu, 09 Dec 2021 01:59:21 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv8iJ-00Ej1b-UN; Thu, 09 Dec 2021 01:59:17 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J8cZt1sw4z1DK2C; Thu, 9 Dec 2021 09:56:22 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 09:59:13 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 9 Dec 2021 09:59:12 +0800 Subject: Re: [PATCH v16 10/11] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" From: "Leizhen (ThunderTown)" To: Rob Herring CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , "Will Deacon" , , "Frank Rowand" , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-11-thunder.leizhen@huawei.com> <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Message-ID: <281c8196-2a5c-28cf-346a-0ae2f7182f1b@huawei.com> Date: Thu, 9 Dec 2021 09:59:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Content-Language: en-US X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_175916_176736_84496995 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIxLzEyLzEgMTA6NTUsIExlaXpoZW4gKFRodW5kZXJUb3duKSB3cm90ZToKPj4+ICsJ fQo+Pj4gIAo+Pj4gLQltZW1ibG9ja19jYXBfbWVtb3J5X3JhbmdlKGNhcF9tZW1fYWRkciwgY2Fw X21lbV9zaXplKTsKPj4+ICsJbWVtYmxvY2tfY2FwX21lbW9yeV9yYW5nZShyZ25bMF0uYmFzZSwg cmduWzBdLnNpemUpOwo+Pj4gKwlmb3IgKGkgPSAxOyBpIDwgTUFYX1VTQUJMRV9SQU5HRVMgJiYg cmduW2ldLnNpemU7IGkrKykKPj4gcy8gJiYvLC8KCkhpIFJvYjoKICBJIHdhbnQgdG8ga2VlcCAi JiYiIHVuY2hhbmdlZCwgZG8geW91IG1pbmQ/IEknbSBnb2luZyB0byBwb3N0IGFuCnVwZGF0ZWQg dmVyc2lvbiB0b21vcnJvdywgaG9wZWZ1bGx5IHRoZSBsYXN0LgoKPiBIaSBSb2I6Cj4gCj4gVGhl IGNvbW1hIG9wZXJhdG9yIG1heSBub3QgYmUgc3VpdGFibGUgZm9yIGxvZ2ljYWwganVkZ21lbnQu IFRoZSBsb2dpY2FsIGp1ZGdtZW50Cj4gYmVmb3JlIGNvbW1hcyAoLCkgaXMgaWdub3JlZC4KPiAK PiBIZXJlJ3MgbXkgdGVzdO+8mgo+IAo+IEMgY29kZe+8mgo+IGludCBtYWluKCkKPiB7Cj4gICAg ICAgICBpbnQgaSwgajsKPiAKPiAgICAgICAgIHByaW50ZigiJiY6XG4iKTsKPiAgICAgICAgIGZv ciAoaSA9IDAsIGogPSAwOyBpIDwgMiAmJiBqIDwgMzsgaSsrLCBqKyspCj4gICAgICAgICAgICAg ICAgIHByaW50ZigiaT0lZCwgaj0lZFxuIiwgaSwgaik7Cj4gCj4gICAgICAgICBwcmludGYoIlxu Y29tbWE6XG4iKTsKPiAgICAgICAgIGZvciAoaSA9IDAsIGogPSAwOyBpIDwgMiwgaiA8IDM7IGkr KywgaisrKQkvLyhpIDwgMu+8iSBiZWZvcmUgY29tbWEgaXMgaWdub3JlZAo+ICAgICAgICAgICAg ICAgICBwcmludGYoImk9JWQsIGo9JWRcbiIsIGksIGopOwo+IAo+ICAgICAgICAgcmV0dXJuIDA7 Cj4gfQo+IAo+IE91dHB1dO+8mgo+ICYmOgo+IGk9MCwgaj0wCj4gaT0xLCBqPTEKPiAKPiBjb21t YToKPiBpPTAsIGo9MAo+IGk9MSwgaj0xCj4gaT0yLCBqPTIKPiAKPiAKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH v16 10/11] of: fdt: Add memory for devices by DT property "linux,usable-memory-range" From: "Leizhen (ThunderTown)" References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-11-thunder.leizhen@huawei.com> <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Message-ID: <281c8196-2a5c-28cf-346a-0ae2f7182f1b@huawei.com> Date: Thu, 9 Dec 2021 09:59:11 +0800 MIME-Version: 1.0 In-Reply-To: <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Rob Herring Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou CgpPbiAyMDIxLzEyLzEgMTA6NTUsIExlaXpoZW4gKFRodW5kZXJUb3duKSB3cm90ZToKPj4+ICsJ fQo+Pj4gIAo+Pj4gLQltZW1ibG9ja19jYXBfbWVtb3J5X3JhbmdlKGNhcF9tZW1fYWRkciwgY2Fw X21lbV9zaXplKTsKPj4+ICsJbWVtYmxvY2tfY2FwX21lbW9yeV9yYW5nZShyZ25bMF0uYmFzZSwg cmduWzBdLnNpemUpOwo+Pj4gKwlmb3IgKGkgPSAxOyBpIDwgTUFYX1VTQUJMRV9SQU5HRVMgJiYg cmduW2ldLnNpemU7IGkrKykKPj4gcy8gJiYvLC8KCkhpIFJvYjoKICBJIHdhbnQgdG8ga2VlcCAi JiYiIHVuY2hhbmdlZCwgZG8geW91IG1pbmQ/IEknbSBnb2luZyB0byBwb3N0IGFuCnVwZGF0ZWQg dmVyc2lvbiB0b21vcnJvdywgaG9wZWZ1bGx5IHRoZSBsYXN0LgoKPiBIaSBSb2I6Cj4gCj4gVGhl IGNvbW1hIG9wZXJhdG9yIG1heSBub3QgYmUgc3VpdGFibGUgZm9yIGxvZ2ljYWwganVkZ21lbnQu IFRoZSBsb2dpY2FsIGp1ZGdtZW50Cj4gYmVmb3JlIGNvbW1hcyAoLCkgaXMgaWdub3JlZC4KPiAK PiBIZXJlJ3MgbXkgdGVzdO+8mgo+IAo+IEMgY29kZe+8mgo+IGludCBtYWluKCkKPiB7Cj4gICAg ICAgICBpbnQgaSwgajsKPiAKPiAgICAgICAgIHByaW50ZigiJiY6XG4iKTsKPiAgICAgICAgIGZv ciAoaSA9IDAsIGogPSAwOyBpIDwgMiAmJiBqIDwgMzsgaSsrLCBqKyspCj4gICAgICAgICAgICAg ICAgIHByaW50ZigiaT0lZCwgaj0lZFxuIiwgaSwgaik7Cj4gCj4gICAgICAgICBwcmludGYoIlxu Y29tbWE6XG4iKTsKPiAgICAgICAgIGZvciAoaSA9IDAsIGogPSAwOyBpIDwgMiwgaiA8IDM7IGkr KywgaisrKQkvLyhpIDwgMu+8iSBiZWZvcmUgY29tbWEgaXMgaWdub3JlZAo+ICAgICAgICAgICAg ICAgICBwcmludGYoImk9JWQsIGo9JWRcbiIsIGksIGopOwo+IAo+ICAgICAgICAgcmV0dXJuIDA7 Cj4gfQo+IAo+IE91dHB1dO+8mgo+ICYmOgo+IGk9MCwgaj0wCj4gaT0xLCBqPTEKPiAKPiBjb21t YToKPiBpPTAsIGo9MAo+IGk9MSwgaj0xCj4gaT0yLCBqPTIKPiAKPiAKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhl Y0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8va2V4ZWMK