From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEED6C54FD0 for ; Wed, 25 Mar 2020 13:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A73ED2078A for ; Wed, 25 Mar 2020 13:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727686AbgCYNnq (ORCPT ); Wed, 25 Mar 2020 09:43:46 -0400 Received: from foss.arm.com ([217.140.110.172]:48708 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727383AbgCYNnq (ORCPT ); Wed, 25 Mar 2020 09:43:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF01531B; Wed, 25 Mar 2020 06:43:45 -0700 (PDT) Received: from [10.37.9.12] (unknown [10.37.9.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C24C03F71F; Wed, 25 Mar 2020 06:43:44 -0700 (PDT) Subject: Re: [PATCH 2/3] kselftest: Extend vDSO selftest To: Andy Lutomirski Cc: LKML , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Thomas Gleixner References: <20200324145120.42194-1-vincenzo.frascino@arm.com> <20200324145120.42194-3-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <281cc0c3-dbe3-2c39-3964-ce1147af9933@arm.com> Date: Wed, 25 Mar 2020 13:44:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 3/24/20 5:22 PM, Andy Lutomirski wrote: > On Tue, Mar 24, 2020 at 7:51 AM Vincenzo Frascino > wrote: >> >> The current version of the multiarch vDSO selftest verifies only >> gettimeofday. >> >> Extend the vDSO selftest to the other library functions: >> - time >> - clock_getres >> - clock_gettime >> >> The extension has been used to verify the unified vdso library on the >> supported architectures. > > The code in tools/testing/selftests/x86/test_vdso.c actually checks > that the times returned by the vDSO are correct. Perhaps that code > should be copied or moved here? > Good point. I was not aware of such a test. I will definitely move it here and make sure it works for non x86 platforms as well in the next iteration of this series. -- Regards, Vincenzo