From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010EAC76195 for ; Thu, 18 Jul 2019 09:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4DFE2173E for ; Thu, 18 Jul 2019 09:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389453AbfGRJhX (ORCPT ); Thu, 18 Jul 2019 05:37:23 -0400 Received: from foss.arm.com ([217.140.110.172]:56222 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726665AbfGRJhX (ORCPT ); Thu, 18 Jul 2019 05:37:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A992D28; Thu, 18 Jul 2019 02:37:22 -0700 (PDT) Received: from dawn-kernel.cambridge.arm.com (unknown [10.1.197.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89B973F71A; Thu, 18 Jul 2019 02:37:20 -0700 (PDT) Subject: Re: [PATCHv8 2/5] arm64: dts: qcom: msm8998: Add Coresight support To: saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, david.brown@linaro.org, mark.rutland@arm.com Cc: rnayak@codeaurora.org, vivek.gautam@codeaurora.org, sibis@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, marc.w.gonzalez@free.fr References: <3b192063-f31f-b861-d913-61d737cecc57@arm.com> <4854b0f7-6a81-bc87-3e63-d2b7c68a44f6@codeaurora.org> From: Suzuki K Poulose Message-ID: <281e3548-af53-f9a7-b9e4-813b448ab078@arm.com> Date: Thu, 18 Jul 2019 10:37:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <4854b0f7-6a81-bc87-3e63-d2b7c68a44f6@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18/07/2019 10:14, Sai Prakash Ranjan wrote: > Hi Suzuki, > > On 7/18/2019 1:58 PM, Suzuki K Poulose wrote: >> Hi Sai, >> >> >>         etr@6048000 { >>> +            compatible = "arm,coresight-tmc", "arm,primecell"; >>> +            reg = <0x06048000 0x1000>; >>> + >>> +            clocks = <&rpmcc RPM_SMD_QDSS_CLK>, <&rpmcc >>> RPM_SMD_QDSS_A_CLK>; >>> +            clock-names = "apb_pclk", "atclk"; >>> +            arm,scatter-gather; >> >> Please could you confirm that you have tested the scatter-gather mode >> with ETR ? Either via perf/sysfs. Please could you share your results ? >> Unless verified >> this is going to be fatal for the system. >> >> Similarly for other platforms. >> > > Yes I have tested with scatter-gather mode with ETR on all platforms > which I have posted via sysfs(not perf) before on previous versions of > this patch series and no issues were found. And I suppose this was > discussed in v2 of this patch series [1]. Using the sysfs doesn't guarantee that the ETR actually uses SG mode, unless the buffer size selected is > 1M, which is why I am more interested in the perf usage. Alternatively you may configure a larger buffer size (say, 8MB) via: echo 0x800000 > /sys/bus/coresight/.../tmc_etr0/buffer_size > > As said in one of the series initially [1], QCOM msm downstream kernels > have been using scatter gather mode and we haven't seen any fatal issues. > > [1] https://patchwork.kernel.org/patch/10769535/ I haven't seen any test results there either. Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895BFC76195 for ; Thu, 18 Jul 2019 09:37:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D1FA20693 for ; Thu, 18 Jul 2019 09:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dIRT7X92" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D1FA20693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2kCXnWwVrTUjL4MpD/fn9m9MA7JioNQg7E3b4m/JTTo=; b=dIRT7X92rytuVigVzOI4s62LL tfxBkj6DvBoSTFaaVpRxVLHTn5vbP/ahImXsYxHluYZvbcC53nn5U+uzW8IPejtuGU/fB0fZ1CHAJ 30aKDDpYXvQLmY/K+vfJ8RHQ4psMd7NDm8dIFUu8kWxYs1/cSV94EXWWdRyvc65qwPV6N90+XkXbk W2YmRIBNsi3vTAiCbDnoWW6/e31eUQx7lBUTtfpAtk4E782ClrRYnfVUMTxD0TBpOThpp5jDiEMJC Ei43jawAiFclsjU7ST9aOYlWVTs60oRPhrxYdsj4cCqIzbSHm72wh1qMKyV4fU16uKjJA12jzJvGz auNamjExg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho2qu-0006Lg-9K; Thu, 18 Jul 2019 09:37:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho2qq-0006Ku-HS for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 09:37:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A992D28; Thu, 18 Jul 2019 02:37:22 -0700 (PDT) Received: from dawn-kernel.cambridge.arm.com (unknown [10.1.197.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89B973F71A; Thu, 18 Jul 2019 02:37:20 -0700 (PDT) Subject: Re: [PATCHv8 2/5] arm64: dts: qcom: msm8998: Add Coresight support To: saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, david.brown@linaro.org, mark.rutland@arm.com References: <3b192063-f31f-b861-d913-61d737cecc57@arm.com> <4854b0f7-6a81-bc87-3e63-d2b7c68a44f6@codeaurora.org> From: Suzuki K Poulose Message-ID: <281e3548-af53-f9a7-b9e4-813b448ab078@arm.com> Date: Thu, 18 Jul 2019 10:37:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <4854b0f7-6a81-bc87-3e63-d2b7c68a44f6@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_023724_625516_BD023503 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rnayak@codeaurora.org, marc.w.gonzalez@free.fr, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, sibis@codeaurora.org, vivek.gautam@codeaurora.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxOC8wNy8yMDE5IDEwOjE0LCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6Cj4gSGkgU3V6 dWtpLAo+IAo+IE9uIDcvMTgvMjAxOSAxOjU4IFBNLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+ PiBIaSBTYWksCj4+Cj4+Cj4+ICAgwqDCoMKgwqDCoMKgwqAgZXRyQDYwNDgwMDAgewo+Pj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJhcm0sY29yZXNpZ2h0LXRtYyIsICJh cm0scHJpbWVjZWxsIjsKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJlZyA9IDwweDA2MDQ4 MDAwIDB4MTAwMD47Cj4+PiArCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjbG9ja3MgPSA8 JnJwbWNjIFJQTV9TTURfUURTU19DTEs+LCA8JnJwbWNjCj4+PiBSUE1fU01EX1FEU1NfQV9DTEs+ Owo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2xvY2stbmFtZXMgPSAiYXBiX3BjbGsiLCAi YXRjbGsiOwo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYXJtLHNjYXR0ZXItZ2F0aGVyOwo+ Pgo+PiBQbGVhc2UgY291bGQgeW91IGNvbmZpcm0gdGhhdCB5b3UgaGF2ZSB0ZXN0ZWQgdGhlIHNj YXR0ZXItZ2F0aGVyIG1vZGUKPj4gd2l0aCBFVFIgPyBFaXRoZXIgdmlhIHBlcmYvc3lzZnMuIFBs ZWFzZSBjb3VsZCB5b3Ugc2hhcmUgeW91ciByZXN1bHRzID8KPj4gVW5sZXNzIHZlcmlmaWVkCj4+ IHRoaXMgaXMgZ29pbmcgdG8gYmUgZmF0YWwgZm9yIHRoZSBzeXN0ZW0uCj4+Cj4+IFNpbWlsYXJs eSBmb3Igb3RoZXIgcGxhdGZvcm1zLgo+Pgo+IAo+IFllcyBJIGhhdmUgdGVzdGVkIHdpdGggc2Nh dHRlci1nYXRoZXIgbW9kZSB3aXRoIEVUUiBvbiBhbGwgcGxhdGZvcm1zCj4gd2hpY2ggSSBoYXZl IHBvc3RlZCB2aWEgc3lzZnMobm90IHBlcmYpIGJlZm9yZSBvbiBwcmV2aW91cyB2ZXJzaW9ucyBv Zgo+IHRoaXMgcGF0Y2ggc2VyaWVzIGFuZCBubyBpc3N1ZXMgd2VyZSBmb3VuZC4gQW5kIEkgc3Vw cG9zZSB0aGlzIHdhcwo+IGRpc2N1c3NlZCBpbiB2MiBvZiB0aGlzIHBhdGNoIHNlcmllcyBbMV0u CgpVc2luZyB0aGUgc3lzZnMgZG9lc24ndCBndWFyYW50ZWUgdGhhdCB0aGUgRVRSIGFjdHVhbGx5 IHVzZXMgU0cgbW9kZSwgdW5sZXNzCnRoZSBidWZmZXIgc2l6ZSBzZWxlY3RlZCBpcyA+IDFNLCB3 aGljaCBpcyB3aHkgSSBhbSBtb3JlIGludGVyZXN0ZWQgaW4gdGhlCnBlcmYgdXNhZ2UuIEFsdGVy bmF0aXZlbHkgeW91IG1heSBjb25maWd1cmUgYSBsYXJnZXIgYnVmZmVyIHNpemUgKHNheSwgOE1C KSB2aWE6CgplY2hvIDB4ODAwMDAwID4gL3N5cy9idXMvY29yZXNpZ2h0Ly4uLi90bWNfZXRyMC9i dWZmZXJfc2l6ZQoKCj4gCj4gQXMgc2FpZCBpbiBvbmUgb2YgdGhlIHNlcmllcyBpbml0aWFsbHkg WzFdLCBRQ09NIG1zbSBkb3duc3RyZWFtIGtlcm5lbHMKPiBoYXZlIGJlZW4gdXNpbmcgc2NhdHRl ciBnYXRoZXIgbW9kZSBhbmQgd2UgaGF2ZW4ndCBzZWVuIGFueSBmYXRhbCBpc3N1ZXMuCj4gCj4g WzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTA3Njk1MzUvCgpJIGhhdmVu J3Qgc2VlbiBhbnkgdGVzdCByZXN1bHRzIHRoZXJlIGVpdGhlci4KCkNoZWVycwpTdXp1a2kKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK