All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH] board: xilinx/zynqmp: Remove 1-second delay at boot
Date: Fri, 29 May 2020 13:34:59 +0200	[thread overview]
Message-ID: <282075e1-fbcd-fd19-7dbd-fb78fb832efb@xilinx.com> (raw)
In-Reply-To: <20200526082026.18898-1-mike.looijmans@topic.nl>

On 26. 05. 20 10:20, Mike Looijmans wrote:
> SPL boot is slow on the ZynqMP because of this delay. The initialization done
> in psu_init no longer requires an external delay, so this can be removed to
> speed up the SPL boot flow considerably.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  board/xilinx/zynqmp/zynqmp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
> index cb72914adb..d00235f236 100644
> --- a/board/xilinx/zynqmp/zynqmp.c
> +++ b/board/xilinx/zynqmp/zynqmp.c
> @@ -32,7 +32,6 @@
>  #include <zynqmp_firmware.h>
>  #include <g_dnl.h>
>  #include <linux/bitops.h>
> -#include <linux/delay.h>
>  #include <linux/sizes.h>
>  #include "../common/board.h"
>  
> @@ -334,9 +333,6 @@ int board_early_init_f(void)
>  	ret = psu_init();
>  	if (ret)
>  		return ret;
> -
> -	/* Delay is required for clocks to be propagated */
> -	udelay(1000000);
>  #endif
>  
>  #ifdef CONFIG_DEBUG_UART
> 

Mike reported me that removing this 1s is causing issue in SD boot mode
that's why I am not applying this patch till we root caused it.

Thanks,
Michal

      reply	other threads:[~2020-05-29 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  8:20 [PATCH] board: xilinx/zynqmp: Remove 1-second delay at boot Mike Looijmans
2020-05-29 11:34 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=282075e1-fbcd-fd19-7dbd-fb78fb832efb@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.