From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B9FC433F5 for ; Thu, 9 Sep 2021 16:18:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6FE61179 for ; Thu, 9 Sep 2021 16:18:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B6FE61179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14C376E8AA; Thu, 9 Sep 2021 16:18:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 120196E8AA for ; Thu, 9 Sep 2021 16:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631204288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DFYwJKNou+RmjsI/G6x/CnVjB7CdXNyU2huXcy7mF1g=; b=RKXvmoZsByxn+qAgTu+mXd6W4PFsgsNso8OVbyPUisn4fpga4pfWQoXutmfAOsEIMnik/N qo9d4A2xgZcSHR+BHzMZI3UPlSHweI/OCyUcr2/Gq3t2eGKuvDdjNiAfJCBzqzwwDhHu4W w24c8DCIvUVpeVXv5SlYUCCJjRLvh3E= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-ZSQq0wXQMGmvb9Rp-3dKHA-1; Thu, 09 Sep 2021 12:18:07 -0400 X-MC-Unique: ZSQq0wXQMGmvb9Rp-3dKHA-1 Received: by mail-qt1-f198.google.com with SMTP id l22-20020a05622a175600b0029d63a970f6so5310627qtk.23 for ; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=DFYwJKNou+RmjsI/G6x/CnVjB7CdXNyU2huXcy7mF1g=; b=66k05ukhlCdSx3hx0MaFhc0tUUXvK5dxCy2blPL2Cfpot8OslVmrcjJY63tTPV9KBZ 1DT3eK/ph8avgrKYSjI8S779okikMtrjaISBAiJDhCKCEMzPUZ5svT1/ujmgF3YCIdFM TIUxiFS+vjrtxhCneyJmkuy5Gr+FbuPyxi1zCf6VGsuncLs/Acet3T7hPceV8kRQHMV2 OWFcCQADThA0yoPJeZhUx9mXTclCRqGYQK8p3XZvd5c1hJigDIN6JIt0ZlkMK2mczNvm BbmhSRGrDVsErZtYDAj3lUU+BeeVQwMfTPv5G+bmnKWLB+WzLEOgHttlxoBQ6in2R8XX dGXw== X-Gm-Message-State: AOAM531cJIredqcHMqFnIqKfU7YCgfbIkg15t8Lbx3vtKr6sC+efjR6g tWkVP/qpjsxi8s7Zx/8Rxu9fpOJyTOzktztDqpDBsXbqTrZfhMrvdjkcwd4LX+HTiOePcPMKyRl lP6QAtlT+Zb5MLCVxNjA5DI1ObRJd X-Received: by 2002:a05:620a:24c1:: with SMTP id m1mr3611778qkn.309.1631204286642; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwazGn7UBmgC1TBQ165kEqC4DoOcnYeiKcKpObQmVijagBpm/wDcSQc/gk5CEYx6NniMCZykQ== X-Received: by 2002:a05:620a:24c1:: with SMTP id m1mr3611752qkn.309.1631204286413; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) Received: from [192.168.8.206] (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id o23sm1619422qkk.40.2021.09.09.09.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 09:18:06 -0700 (PDT) Message-ID: <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> From: Lyude Paul To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com, manasi.d.navare@intel.com Date: Thu, 09 Sep 2021 12:18:05 -0400 In-Reply-To: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> References: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> Organization: Red Hat User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3 02/13] drm/dp: use more of the extended receiver cap X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" I thought I remembered an issue with this but looked up the previous emails, and it looks like that this change actually should be safe! Signed-off-by: Lyude Paul On Thu, 2021-09-09 at 15:51 +0300, Jani Nikula wrote: > Extend the use of extended receiver cap at 0x2200 to cover > MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides > the DP 2.0 128b/132b channel encoding cap. > > v2: Extend to DP_RECEIVER_CAP_SIZE (Ville) > > Cc: Lyude Paul > Cc: dri-devel@lists.freedesktop.org > Cc: Manasi Navare > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- >  drivers/gpu/drm/drm_dp_helper.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > b/drivers/gpu/drm/drm_dp_helper.c > index 9b2a2961fca8..2e74b02ed96b 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -608,7 +608,7 @@ static u8 drm_dp_downstream_port_count(const u8 > dpcd[DP_RECEIVER_CAP_SIZE]) >  static int drm_dp_read_extended_dpcd_caps(struct drm_dp_aux *aux, >                                           u8 dpcd[DP_RECEIVER_CAP_SIZE]) >  { > -       u8 dpcd_ext[6]; > +       u8 dpcd_ext[DP_RECEIVER_CAP_SIZE]; >         int ret; >   >         /* -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56830C433EF for ; Thu, 9 Sep 2021 16:18:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23FC461179 for ; Thu, 9 Sep 2021 16:18:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 23FC461179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FCC16E8B5; Thu, 9 Sep 2021 16:18:11 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1F9F6E8AF for ; Thu, 9 Sep 2021 16:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631204290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DFYwJKNou+RmjsI/G6x/CnVjB7CdXNyU2huXcy7mF1g=; b=hZWmemXUxqpD3fCEXgUIvXoyYCsbwJjm9aXcoXqVwsbZlXW/SwHxDoNKf4TRb20zfCwHW5 1uPp1cKSffjckZpS/DgDNctBvwiRm/MRiGJ6N9I3Gb10SnGmtRui/VsNa8+dGYHHvy+xcw oosbhfs6+NdWrsZlN/PUtZOeJHWq5bA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-SqkP-e61NCGdHOTEl761Sw-1; Thu, 09 Sep 2021 12:18:07 -0400 X-MC-Unique: SqkP-e61NCGdHOTEl761Sw-1 Received: by mail-qv1-f71.google.com with SMTP id r18-20020a056214069200b0037a291a6081so7627329qvz.18 for ; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=DFYwJKNou+RmjsI/G6x/CnVjB7CdXNyU2huXcy7mF1g=; b=HdeOsAyljdEOG4mxfQsbfaz9LnEu2OGRur0HHjsfjYLeqgdqrp2XtYfKfaX01bf8rg HBzDGFSgnO6sFIzmeLwO5IIkhpUchxdtdZ0CVMOUdGi1tcmDiUCLwiinKCNQ3K/Ly3Wn YV3bIxh0+WlTKfwK3Q7qNQQvdtxgh0TlUfBrnmrXhHrlMlLcg8TDp1tyrkDgWH81z+yV LGZkZFOyplQPhEVccKl2P+02n4i6exXnajZKieDX+amYJ7u/BsoabVHqYDM8z4fFzr3V I0z4fuOiigWhY2KEfyicZ404uMOh4P6VraOX+2Arc1SyjZp0vLIwRtW5djuO5m8VNCyR QNIg== X-Gm-Message-State: AOAM533h8rBvu350810yS8fqQ1FI+3nQdG0el7k90/f3ir5owPcCG3PJ D/+Mq65fRm5PPEdz9yN6g6kK6cIWhsbd1QneSFUTQCIHvj6dUYe3h/ZAoRPcc2pOWflxpFfnsB6 LQdEQlVXj0cOMftCUI6op5rO0tI6c X-Received: by 2002:a05:620a:24c1:: with SMTP id m1mr3611769qkn.309.1631204286579; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwazGn7UBmgC1TBQ165kEqC4DoOcnYeiKcKpObQmVijagBpm/wDcSQc/gk5CEYx6NniMCZykQ== X-Received: by 2002:a05:620a:24c1:: with SMTP id m1mr3611752qkn.309.1631204286413; Thu, 09 Sep 2021 09:18:06 -0700 (PDT) Received: from [192.168.8.206] (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id o23sm1619422qkk.40.2021.09.09.09.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 09:18:06 -0700 (PDT) Message-ID: <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> Subject: Re: [PATCH v3 02/13] drm/dp: use more of the extended receiver cap From: Lyude Paul To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com, manasi.d.navare@intel.com Date: Thu, 09 Sep 2021 12:18:05 -0400 In-Reply-To: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> References: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> Organization: Red Hat User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" I thought I remembered an issue with this but looked up the previous emails, and it looks like that this change actually should be safe! Signed-off-by: Lyude Paul On Thu, 2021-09-09 at 15:51 +0300, Jani Nikula wrote: > Extend the use of extended receiver cap at 0x2200 to cover > MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides > the DP 2.0 128b/132b channel encoding cap. > > v2: Extend to DP_RECEIVER_CAP_SIZE (Ville) > > Cc: Lyude Paul > Cc: dri-devel@lists.freedesktop.org > Cc: Manasi Navare > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- >  drivers/gpu/drm/drm_dp_helper.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > b/drivers/gpu/drm/drm_dp_helper.c > index 9b2a2961fca8..2e74b02ed96b 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -608,7 +608,7 @@ static u8 drm_dp_downstream_port_count(const u8 > dpcd[DP_RECEIVER_CAP_SIZE]) >  static int drm_dp_read_extended_dpcd_caps(struct drm_dp_aux *aux, >                                           u8 dpcd[DP_RECEIVER_CAP_SIZE]) >  { > -       u8 dpcd_ext[6]; > +       u8 dpcd_ext[DP_RECEIVER_CAP_SIZE]; >         int ret; >   >         /* -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat