Re: [PATCH] testimage: regenerate rootfs before testing

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 23 April 2015 09:39:08 Cristian Iorga wrote:
> While starting a test with testimage, changes
> of the image under test don't trigger a rebuild,
> so fix that.
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
>  meta/classes/testimage.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
> index dc163c7..ce7f5c1 100644
> --- a/meta/classes/testimage.bbclass
> +++ b/meta/classes/testimage.bbclass
> @@ -53,7 +53,7 @@ TESTIMAGELOCK_qemuall = ""
>  python do_testimage() {
>      testimage_main(d)
>  }
> -addtask testimage
> +addtask testimage after do_rootfs
>  do_testimage[nostamp] = "1"
>  do_testimage[depends] += "${TESTIMAGEDEPENDS}"
>  do_testimage[lockfiles] += "${TESTIMAGELOCK}"

I can't remember for certain, but I suspect the lack of this dependency was 
intentional, so that you could e.g. copy in an image built elsewhere and run 
tests on it. Maybe we can take the decision we don't need that, but it should 
be a conscious decision.

On the other hand, testimage-auto.bbclass does set up this dependency, 
although it also adds a dependency from do_build on do_testimage as well. 
There is a bug open to integrate testimage-auto.bbclass with testimage.bbclass 
as well (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6155).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre