From: Florian Fainelli <f.fainelli@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next v1 1/4] net: phy: broadcom: Add PTP support for some Broadcom PHYs.
Date: Tue, 26 Apr 2022 11:02:04 -0700 [thread overview]
Message-ID: <2823186c-d495-bd9b-87be-5e98a980ca04@gmail.com> (raw)
In-Reply-To: <20220426025349.GB22745@hoboy.vegasvil.org>
On 4/25/22 19:53, Richard Cochran wrote:
> On Mon, Apr 25, 2022 at 04:55:40PM -0700, Jonathan Lemon wrote:
>
>> We could just have a chip-specific version of this function. The
>> recovered timestamp is passed back in a structure, so the rest of the
>> code would be unchanged.
>
> Yeah, but it means that I'll have to check each and every bit of every
> register to see what other random changes are there...
>
>> Jonathan (no, not volunteering to do this...)
>
> For now, just get your chip merged, and then the next chip's driver
> will refactor/reuse as needed.
Agreed, if we want to support Gen1 PHYs we can easily do that with
adding a table of register offsets per family.
--
Florian
next prev parent reply other threads:[~2022-04-26 18:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 2:23 [PATCH net-next v1 0/4] Broadcom PTP PHY support Jonathan Lemon
2022-04-24 2:23 ` [PATCH net-next v1 1/4] net: phy: broadcom: Add PTP support for some Broadcom PHYs Jonathan Lemon
2022-04-24 23:27 ` Florian Fainelli
2022-04-25 23:53 ` Jonathan Lemon
2022-04-25 1:19 ` Richard Cochran
2022-04-25 23:30 ` Jonathan Lemon
2022-04-26 2:49 ` Richard Cochran
2022-04-26 3:02 ` Richard Cochran
2022-04-25 1:38 ` Richard Cochran
2022-04-25 23:55 ` Jonathan Lemon
2022-04-26 2:53 ` Richard Cochran
2022-04-26 18:02 ` Florian Fainelli [this message]
2022-04-25 3:12 ` Richard Cochran
2022-04-25 23:47 ` Jonathan Lemon
2022-04-27 14:40 ` Richard Cochran
2022-04-28 5:02 ` Jonathan Lemon
2022-04-24 2:23 ` [PATCH net-next v1 2/4] net: phy: broadcom: Add Broadcom PTP hooks to bcm-phy-lib Jonathan Lemon
2022-04-24 23:35 ` Florian Fainelli
2022-04-24 2:23 ` [PATCH net-next v1 3/4] net: phy: broadcom: Hook up the PTP PHY functions Jonathan Lemon
2022-04-24 23:29 ` Florian Fainelli
2022-04-24 2:23 ` [PATCH net-next v1 4/4] net: phy: Kconfig: Add broadcom PTP PHY library Jonathan Lemon
2022-04-24 23:29 ` Florian Fainelli
2022-04-25 1:01 ` [PATCH net-next v1 0/4] Broadcom PTP PHY support Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2823186c-d495-bd9b-87be-5e98a980ca04@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.