All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: David Ahern <dsa@cumulusnetworks.com>,
	David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	pablo@netfilter.org
Subject: Re: [PATCH 0/6] stricter netlink validation
Date: Fri, 05 Apr 2019 09:09:32 +0200	[thread overview]
Message-ID: <282a621c0a0cc86787901d8ce96068b2ca680d0a.camel@sipsolutions.net> (raw)
In-Reply-To: <db599b6b-94a5-3123-5613-9e349fcee702@cumulusnetworks.com> (sfid-20190405_044429_517897_85795668)

On Thu, 2019-04-04 at 20:44 -0600, David Ahern wrote:
> Hit a compile issue right out of the gate:
> 
> $ make O=kbuild/perf -j 24 -s
> /home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c: In function
> ‘validate_and_copy_check_pkt_len’:
> /home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c:2887:8: error:
> implicit declaration of function ‘nla_parse_deprecated_strict’
> [-Werror=implicit-function-declaration]
>   err = nla_parse_deprecated_strict(a, OVS_CHECK_PKT_LEN_ATTR_MAX,
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> You should do an allmodconfig build to check for any others. I disabled
> ovs to continue.

Ugh, yes. The one change I made because I rebased on the latest net-next 
after the build testing ...

Sorry about that, I'll fix it in v2 after more reviews.

johannes


  reply	other threads:[~2019-04-05  7:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04  6:54 [PATCH 0/6] stricter netlink validation Johannes Berg
2019-04-04  6:54 ` [PATCH 1/6] netlink: add NLA_MIN_LEN Johannes Berg
2019-04-04  6:54 ` [PATCH 2/6] netlink: make validation more configurable for future strictness Johannes Berg
2019-04-10 16:55   ` David Ahern
2019-04-12  9:43     ` Johannes Berg
2019-04-04  6:54 ` [PATCH 3/6] netlink: re-add parse/validate functions in strict mode Johannes Berg
2019-04-04  6:54 ` [PATCH 4/6] netlink: add strict parsing for future attributes Johannes Berg
2019-04-05 15:22   ` Nicolas Dichtel
2019-04-05 15:31     ` Johannes Berg
2019-04-05 15:40       ` Nicolas Dichtel
2019-04-04  6:54 ` [PATCH 5/6] genetlink: optionally validate strictly/dumps Johannes Berg
2019-04-04  6:54 ` [PATCH 6/6] nl80211: tag policies with strict_start_type Johannes Berg
2019-04-04 17:28 ` [PATCH 0/6] stricter netlink validation David Miller
2019-04-04 20:20   ` Johannes Berg
2019-04-05  2:44   ` David Ahern
2019-04-05  7:09     ` Johannes Berg [this message]
2019-04-05 11:47   ` Johannes Berg
2019-04-05 15:13     ` Johannes Berg
2019-04-08  9:00 ` Leon Romanovsky
2019-04-08  9:01   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=282a621c0a0cc86787901d8ce96068b2ca680d0a.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.