From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] x86/hvm: finish IOREQ correctly on completion path Date: Mon, 11 Mar 2019 11:39:03 +0000 Message-ID: <2830bbcb659140119a96d6d851316dba@AMSPEX02CL02.citrite.net> References: <1552080650-9168-1-git-send-email-igor.druzhinin@citrix.com> <71b6e1dee81b499a90e4b24b1989abf6@AMSPEX02CL02.citrite.net> <5C864097020000780021D280@prv1-mh.provo.novell.com> <5C864762020000780021D2A9@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h3JGv-0005aI-Pe for xen-devel@lists.xenproject.org; Mon, 11 Mar 2019 11:39:09 +0000 In-Reply-To: <5C864762020000780021D2A9@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' Cc: Andrew Cooper , Roger Pau Monne , Wei Liu , xen-devel , Igor Druzhinin List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMTEgTWFyY2ggMjAxOSAxMTozMwo+IFRvOiBQYXVs IER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29tPgo+IENjOiBBbmRyZXcgQ29vcGVyIDxB bmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgSWdvciBEcnV6aGluaW4gPGlnb3IuZHJ1emhpbmlu QGNpdHJpeC5jb20+OyBSb2dlciBQYXUKPiBNb25uZSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBX ZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPjsgeGVuLWRldmVsIDx4ZW4tCj4gZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmc+Cj4gU3ViamVjdDogUkU6IFtQQVRDSF0geDg2L2h2bTogZmluaXNo IElPUkVRIGNvcnJlY3RseSBvbiBjb21wbGV0aW9uIHBhdGgKPiAKPiA+Pj4gT24gMTEuMDMuMTkg YXQgMTI6MDksIDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPj4gRnJvbTogSmFu IEJldWxpY2ggW21haWx0bzpKQmV1bGljaEBzdXNlLmNvbV0KPiA+PiBTZW50OiAxMSBNYXJjaCAy MDE5IDExOjA0Cj4gPj4KPiA+PiA+Pj4gT24gMTEuMDMuMTkgYXQgMTE6MzAsIDxQYXVsLkR1cnJh bnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPj4gPj4gRnJvbTogSWdvciBEcnV6aGluaW4gW21haWx0 bzppZ29yLmRydXpoaW5pbkBjaXRyaXguY29tXQo+ID4+ID4+IFNlbnQ6IDA4IE1hcmNoIDIwMTkg MjE6MzEKPiA+PiA+Pgo+ID4+ID4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vZW11bGF0ZS5jCj4g Pj4gPj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiA+PiA+PiBAQCAtMTA4MCw3 ICsxMDgwLDE1IEBAIHN0YXRpYyBpbnQgbGluZWFyX3JlYWQodW5zaWduZWQgbG9uZyBhZGRyLCB1 bnNpZ25lZCBpbnQgYnl0ZXMsIHZvaWQKPiAqcF9kYXRhLAo+ID4+ID4+ICAgICAgICAgICAgICAg ICAgICAgICAgIHVpbnQzMl90IHBmZWMsIHN0cnVjdCBodm1fZW11bGF0ZV9jdHh0ICpodm1lbXVs X2N0eHQpCj4gPj4gPj4gIHsKPiA+PiA+PiAgICAgIHBhZ2VmYXVsdF9pbmZvX3QgcGZpbmZvOwo+ ID4+ID4+IC0gICAgaW50IHJjID0gaHZtX2NvcHlfZnJvbV9ndWVzdF9saW5lYXIocF9kYXRhLCBh ZGRyLCBieXRlcywgcGZlYywgJnBmaW5mbyk7Cj4gPj4gPj4gKyAgICBjb25zdCBzdHJ1Y3QgaHZt X3ZjcHVfaW8gKnZpbyA9ICZjdXJyZW50LT5hcmNoLmh2bS5odm1faW87Cj4gPj4gPj4gKyAgICBp bnQgcmMgPSBIVk1UUkFOU19iYWRfZ2ZuX3RvX21mbjsKPiA+PiA+PiArCj4gPj4gPj4gKyAgICAv Kgo+ID4+ID4+ICsgICAgICogSWYgdGhlIG1lbW9yeSBhY2Nlc3MgY2FuIGJlIGhhbmRsZWQgaW1t ZWRpYXRlbHkgLSBkbyBpdCwKPiA+PiA+PiArICAgICAqIG90aGVyd2lzZSByZS1lbnRlciBpb3Jl cSBjb21wbGV0aW9uIHBhdGggdG8gcHJvcGVybHkgY29uc3VtZSBpdC4KPiA+PiA+PiArICAgICAq Lwo+ID4+ID4+ICsgICAgaWYgKCAhaHZtX2lvcmVxX25lZWRzX2NvbXBsZXRpb24oJnZpby0+aW9f cmVxKSApCj4gPj4gPj4gKyAgICAgICAgcmMgPSBodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcihw X2RhdGEsIGFkZHIsIGJ5dGVzLCBwZmVjLCAmcGZpbmZvKTsKPiA+PiA+Cj4gPj4gPiBJIHRoaW5r IHRoaXMgaXMgdGhlIHJpZ2h0IHRoaW5nIHRvIGRvCj4gPj4KPiA+PiBJdCdzIG5vdCwgYW5kIHRo YXQncyB3aHkgSSBoYWQgd3JpdHRlbiB0aGF0IGVhcmxpZXIgZXhwbGFuYXRpb24gd2hpY2gKPiA+ PiB5b3UgdGhlbiByZXNwb25kZWQgdG8gc2F5aW5nIHRoYXQgdGhlIGlzc3VlIG5lZWRzIHRvIGJl IGRlYWx0IHdpdGgKPiA+PiBieSBlbmZvcmNpbmcgYSBjb25zaXN0ZW50IHZpZXcgb2YgTU1JTyAo b3Igbm90KSBkdXJpbmcgaW5pdGlhbCB0cnkgYW5kCj4gPj4gcmVwbGF5LiBUaGF0J3MgX25vdF8g d2hhdCB0aGUgYWJvdmUgZG9lcyBpbiB0aGUgZ2VuZXJhbCBjYXNlOiBJdAo+ID4+IHNpbXBseSBm b3JjZXMgX2FsbF8gYWNjZXNzZXMgaW50byB0aGUgc2xvdyBwYXRoLCB0aHVzIHJlLWludHJvZHVj aW5nCj4gPj4gdGhlIHByb2JsZW0gb2YgcGFnZSBzdHJhZGRsaW5nIGFjY2Vzc2VzIG5vdCBnZXR0 aW5nIHJvdXRlZCBjb3JyZWN0bHkuCj4gPgo+ID4gV2h5PyBJZiB0aGVyZSBpcyBubyBwZW5kaW5n IGlvcmVxIHRoZW4gd2h5IHdvdWxkIHRoZSBjYWxsIHRvCj4gPiBodm1fY29weV9mcm9tX2d1ZXN0 X2xpbmVhcigpIG5vdCBoYXBwZW4/IEFGQUlDVCB2aW8tPmlvX3JlcSB3aWxsIG9ubHkgYmUKPiA+ IHVwZGF0ZWQgd2hlbiBodm1lbXVsX2RvX2lvKCkgaXNzdWVzIGEgbmV3IGlvcmVxLCBzbyB0aGUg dGVzdCBhcHBlYXJzIGNvcnJlY3QuCj4gPiBIb3cgaXMgdGhhdCBfYWxsXyBhY2Nlc3MgZmFpbCB0 aGlzIHRlc3Q/Cj4gCj4gIkFsbCIgd2FzIHRvbyBoZWF2eSwgYXMgcGVyIHRoaXMgZGlzY3Vzc2lv bjoKPiAKPiA+PiBFdmVuIHdvcnNlLCBpdCBmb3JjZXMgX2FsbF8gbWVtb3J5IGFjY2Vzc2VzIGJ5 IHRoZSBpbnNuIHVuZGVyCj4gPj4gZW11bGF0aW9uIGludG8gdGhlIE1NSU8gcGF0aC4gV2hpbGUg dGhpcyB3b3VsZCBoYXBwZW4gdG8gYmUgb2theQo+ID4+IGZvciBhIFBVU0ggZnJvbSBNTUlPIChi ZWNhdXNlIHRoZSByZWFkIGNvbWVzIGZpcnN0LCBhbmQgaGVuY2UgdGhlCj4gPj4gd3JpdGUgd291 bGQgbm8gbG9uZ2VyIHNlZSBhIHBlbmRpbmcgSU9SRVEpLCBpdCdzIHdyb25nIGZvciAoYW1vbmcK PiA+PiBtYW55IG90aGVyIGNhc2VzKSBhIFBPUCB0byBNTUlPLCBhcyB0aGUgcmVhZCAoZnJvbSBz dGFjaywgaS5lLiBSQU0pCj4gPj4gd2lsbCBiZSByZXBsYXllZCBmaXJzdCwgd2hpbGUgdGhlIElP UkVRIGlzIHN0aWxsIG1hcmtlZCBpbmNvbXBsZXRlLiBJJ2QKPiA+PiBleHBlY3QgdGhpcyB0byB0 cmlnZ2VyIHRoZSB2ZXJ5IGRvbWFpbl9jcmFzaCgpIGluIGh2bWVtdWxfZG9faW8oKQo+ID4+IHRo YXQgd2FzIGFsc28gdHJpZ2dlcmluZyBiZWNhdXNlIG9mIHRoZSBQMk0gdHlwZSBjaGFuZ2UgYmVo aW5kIG91cgo+ID4+IGJhY2tzLgo+IAo+IEkgc2hvdWxkIGhhdmUgc2FpZCAiYWxsIGFjY2Vzc2Vz IHByZWNlZGluZyB0aGUgb25lIHJlYWxseSBhY2Nlc3NpbmcKPiBNTUlPIi4gVXNpbmcgdGhlIHBy b3ZpZGVkIGV4YW1wbGUgb2YgUE9QLCB0aGUgbGluZWFyX3JlYWQoKSBpbnZvY2F0aW9uCj4gZHVy aW5nIHJlcGxheSAodG8gcmVhZCB0aGUgc3RhY2spIHdpbGwgZmluZCBhIHBlbmRpbmcgSU9SRVEs IGFuZCB3cm9uZ2x5Cj4gZ28gdGhlIE1NSU8gcGF0aC4gVGhpcyB3b3VsZCwgaW4gdGhpcyBleGFt cGxlLCBiZSBjb3JyZWN0IG9ubHkgZm9yCj4gbGluZWFyX3dyaXRlKCkgdG8gZG8uIFNvIHRoZSBz dWdnZXN0ZWQgY2hhbmdlIGlzIGNvcnJlY3Qgb25seSBmb3IgYW55Cj4gaW5zbiBhY2Nlc3Npbmcg bm8gbW9yZSB0aGFuIG9uZSBtZW1vcnkgbG9jYXRpb24gKGlmIHRoZXJlJ3Mgbm8gbWVtb3J5Cj4g YWNjZXNzIHRoZW4gb2YgY291cnNlIHdlIHdvbid0IG1ha2UgaXQgaGVyZSBpbiB0aGUgZmlyc3Qg cGxhY2UpLgoKT2ssIHRoYW5rcyBmb3IgdGhlIGNsYXJpZmljYXRpb24uIFNvLCB0aGUgcHJvYmxl bSBpcyB0aGF0IG1lbW9yeSBhY2Nlc3NlcyBhcmUgbm90IHN0YXNoZWQgKHVuZGVyc3RhbmRhYmx5 IEkgZ3Vlc3MpIGluIHRoZSBtbWlvX2NhY2hlLiBJZiB0aGV5IHdlcmUgdGhlbiBmb3JjaW5nIHRo ZSBjb2RlIGRvd24gdGhlIE1NSU8gcGF0aCB3b3VsZCB3b3JrLiBTbywgd2hhdCB3ZSBwcm9iYWJs eSBuZWVkIGlzIGEgY2FjaGUgb2YgYWxsIGFjY2Vzc2VzIHRoYXQgYW4gaW5zdHJ1Y3Rpb24gaGFz IG1hZGUgdG8gZGF0ZSwgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIHRoZXkgaGl0IFJBTSBvciBJL08g ZW11bGF0aW9uLgoKICBQYXVsCgo+IAo+IEphbgo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=