All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 2/6] pci: Add comment for pci_add_capability2()
Date: Fri, 2 Jun 2017 15:54:38 +0800	[thread overview]
Message-ID: <28378a4dc27a2694dfacf5254813d59175cda4e6.1496387804.git.maozy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <cover.1496387804.git.maozy.fnst@cn.fujitsu.com>

Add a comment for pci_add_capability2() to explain the return
value. This may help to make a correct return value check for
its callers.

Cc: mst@redhat.com
Cc: marcel@redhat.com
Cc: armbru@redhat.com
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
---
 hw/pci/pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 53566b8..9810d5f 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2276,6 +2276,10 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
     return ret;
 }
 
+/*
+ * On success, pci_add_capability2() returns a positive value.
+ * On failure, it sets an error and returns a negative value.
+ */
 int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
                        uint8_t offset, uint8_t size,
                        Error **errp)
-- 
2.9.3

  parent reply	other threads:[~2017-06-02  7:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  7:54 [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup Mao Zhongyi
2017-06-02  7:54 ` [Qemu-devel] [PATCH v2 1/6] pci: Clean up error checking in pci_add_capability() Mao Zhongyi
2017-06-06 15:26   ` Michael S. Tsirkin
2017-06-06 16:14     ` Markus Armbruster
2017-06-06 18:06       ` Michael S. Tsirkin
2017-06-06 18:53         ` Markus Armbruster
2017-06-02  7:54 ` Mao Zhongyi [this message]
2017-06-05 13:34   ` [Qemu-devel] [PATCH v2 2/6] pci: Add comment for pci_add_capability2() Marcel Apfelbaum
2017-06-06  1:34     ` Mao Zhongyi
2017-06-02  7:54 ` [Qemu-devel] [PATCH v2 3/6] pci: Fix the wrong return value judgment condition Mao Zhongyi
2017-06-05 16:20   ` Marcel Apfelbaum
2017-06-06  1:14     ` Mao Zhongyi
2017-06-02  7:54 ` [Qemu-devel] [PATCH v2 4/6] net/eepro100: Fixed code style Mao Zhongyi
2017-06-02  7:54 ` [Qemu-devel] [PATCH v2 5/6] pci: Make errp the last parameter of pci_add_capability() Mao Zhongyi
2017-06-02 17:45   ` Eduardo Habkost
2017-06-05  3:06     ` Mao Zhongyi
2017-06-02  7:54 ` [Qemu-devel] [PATCH v2 6/6] pci: Convert to realize Mao Zhongyi
2017-06-06 15:23 ` [Qemu-devel] [PATCH v2 0/6] Convert to realize and cleanup Michael S. Tsirkin
2017-06-07  2:51   ` Mao Zhongyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28378a4dc27a2694dfacf5254813d59175cda4e6.1496387804.git.maozy.fnst@cn.fujitsu.com \
    --to=maozy.fnst@cn.fujitsu.com \
    --cc=armbru@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.