From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9289C43382 for ; Wed, 26 Sep 2018 09:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC83320779 for ; Wed, 26 Sep 2018 09:41:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC83320779 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbeIZPxj (ORCPT ); Wed, 26 Sep 2018 11:53:39 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:55052 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbeIZPxj (ORCPT ); Wed, 26 Sep 2018 11:53:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 42KtHW0gZbz9ttST; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id c59T4_WQr0DD; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 42KtHW038zz9ttRc; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4AD958B803; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 2ttDEZ_Gdx60; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from PO15451 (unknown [172.25.231.3]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 217E58B7EB; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Subject: Re: [PATCH v3 2/2] powerpc/64: add stack protector support To: Segher Boessenkool Cc: Russell Currey , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <2b934594d21ade67a4092637cf9e6b7d2d131187.1537801613.git.christophe.leroy@c-s.fr> <0797fc91-6400-2508-1cc0-4bba78aafbbb@c-s.fr> <30fb4e6b-0981-c53c-a1db-94138eaad268@c-s.fr> <20180926092806.GM23155@gate.crashing.org> From: Christophe LEROY Message-ID: <284752d1-6c32-bdca-72d3-4d8616b26fbf@c-s.fr> Date: Wed, 26 Sep 2018 11:41:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180926092806.GM23155@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 26/09/2018 à 11:28, Segher Boessenkool a écrit : > On Wed, Sep 26, 2018 at 09:58:30AM +0200, Christophe LEROY wrote: >> Segher, any idea about this problem ? > >>>> arch/powerpc/platforms/powermac/bootx_init.o: In function `bootx_printf': >>>> /var/lib/jenkins-slave/workspace/snowpatch/snowpatch-linux- >>>> sparse/linux/arch/powerpc/platforms/powermac/bootx_init.c:88: >>>> undefined reference to `__stack_chk_fail_local' > > Are you building as PIC? Are you linking libssp_nonshared.a? Why not? Spotted, thanks. arch/powerpc/platforms/powermac/Makefile contains: CFLAGS_bootx_init.o += -fPIC Does it mean we should add -lssp_nonshared to LDFLAGS_vmlinux ? Or maybe stack protection on bootx_init doesn't make much sense and we could just do the following ? CFLAGS_bootx_init.o += -fPIC $(call cc-option, -fno-stack-protector) Christophe > > :-) > > > Segher >