From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wang, Zhihong" <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/3] eal/x86: fix build with clang for old AVX
Date: Thu, 04 Feb 2016 09:47:54 +0100 [thread overview]
Message-ID: <2848756.Pj2zKKyaol@xps13> (raw)
In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941033ACABA@SHSMSX103.ccr.corp.intel.com>
2016-02-04 03:35, Wang, Zhihong:
> > Subject: [PATCH 1/3] eal/x86: fix build with clang for old AVX
> >
> > When configuring RTE_MACHINE to "default", rte_memcpy implementation
> > is the default one (old AVX).
> > In this code, clang raises a warning thanks to -Wsometimes-uninitialized:
> >
> > rte_memcpy.h:838:6: error:
> > variable 'srcofs' is used uninitialized whenever 'if' condition is false
> > if (dstofss > 0) {
> > ^~~~~~~~~~~
> > rte_memcpy.h:849:6: note: uninitialized use occurs here
> > if (srcofs == 0) {
> > ^~~~~~
> >
> > It is fixed by initializing srcofs to 0.
> >
> > Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512")
>
> Hi Thomas,
>
> Thanks for pointing this out!
> My last hasty modification on this is not correct.
>
> The patch below will fix it. All modifications are tested.
> Sorry for all the hassle! :'(
>
> "srcofs" should be calculated based on source address anyway.
OK
Please send a full patch as usual, thanks.
next prev parent reply other threads:[~2016-02-04 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 18:56 [PATCH 0/3] fix build for default machine Thomas Monjalon
2016-02-03 18:56 ` [PATCH 1/3] eal/x86: fix build with clang for old AVX Thomas Monjalon
2016-02-04 3:35 ` Wang, Zhihong
2016-02-04 8:47 ` Thomas Monjalon [this message]
2016-02-04 9:21 ` Thomas Monjalon
2016-02-03 18:56 ` [PATCH 2/3] examples/l3fwd: fix build without SSE4.1 Thomas Monjalon
2016-02-08 14:09 ` De Lara Guarch, Pablo
2016-02-03 18:56 ` [PATCH 3/3] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thomas Monjalon
2016-02-16 6:53 ` [PATCH 0/3] fix build for default machine Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2848756.Pj2zKKyaol@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.