From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC6BC54EED for ; Tue, 24 Jan 2023 07:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232422AbjAXH2H (ORCPT ); Tue, 24 Jan 2023 02:28:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjAXH2H (ORCPT ); Tue, 24 Jan 2023 02:28:07 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1175E974C; Mon, 23 Jan 2023 23:28:05 -0800 (PST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30O7OPln026293; Tue, 24 Jan 2023 07:27:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=KwQ/PtpYUTz+cVdN4b3hZ/Dm5u2vC7+yvEKnwB3nkAA=; b=PS6PoZCpSi3B5YUgjUt0VCH2FSsVBbgrEXJLdKMOUew2dgGxjzZae6oGyOg9dsEu9scL o/sCPGpSyUYi1dZa5fZhaOEpZxCMj6MNk6pLI0zMQb/iAtcI1pHIduLb/hsOIpMq+149 +FYBevsmSikxwHlz/qK54206eVkZdDWMAOtwDW70ug+4560bkpXDllnUpEZd7FkJVMaM V7xpr4LRpN2DLDBPgSI1dt3pd96cmlk2urXZ+Dym2xvZzT5e0DxouZ5jsoazhCQGv8oP 5DzUwm1TAqN41MA4pVHIRyBCPm6qlIaeyp5e+BG0ylMkGO2zpVqITQX0JHqvRnXaRsEG Gw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n89dncfdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 07:27:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30O7RGuG011025 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 07:27:16 GMT Received: from [10.216.24.6] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 23 Jan 2023 23:27:07 -0800 Message-ID: <2852fc37-284f-6534-f163-45b37b153db1@quicinc.com> Date: Tue, 24 Jan 2023 12:57:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230110121316.24892-1-quic_devipriy@quicinc.com> <20230110121316.24892-3-quic_devipriy@quicinc.com> <9bdf757d-1fa0-106f-eb77-7f2a8593213f@linaro.org> From: Devi Priya In-Reply-To: <9bdf757d-1fa0-106f-eb77-7f2a8593213f@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: STEphrwkEN8UcQaS1cFm2yXVFfi5Dkf- X-Proofpoint-ORIG-GUID: STEphrwkEN8UcQaS1cFm2yXVFfi5Dkf- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301240068 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 1/13/2023 7:39 PM, Konrad Dybcio wrote: > > > On 13.01.2023 14:21, Devi Priya wrote: >> >> >> On 1/10/2023 6:07 PM, Konrad Dybcio wrote: >>> >>> >>> On 10.01.2023 13:13, devi priya wrote: >>>> Add Global Clock Controller (GCC) driver for ipq9574 based devices >>>> >>>> Co-developed-by: Anusha Rao >>>> Signed-off-by: Anusha Rao >>>> Signed-off-by: devi priya >>>> --- > [...] > >>>> +static struct clk_branch gcc_blsp1_qup6_i2c_apps_clk = { >>>> +    .halt_reg = 0x07024, >>>> +    .clkr = { >>>> +        .enable_reg = 0x07024, >>>> +        .enable_mask = BIT(0), >>>> +        .hw.init = &(struct clk_init_data) { >>>> +            .name = "gcc_blsp1_qup6_i2c_apps_clk", >>>> +            .parent_hws = (const struct clk_hw *[]) { >>>> +                    &blsp1_qup6_i2c_apps_clk_src.clkr.hw }, >>>> +            .num_parents = 1, >>>> +            .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, >>> Sounds very much like a hack.. >> Got it, will remove the clock entry as it is not being used in linux > I'm not sure removing it is the best option, somebody might have a > funky board where they use this particular QUP for I2C for whatever > reason and then the clock would have to be re-added.. Sure, Understood This clock is used by the RPM component to communicate with PMIC and we would add the critical flag here > Thanks for addressing all of the review comments so thoroughly! > > Konrad Best Regards, Devi Priya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C2B3C25B4E for ; Tue, 24 Jan 2023 07:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yCQzFdkG02+6OXY18wdK7mVdEMR3wQ3A8ejSAtM3LSM=; b=ZVluh1STIf60aZ CuZ9hSUHN/xAza1TA70yUwplK81Ttm8cJnSzj+v8XdigXTlmJ+BGEk5siP2uEUq4UuWNu7AVzZGRl L1sklKk8sdxm2Dndi81jTXBtj885+DdXvR0Zs0oVP3IVzO0+1x5mvibTfvnKk1Pj69SZ3BSOVnZFO MS8LbVE8XLAkfY6U87BQ1sLUdx5IYnFuYu9rMjhcwsH9Lt+EoyW8MF+65zd+FGbHMfYII9NA7a1DB 7EkD3fl7yqfpfXOORMz1dJMOGzH9aMJWZdsf9mYh15aTSuHP02neV7i1caqX05TpTo+Kf3MvmbOx+ Kpq33sreQekzMpBO8rpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKDip-002e3u-MA; Tue, 24 Jan 2023 07:27:59 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKDin-002e2z-6i for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 07:27:58 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30O7OPln026293; Tue, 24 Jan 2023 07:27:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=KwQ/PtpYUTz+cVdN4b3hZ/Dm5u2vC7+yvEKnwB3nkAA=; b=PS6PoZCpSi3B5YUgjUt0VCH2FSsVBbgrEXJLdKMOUew2dgGxjzZae6oGyOg9dsEu9scL o/sCPGpSyUYi1dZa5fZhaOEpZxCMj6MNk6pLI0zMQb/iAtcI1pHIduLb/hsOIpMq+149 +FYBevsmSikxwHlz/qK54206eVkZdDWMAOtwDW70ug+4560bkpXDllnUpEZd7FkJVMaM V7xpr4LRpN2DLDBPgSI1dt3pd96cmlk2urXZ+Dym2xvZzT5e0DxouZ5jsoazhCQGv8oP 5DzUwm1TAqN41MA4pVHIRyBCPm6qlIaeyp5e+BG0ylMkGO2zpVqITQX0JHqvRnXaRsEG Gw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n89dncfdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 07:27:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30O7RGuG011025 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 07:27:16 GMT Received: from [10.216.24.6] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 23 Jan 2023 23:27:07 -0800 Message-ID: <2852fc37-284f-6534-f163-45b37b153db1@quicinc.com> Date: Tue, 24 Jan 2023 12:57:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230110121316.24892-1-quic_devipriy@quicinc.com> <20230110121316.24892-3-quic_devipriy@quicinc.com> <9bdf757d-1fa0-106f-eb77-7f2a8593213f@linaro.org> From: Devi Priya In-Reply-To: <9bdf757d-1fa0-106f-eb77-7f2a8593213f@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: STEphrwkEN8UcQaS1cFm2yXVFfi5Dkf- X-Proofpoint-ORIG-GUID: STEphrwkEN8UcQaS1cFm2yXVFfi5Dkf- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301240068 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_232757_270262_16D65C42 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxLzEzLzIwMjMgNzozOSBQTSwgS29ucmFkIER5YmNpbyB3cm90ZToKPiAKPiAKPiBPbiAx My4wMS4yMDIzIDE0OjIxLCBEZXZpIFByaXlhIHdyb3RlOgo+Pgo+Pgo+PiBPbiAxLzEwLzIwMjMg NjowNyBQTSwgS29ucmFkIER5YmNpbyB3cm90ZToKPj4+Cj4+Pgo+Pj4gT24gMTAuMDEuMjAyMyAx MzoxMywgZGV2aSBwcml5YSB3cm90ZToKPj4+PiBBZGQgR2xvYmFsIENsb2NrIENvbnRyb2xsZXIg KEdDQykgZHJpdmVyIGZvciBpcHE5NTc0IGJhc2VkIGRldmljZXMKPj4+Pgo+Pj4+IENvLWRldmVs b3BlZC1ieTogQW51c2hhIFJhbyA8cXVpY19hbnVzaGFAcXVpY2luYy5jb20+Cj4+Pj4gU2lnbmVk LW9mZi1ieTogQW51c2hhIFJhbyA8cXVpY19hbnVzaGFAcXVpY2luYy5jb20+Cj4+Pj4gU2lnbmVk LW9mZi1ieTogZGV2aSBwcml5YSA8cXVpY19kZXZpcHJpeUBxdWljaW5jLmNvbT4KPj4+PiAtLS0K PiBbLi4uXQo+IAo+Pj4+ICtzdGF0aWMgc3RydWN0IGNsa19icmFuY2ggZ2NjX2Jsc3AxX3F1cDZf aTJjX2FwcHNfY2xrID0gewo+Pj4+ICvCoMKgwqAgLmhhbHRfcmVnID0gMHgwNzAyNCwKPj4+PiAr wqDCoMKgIC5jbGtyID0gewo+Pj4+ICvCoMKgwqDCoMKgwqDCoCAuZW5hYmxlX3JlZyA9IDB4MDcw MjQsCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIC5lbmFibGVfbWFzayA9IEJJVCgwKSwKPj4+PiArwqDC oMKgwqDCoMKgwqAgLmh3LmluaXQgPSAmKHN0cnVjdCBjbGtfaW5pdF9kYXRhKSB7Cj4+Pj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgLm5hbWUgPSAiZ2NjX2Jsc3AxX3F1cDZfaTJjX2FwcHNfY2xr IiwKPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAucGFyZW50X2h3cyA9IChjb25zdCBzdHJ1 Y3QgY2xrX2h3ICpbXSkgewo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAmYmxzcDFfcXVwNl9pMmNfYXBwc19jbGtfc3JjLmNsa3IuaHcgfSwKPj4+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAubnVtX3BhcmVudHMgPSAxLAo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIC5mbGFncyA9IENMS19TRVRfUkFURV9QQVJFTlQgfCBDTEtfSUdOT1JFX1VOVVNFRCwK Pj4+IFNvdW5kcyB2ZXJ5IG11Y2ggbGlrZSBhIGhhY2suLgo+PiBHb3QgaXQsIHdpbGwgcmVtb3Zl IHRoZSBjbG9jayBlbnRyeSBhcyBpdCBpcyBub3QgYmVpbmcgdXNlZCBpbiBsaW51eAo+IEknbSBu b3Qgc3VyZSByZW1vdmluZyBpdCBpcyB0aGUgYmVzdCBvcHRpb24sIHNvbWVib2R5IG1pZ2h0IGhh dmUgYQo+IGZ1bmt5IGJvYXJkIHdoZXJlIHRoZXkgdXNlIHRoaXMgcGFydGljdWxhciBRVVAgZm9y IEkyQyBmb3Igd2hhdGV2ZXIKPiByZWFzb24gYW5kIHRoZW4gdGhlIGNsb2NrIHdvdWxkIGhhdmUg dG8gYmUgcmUtYWRkZWQuLgpTdXJlLCBVbmRlcnN0b29kClRoaXMgY2xvY2sgaXMgdXNlZCBieSB0 aGUgUlBNIGNvbXBvbmVudCB0byBjb21tdW5pY2F0ZSB3aXRoIFBNSUMgYW5kIHdlCndvdWxkIGFk ZCB0aGUgY3JpdGljYWwgZmxhZyBoZXJlCgo+IFRoYW5rcyBmb3IgYWRkcmVzc2luZyBhbGwgb2Yg dGhlIHJldmlldyBjb21tZW50cyBzbyB0aG9yb3VnaGx5IQo+IAo+IEtvbnJhZAoKQmVzdCBSZWdh cmRzLApEZXZpIFByaXlhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==