From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4CAC433EF for ; Thu, 28 Apr 2022 08:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240955AbiD1IQR (ORCPT ); Thu, 28 Apr 2022 04:16:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343921AbiD1IPo (ORCPT ); Thu, 28 Apr 2022 04:15:44 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33444985BA; Thu, 28 Apr 2022 01:12:31 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id 5CC3E1F45063 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651133549; bh=8bMyqaACFiy7OVrp3cMwiVvolfDCzZMcBSLFx20Uw90=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=EaSvayxCmdmZsLuclunB5vMl9alBjuoeXNSwKOFrE9jRXk0kC4L3YY53WNkwAwqee RcDDMp91NWvx9VvP9S3R09OhjLH2e6xombOgZaGeO6YI3bB2tIt4eVRkrLdo8pIfi8 Pjub2DCvS6qoNStEOneXVx11apS5IYn1Ku9vxy5s894V1EhQsuQrx24T3lMx/4l86r VIWRzVlC7H0VjKNm6lEfDenXal3dVqss8pI2+pCZCc8lsmClMxdIUzaEk4t1+WXLFn RXtExmeIGQ12+ZjVBkbiDTrpugOw9oDdo9fhYKnLfaGC9PvnUwHolRsgTa4+vIuCHU /CPXRcDbwddYg== Message-ID: <28534819-647e-1fef-2754-63aba75f821e@collabora.com> Date: Thu, 28 Apr 2022 13:12:19 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Cc: usama.anjum@collabora.com, Collabora Kernel ML , groeck@chromium.org, dtor@chromium.org, Len Brown , gwendal@chromium.org, vbendeb@chromium.org, andy@infradead.org, Ayman Bagabas , Benjamin Tissoires , =?UTF-8?Q?Bla=c5=be_Hrastnik?= , Darren Hart , Dmitry Torokhov , Greg Kroah-Hartman , Jeremy Soller , Mattias Jacobsson <2pi@mok.nu>, Mauro Carvalho Chehab , Rajat Jain , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , Enric Balletbo i Serra , "Rafael J. Wysocki" , Mark Gross Subject: Re: [PATCH v8] platform: x86: Add ChromeOS ACPI device driver Content-Language: en-US To: Hans de Goede , Benson Leung References: From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 4/27/22 7:22 PM, Hans de Goede wrote: > On 4/22/22 16:47, Muhammad Usama Anjum wrote: >> Hi Hans, >> >> Can I add you as a maintainer of drivers/platform/x86/chromeos_acpi.c? >> You already maintain some other drivers in this directory. > If you want to rely on me as default/fallback maintainer > for the new chromeos_acpi driver, then simply don't add > a MAINTAINERS entry for this driver. > > I'm the default maintainer for everything under > drivers/platform/x86/ . > > With that said: > > >> On 4/18/22 10:57 PM, Muhammad Usama Anjum wrote: >>> Hi Benson, >>> >>> We are very near to getting this patch in. I can see that you are >>> maintaining Chrome Platform support. This driver is in >>> drivers/platform/x86/chromeos_acpi.c. Can you maintain this driver as >>> well? I'll add you to the maintainers. > now that you mention it, moving this to drivers/platform/chrome/ > actually seems like the most sensible thing to do given that > this is chrome specific platform code. So please move it > there for the next version. > This driver was added in platform/x86 as it is only x86 specific. Definitely it makes more sense to move it to platform/chrome. I'll move it. > Talking about the next version, please address all review > remarks from Barnabás for the next version. > After Greg's comment to define attributes at compile time, the driver will change completely and way simpler. > Regards, > > Hans > > > -- Muhammad Usama Anjum