From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0C9C433EF for ; Fri, 15 Oct 2021 17:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43ED661040 for ; Fri, 15 Oct 2021 17:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242182AbhJORS5 (ORCPT ); Fri, 15 Oct 2021 13:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242176AbhJORSu (ORCPT ); Fri, 15 Oct 2021 13:18:50 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AD8C061767; Fri, 15 Oct 2021 10:16:43 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id i5so555477pla.5; Fri, 15 Oct 2021 10:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h1OfWNmPxnvZMni+hSGr/aPakXoUDhVv2xUOS4WlYDg=; b=kyPHGZmrPOS/mviCT0sz87P/tWmUvHvWTyD0U+V5YZoy+eLX3dOTwgcgrYP/ebIhX6 koEADONUdH4BLJPtn8C7gYcbgPz5XTOyogtmKNh1Xgm54h0qwlS7fhqPAYZ93oDeOxqg TrbShyJoma34MXNXE8WuNuvNqDjGwwgOoENO1JKNZkyAlHMkJhmc3VZK+3wRKVLCSvAo AsMqqyoCn1Ybb68clUy6OtA3YUqcCbKXaK4WN6ej3ca2F+gKrfY7+nZsEhqwF2m7N1dB jKuxjODzZjst70vMF+ETB4asYF4+2pjULbLZf4kufZfTjaoUCe5rQGPF171sZfOg4fN8 PFEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h1OfWNmPxnvZMni+hSGr/aPakXoUDhVv2xUOS4WlYDg=; b=xft/gXjatTmgZc5+mrheuZyMGe4dSHZ1NNAK3aLYFkOoqEGxkVAqavKrXsjZojCLWa p18MzmAI4KHRTRZ4INxg3GgEhA05ULENwd8e/YbeV9DwBxkzBs8a93DUKM548fV7dmqb PrKaKSuKlLN7PzeFrSe+moCxQMt9GXpLWt/IU3W28n7wsQZcZR6pjCGU14nsn++iNglM PFVfUZsecHUGTwifjhISxPQiavK0lc+QZPkXRFkd36iJfgPtJKe+sNVWur3tioz/Su/d kf3pCZO1M40yGI8SYHFqcRsoHDzdBAqtiW3DGEk5wb0I20DLhSIVlMcriXBFKaa0Tfsb OUWQ== X-Gm-Message-State: AOAM531F9Fia0mCt0RUuCFkUJnDoIVDTjjipM1WQKJ/gOMYxIw8+QSxm NKDfQW5lZFzmxPPLE07j4lA= X-Google-Smtp-Source: ABdhPJxDnJ9gEfsIjDn1Pb1K/slL3blAcdVmn64+NKMFsrbUb4oQ/BHNdP6eXr2WWDYflbz3V9L6aA== X-Received: by 2002:a17:902:e74a:b0:13f:3538:fca0 with SMTP id p10-20020a170902e74a00b0013f3538fca0mr12160835plf.22.1634318203132; Fri, 15 Oct 2021 10:16:43 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id s17sm5666597pfs.91.2021.10.15.10.16.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 10:16:42 -0700 (PDT) Subject: Re: [PATCH net-next 2/6] ARM: dts: ls1021a-tsn: update RGMII delays for sja1105 switch To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Shawn Guo , Andrew Lunn , Heiner Kallweit , Russell King , Vivien Didelot , Vladimir Oltean , Prasanna Vengateshan , Ansuel Smith , =?UTF-8?Q?Alvin_=c5=a0ipraga?= References: <20211013222313.3767605-1-vladimir.oltean@nxp.com> <20211013222313.3767605-3-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: <28551a3d-541e-8538-6a2f-110eeacd0500@gmail.com> Date: Fri, 15 Oct 2021 10:16:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211013222313.3767605-3-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/21 3:23 PM, Vladimir Oltean wrote: > In the new behavior, the sja1105 driver expects there to be explicit > RGMII delays present on the fixed-link ports, otherwise it will complain > that it falls back to legacy behavior, which is to apply RGMII delays > incorrectly derived from the phy-mode string. > > In this case, the legacy behavior of the driver is to not apply delays > in any direction (mostly because the SJA1105T can't do that, so this > board uses PCB traces). To preserve that but also silence the driver, > use explicit delays of 0 ns. The delay information from the phy-mode is > ignored by new kernels (it's still RGMII as long as it's "rgmii*" > something), and the explicit {rx,tx}-internal-delay-ps properties are > ignored by old kernels, so the change works both ways. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33FCC433F5 for ; Fri, 15 Oct 2021 17:19:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9165E610E8 for ; Fri, 15 Oct 2021 17:19:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9165E610E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=brtBuqYqZzZv4iUDvtQkSPiMFWF2klCnWsq5spKVxdY=; b=oqieiiZZMDWDxZrhPsxdHBGQQ7 +L7AwbGiI7quQoe4n7Zp5PbomdtBS+G4aKwM4z5QRSqaG7FmQyoj04LDWIEVpl1mmb5ziT3xZnbxa VEmaPerCoySt+LeoB/KjcBQCP3H4+DLAS9xbbWS3u3BwfT7AGA//fC/etUMHqLuNI6zwzhL63SJoF eQDX+4S+KdzZ7NAot7ATDBQzgRE2VgJtXO5zHLjhNuKDVTQFj3mhp+A7Lwd6q97BmqH1C924VTsqT aCfvJoPrXrpxSCzlMKvZZQNaEzoU+WoJ+1OOXm17/50kDFryk1+aAop1BpGH9ohkTfNHTGBpjLaAU h91eIiHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbQqH-008HSf-Aa; Fri, 15 Oct 2021 17:18:03 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbQp1-008HAv-UE for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 17:16:45 +0000 Received: by mail-pl1-x62c.google.com with SMTP id s1so4976592plg.12 for ; Fri, 15 Oct 2021 10:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h1OfWNmPxnvZMni+hSGr/aPakXoUDhVv2xUOS4WlYDg=; b=kyPHGZmrPOS/mviCT0sz87P/tWmUvHvWTyD0U+V5YZoy+eLX3dOTwgcgrYP/ebIhX6 koEADONUdH4BLJPtn8C7gYcbgPz5XTOyogtmKNh1Xgm54h0qwlS7fhqPAYZ93oDeOxqg TrbShyJoma34MXNXE8WuNuvNqDjGwwgOoENO1JKNZkyAlHMkJhmc3VZK+3wRKVLCSvAo AsMqqyoCn1Ybb68clUy6OtA3YUqcCbKXaK4WN6ej3ca2F+gKrfY7+nZsEhqwF2m7N1dB jKuxjODzZjst70vMF+ETB4asYF4+2pjULbLZf4kufZfTjaoUCe5rQGPF171sZfOg4fN8 PFEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h1OfWNmPxnvZMni+hSGr/aPakXoUDhVv2xUOS4WlYDg=; b=lEpuSO/kmDv/cVS7rGeGQKniT6fLxdRLj+T4VcCGYquaiagVlWcIioGOTbm4h1FT1x g39NqCqFQyEOawzQ28zCRHQx9ep7dbHFpQSskoSlvRrkoj/n8KwQwY11iSNG5TElpBCK 2yiylWhWRn1t6D+8bk0zeqmHbsmJE2NmTifmyaxCHgzODf8Y4UBA2Ann93ycAkQ7No1L Y6gWDhxMuTWoSKlW0PLMs1CB8XOue0GXYaOdEmgjwmwK6bHyqTX1aC0AnWVNWPdZIVPn QDc/Ku6KM55JehfIJiQ7VruFSUKdVAnZ5WzxXMq/gsUasqlltcDta3Kal5LRj7TSh/qu JlEA== X-Gm-Message-State: AOAM532v7dlEbJIWiVY52Gv0l7Z4hS1kD7bJPyu4G4rB3/wKY/qW2stw NDe02xnFL4AXphd54IfvMwU= X-Google-Smtp-Source: ABdhPJxDnJ9gEfsIjDn1Pb1K/slL3blAcdVmn64+NKMFsrbUb4oQ/BHNdP6eXr2WWDYflbz3V9L6aA== X-Received: by 2002:a17:902:e74a:b0:13f:3538:fca0 with SMTP id p10-20020a170902e74a00b0013f3538fca0mr12160835plf.22.1634318203132; Fri, 15 Oct 2021 10:16:43 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id s17sm5666597pfs.91.2021.10.15.10.16.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 10:16:42 -0700 (PDT) Subject: Re: [PATCH net-next 2/6] ARM: dts: ls1021a-tsn: update RGMII delays for sja1105 switch To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Shawn Guo , Andrew Lunn , Heiner Kallweit , Russell King , Vivien Didelot , Vladimir Oltean , Prasanna Vengateshan , Ansuel Smith , =?UTF-8?Q?Alvin_=c5=a0ipraga?= References: <20211013222313.3767605-1-vladimir.oltean@nxp.com> <20211013222313.3767605-3-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: <28551a3d-541e-8538-6a2f-110eeacd0500@gmail.com> Date: Fri, 15 Oct 2021 10:16:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211013222313.3767605-3-vladimir.oltean@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_101644_035451_901DF271 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/13/21 3:23 PM, Vladimir Oltean wrote: > In the new behavior, the sja1105 driver expects there to be explicit > RGMII delays present on the fixed-link ports, otherwise it will complain > that it falls back to legacy behavior, which is to apply RGMII delays > incorrectly derived from the phy-mode string. > > In this case, the legacy behavior of the driver is to not apply delays > in any direction (mostly because the SJA1105T can't do that, so this > board uses PCB traces). To preserve that but also silence the driver, > use explicit delays of 0 ns. The delay information from the phy-mode is > ignored by new kernels (it's still RGMII as long as it's "rgmii*" > something), and the explicit {rx,tx}-internal-delay-ps properties are > ignored by old kernels, so the change works both ways. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel