From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbcCWMPl (ORCPT ); Wed, 23 Mar 2016 08:15:41 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:55719 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754254AbcCWMPg (ORCPT ); Wed, 23 Mar 2016 08:15:36 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: MaJun , Catalin.Marinas@arm.com, linux-kernel@vger.kernel.org, Will.Deacon@arm.com, mark.rutland@arm.com, marc.zyngier@arm.com, jason@lakedaemon.net, tglx@linutronix.de, lizefan@huawei.com, huxinwei@huawei.com, dingtianhong@huawei.com, liguozhu@hisilicon.com, guohanjun@huawei.com, zhaojunhua@hisilicon.com Subject: Re: [PATCH 0/2] Change the the config option of mbigen driver. Date: Wed, 23 Mar 2016 13:14:35 +0100 Message-ID: <28585531.7OYJ0u0gtH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1458723993-21044-1-git-send-email-majun258@huawei.com> References: <1458723993-21044-1-git-send-email-majun258@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:3IQPu9jzMQd26kMYu8d8zRQnoo7PvedENBwxq0wA0EIa+YWhEGn RnpIYImMF8dlQWTVtpZTi7vxphgAhhP1EcZkHeknHRmKupLpGPkeYef6gXVJZXpKminUH32 Bo5yzYc1LMHJ/SnarSfgmA0HfgLAuZj4obNuATFNosWpo7YwSN1UkZbrxN+mm/d7u47AOiO jsZk5BuX6hJSppkRCelew== X-UI-Out-Filterresults: notjunk:1;V01:K0:EgjYowjKSHM=:p6/K2g6EygxeNg8v51XzS3 c1qgVP2R0+SkcSDxJhl6WvjfWll0tAiYiOsBC1yDwuPH197XA+W/oS2UimTDzGfQNNKQ+jDc6 sW/ZWnREHWGC/cMiXZxuLQj//xtBAAzyRVc9IGhmBFNJRtbIJiP9x7s82aaOmuzOBNwdOqvT2 qUpxmTKUy2JKNTk1TWLCQWeh7cFHdhh2zwag6W6vQ0aNZjfDHwgIS/PktpZUI3sqnoCm3nE8T 29zjahjrTgxQcKVqakW8u38K3p+yjXQzU+H8y8rGUtvm7jZMfBjCKfzaoajs6vimqM3bytVuU GUYr2YtqyBZaCKKmj5BnVxiZYs6+Avlc/7/ppx7supyAK9cvRa39y4X8NmZWHiQgfS2MfR7L3 CT1k1vcW33nTYK0aOFh2Yr8aP7P27f60oX3Rt6dP3eyW5FXnIB/IRkE/uHhrblI4sek9uCXBZ E+KGPZrO+/8mBv6G83bZinAtNOKzdYDJHSnArGQ0xOxbbhEICgw0z75XgTWBYxDz5GPTkE2yH JOeM6S+MgliPrpbduIODFIuYiixViJg6g5xkzz07VWXFFz7SKIwfzkrnpkROyZa5kOMreKVOt FqBVRts6UK5X6s4pEjP4MpZQ/zjjbFtnltL2GlfHzKPDQOKmgi22t9moZpaBw9WZFYwhhOHG0 iXA9d68VD6ZTW7yFOW860FhZAwwn9Fk1aRScrW31teIMS62Fg+klDLo4eDogSFRFeriL/OxL7 r90zUJWR/CBjNWlx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 23 March 2016 17:06:31 MaJun wrote: > From: Ma Jun > > In current driver, the config of mbigen driver is a configurable option and > have nothing to do with CONFIG_ARCH_HISI. > > As a module of Hisilicon SOC, the config of mbigen driver should be selected > by CONFIG_ARCH_HISI on Hisilicon platform, but not a configurable option. > > This patch set is applied to fix this problem. > > I don't understand this one. I thought mbigen is specific to just one of Hisilicon's SoC families, while ARCH_HISI is more generic and can also be set for the other ones. Maybe just add 'default ARCH_HISI' and 'depends on ARCH_HISI || COMPILE_TEST' to the option? We should certainly keep building this driver for compile-test on all architectures. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 23 Mar 2016 13:14:35 +0100 Subject: [PATCH 0/2] Change the the config option of mbigen driver. In-Reply-To: <1458723993-21044-1-git-send-email-majun258@huawei.com> References: <1458723993-21044-1-git-send-email-majun258@huawei.com> Message-ID: <28585531.7OYJ0u0gtH@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 23 March 2016 17:06:31 MaJun wrote: > From: Ma Jun > > In current driver, the config of mbigen driver is a configurable option and > have nothing to do with CONFIG_ARCH_HISI. > > As a module of Hisilicon SOC, the config of mbigen driver should be selected > by CONFIG_ARCH_HISI on Hisilicon platform, but not a configurable option. > > This patch set is applied to fix this problem. > > I don't understand this one. I thought mbigen is specific to just one of Hisilicon's SoC families, while ARCH_HISI is more generic and can also be set for the other ones. Maybe just add 'default ARCH_HISI' and 'depends on ARCH_HISI || COMPILE_TEST' to the option? We should certainly keep building this driver for compile-test on all architectures. Arnd