All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Weilun Du <wdu@google.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	kernel-team@android.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mac80211_hwsim: add concurrent channels scanning support over virtio
Date: Thu, 06 May 2021 23:13:36 +0200	[thread overview]
Message-ID: <285a8ab279d5ac6caa6e44d808ec2b0ae134bc1e.camel@sipsolutions.net> (raw)
In-Reply-To: <CAD-gUuCt5ugOyo-9Ge5omTgNJu26OORZFEZ2tSnQEiNLZN9ZyA@mail.gmail.com> (sfid-20210506_231208_394097_2355C230)

On Thu, 2021-05-06 at 14:11 -0700, Weilun Du wrote:
> On Thu, May 6, 2021 at 11:19 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> > 
> > On Thu, 2021-05-06 at 11:05 -0700, Weilun Du wrote:
> > > This fixed the crash when setting channels to 2 or more when
> > > communicating over virtio.
> > 
> > Interesting, I thought I was probably the only user of virtio? :)
> > 
> > johannes
> > 
> Hi Johannes,
> Actually, Android Emulator uses mac80211_hwsim for wifi simulation
> over virtio and it's working. This patch fixed the crash when we set
> channels=2 to speed up scanning. I am trying to see if it makes sense
> to upstream this patch since it's not Android-specific. Thanks!
> 
Oh sure, I'll take a look and will probably apply it for the next cycle,
haven't done an in-depth review. I was just surprised somebody actually
*used* the virtio thing :-)

Does that mean virt_wifi isn't used anymore by the Android emulator?
Maybe then we should remove that again, it had some obscure bugs that
syzkaller found? Not that I mind it being around much, but ...

johannes


  reply	other threads:[~2021-05-06 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 18:05 [PATCH v1] mac80211_hwsim: add concurrent channels scanning support over virtio Weilun Du
2021-05-06 18:19 ` Johannes Berg
2021-05-06 21:11   ` Weilun Du
2021-05-06 21:13     ` Johannes Berg [this message]
2021-05-06 22:57       ` Weilun Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=285a8ab279d5ac6caa6e44d808ec2b0ae134bc1e.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=kernel-team@android.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wdu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.