From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost: add interface name to virtio-net struct Date: Thu, 18 Dec 2014 16:33:14 +0100 Message-ID: <2861628.6qtiPmT13X@xps13> References: <1418914523-24530-1-git-send-email-ciara.loftus@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org, Anthony Fee To: ciara.loftus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1418914523-24530-1-git-send-email-ciara.loftus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-18 14:55, ciara.loftus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org: > This patch fixes the issue whereby when using userspace vhost ports > in the context of vSwitching, the name provided to the hypervisor/QEMU > of the vhost tap device needs to be exposed in the library, in order > for the vSwitch to be able to direct packets to the correct device. Do you mean that vhost was not working at all? Please precise the context and how it is critical. More informations are needed to understand wether it should be merged in release 1.8.0 or not. > --- a/lib/librte_vhost/rte_virtio_net.h > +++ b/lib/librte_vhost/rte_virtio_net.h > @@ -96,6 +96,7 @@ struct virtio_net { > uint64_t features; /**< Negotiated feature set. */ > uint64_t device_fh; /**< device identifier. */ > uint32_t flags; /**< Device flags. Only used to check if device is running on data core. */ > + char ifname[32]; /** Name of the tap device **/ Wrong comment style. -- Thomas