All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: versatile: add missing header dependencies
@ 2016-09-14  6:29 Baoyou Xie
  2016-09-14  7:31 ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Baoyou Xie @ 2016-09-14  6:29 UTC (permalink / raw)
  To: mturquette, sboyd, linus.walleij, arnd
  Cc: linux-clk, linux-kernel, baoyou.xie, xie.baoyou

We get 1 warning when building kernel with W=1:
drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]

In fact, this function is declared in clk-realview.h,
so this patch add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/clk/versatile/clk-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/versatile/clk-realview.c b/drivers/clk/versatile/clk-realview.c
index c56efc7..f662fd1 100644
--- a/drivers/clk/versatile/clk-realview.c
+++ b/drivers/clk/versatile/clk-realview.c
@@ -10,6 +10,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/clk-provider.h>
+#include <linux/platform_data/clk-realview.h>
 
 #include "clk-icst.h"
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] clk: versatile: add missing header dependencies
  2016-09-14  6:29 [PATCH] clk: versatile: add missing header dependencies Baoyou Xie
@ 2016-09-14  7:31 ` Arnd Bergmann
  2016-09-14  9:04   ` Linus Walleij
  0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-14  7:31 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: mturquette, sboyd, linus.walleij, linux-clk, linux-kernel, xie.baoyou

On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in clk-realview.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Please leave this one for now. We are in the process of removing the
last caller of this function, and should just remove the header file
and the function definition in the next release.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] clk: versatile: add missing header dependencies
  2016-09-14  7:31 ` Arnd Bergmann
@ 2016-09-14  9:04   ` Linus Walleij
  2016-09-14  9:08     ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2016-09-14  9:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Baoyou Xie, Michael Turquette, Stephen Boyd, linux-clk,
	linux-kernel, xie.baoyou

On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
>>
>> In fact, this function is declared in clk-realview.h,
>> so this patch add missing header dependencies.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>>
>
> Please leave this one for now. We are in the process of removing the
> last caller of this function, and should just remove the header file
> and the function definition in the next release.

+1 on this, leave it. I can clean it up for v4.10 or even
for an -rc if you want it real neat in v4.9.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] clk: versatile: add missing header dependencies
  2016-09-14  9:04   ` Linus Walleij
@ 2016-09-14  9:08     ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-14  9:08 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Baoyou Xie, Michael Turquette, Stephen Boyd, linux-clk,
	linux-kernel, xie.baoyou

On Wednesday, September 14, 2016 11:04:29 AM CEST Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
> >> We get 1 warning when building kernel with W=1:
> >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> >>
> >> In fact, this function is declared in clk-realview.h,
> >> so this patch add missing header dependencies.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >>
> >
> > Please leave this one for now. We are in the process of removing the
> > last caller of this function, and should just remove the header file
> > and the function definition in the next release.
> 
> +1 on this, leave it. I can clean it up for v4.10 or even
> for an -rc if you want it real neat in v4.9.
> 

I think v4.10 is fine: Baoyou has done a great job so far fixing a lot
of those warnings, but we already know that there will be a lot remaining
after v4.9, so v4.10 is the earliest possible version in which we
can turn on the warning by default.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] clk: versatile: add missing header dependencies
  2016-09-24  4:31 Baoyou Xie
@ 2016-09-24  9:09 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-09-24  9:09 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: mturquette, sboyd, linus.walleij, linux-clk, linux-kernel, xie.baoyou

On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in
> include/linux/platform_data/clk-realview.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

I think I commented on this one already: the only caller of the
function is getting removed in v4.9, so we should remove the
definition of the function subsequently in the next release.

We could in theory try to remove this at the same time, but
the effort to synchronize the git trees is not worth the benefit.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] clk: versatile: add missing header dependencies
@ 2016-09-24  4:31 Baoyou Xie
  2016-09-24  9:09 ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Baoyou Xie @ 2016-09-24  4:31 UTC (permalink / raw)
  To: mturquette, sboyd, linus.walleij, arnd
  Cc: linux-clk, linux-kernel, baoyou.xie, xie.baoyou

We get 1 warning when building kernel with W=1:
drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]

In fact, this function is declared in
include/linux/platform_data/clk-realview.h,
so this patch adds missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/clk/versatile/clk-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/versatile/clk-realview.c b/drivers/clk/versatile/clk-realview.c
index c56efc7..f662fd1 100644
--- a/drivers/clk/versatile/clk-realview.c
+++ b/drivers/clk/versatile/clk-realview.c
@@ -10,6 +10,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/clk-provider.h>
+#include <linux/platform_data/clk-realview.h>
 
 #include "clk-icst.h"
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-09-24  9:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  6:29 [PATCH] clk: versatile: add missing header dependencies Baoyou Xie
2016-09-14  7:31 ` Arnd Bergmann
2016-09-14  9:04   ` Linus Walleij
2016-09-14  9:08     ` Arnd Bergmann
2016-09-24  4:31 Baoyou Xie
2016-09-24  9:09 ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.