From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D0AC433F4 for ; Tue, 28 Aug 2018 10:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0C0E208AC for ; Tue, 28 Aug 2018 10:06:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="K0SDNhUY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0C0E208AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbeH1N5h (ORCPT ); Tue, 28 Aug 2018 09:57:37 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:40596 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727094AbeH1N5h (ORCPT ); Tue, 28 Aug 2018 09:57:37 -0400 Received: from avalon.localnet (rec54-5-78-202-243-150.fbx.proxad.net [78.202.243.150]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B7401B92; Tue, 28 Aug 2018 12:06:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1535450801; bh=+Kh1TGHDH7p3jDfFl2D3yQc5sMrdImeqZD9zV10qX6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K0SDNhUYFIfLC+thllSbxD1XKIgEKEkp2wcMK8nYTUkzl5tgAywDCSOZKygzVcWKO ElUYOveH5uB0AfwD6R0BqDlQPnXvvh3au8jo2efiqejrRGWz3GyF9UAuowGqPONmCW NP6zc/brr/Ve0a9V2CnVPO0skADVkdcdOta6M/sQ= From: Laurent Pinchart To: Rob Herring Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , "Lad, Prabhakar" , Benoit Parrot , Philipp Zabel , Hyun Kwon , Michal Simek , linux-media@vger.kernel.org Subject: Re: [PATCH] media: Convert to using %pOFn instead of device_node.name Date: Tue, 28 Aug 2018 13:06:42 +0300 Message-ID: <2863201.EMhOTYQe29@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180828015252.28511-28-robh@kernel.org> References: <20180828015252.28511-1-robh@kernel.org> <20180828015252.28511-28-robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the patch. On Tuesday, 28 August 2018 04:52:29 EEST Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Mauro Carvalho Chehab > Cc: "Lad, Prabhakar" > Cc: Benoit Parrot > Cc: Philipp Zabel > Cc: Hyun Kwon > Cc: Laurent Pinchart > Cc: Michal Simek > Cc: linux-media@vger.kernel.org > Signed-off-by: Rob Herring Reviewed-by: Laurent Pinchart Which tree would you like to merge this through ? > --- > drivers/media/i2c/tvp5150.c | 8 ++++---- > drivers/media/platform/davinci/vpif_capture.c | 3 +-- > drivers/media/platform/ti-vpe/cal.c | 8 ++++---- > drivers/media/platform/video-mux.c | 2 +- > drivers/media/platform/xilinx/xilinx-dma.c | 8 ++++---- > 5 files changed, 14 insertions(+), 15 deletions(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index 76e6bed5a1da..f337e523821b 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -1403,8 +1403,8 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, > struct device_node *np) ret = of_property_read_u32(child, "input", > &input_type); > if (ret) { > dev_err(decoder->sd.dev, > - "missing type property in node %s\n", > - child->name); > + "missing type property in node %pOFn\n", > + child); > goto err_connector; > } > > @@ -1439,8 +1439,8 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, > struct device_node *np) ret = of_property_read_string(child, "label", > &name); > if (ret < 0) { > dev_err(decoder->sd.dev, > - "missing label property in node %s\n", > - child->name); > + "missing label property in node %pOFn\n", > + child); > goto err_connector; > } > > diff --git a/drivers/media/platform/davinci/vpif_capture.c > b/drivers/media/platform/davinci/vpif_capture.c index > a96f53ce8088..35fc69591d54 100644 > --- a/drivers/media/platform/davinci/vpif_capture.c > +++ b/drivers/media/platform/davinci/vpif_capture.c > @@ -1583,8 +1583,7 @@ vpif_capture_get_pdata(struct platform_device *pdev) > goto done; > } > > - dev_dbg(&pdev->dev, "Remote device %s, %pOF found\n", > - rem->name, rem); > + dev_dbg(&pdev->dev, "Remote device %pOF found\n", rem); > sdinfo->name = rem->full_name; > > pdata->asd[i] = devm_kzalloc(&pdev->dev, > diff --git a/drivers/media/platform/ti-vpe/cal.c > b/drivers/media/platform/ti-vpe/cal.c index d1febe5baa6d..77d755020e78 > 100644 > --- a/drivers/media/platform/ti-vpe/cal.c > +++ b/drivers/media/platform/ti-vpe/cal.c > @@ -1712,8 +1712,8 @@ static int of_cal_create_instance(struct cal_ctx *ctx, > int inst) v4l2_fwnode_endpoint_parse(of_fwnode_handle(remote_ep), > endpoint); > > if (endpoint->bus_type != V4L2_MBUS_CSI2) { > - ctx_err(ctx, "Port:%d sub-device %s is not a CSI2 device\n", > - inst, sensor_node->name); > + ctx_err(ctx, "Port:%d sub-device %pOFn is not a CSI2 device\n", > + inst, sensor_node); > goto cleanup_exit; > } > > @@ -1732,8 +1732,8 @@ static int of_cal_create_instance(struct cal_ctx *ctx, > int inst) endpoint->bus.mipi_csi2.data_lanes[lane]); > ctx_dbg(3, ctx, "\t>\n"); > > - ctx_dbg(1, ctx, "Port: %d found sub-device %s\n", > - inst, sensor_node->name); > + ctx_dbg(1, ctx, "Port: %d found sub-device %pOFn\n", > + inst, sensor_node); > > ctx->asd_list[0] = asd; > ctx->notifier.subdevs = ctx->asd_list; > diff --git a/drivers/media/platform/video-mux.c > b/drivers/media/platform/video-mux.c index c01e1592ad0a..61a9bf716a05 > 100644 > --- a/drivers/media/platform/video-mux.c > +++ b/drivers/media/platform/video-mux.c > @@ -333,7 +333,7 @@ static int video_mux_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, vmux); > > v4l2_subdev_init(&vmux->subdev, &video_mux_subdev_ops); > - snprintf(vmux->subdev.name, sizeof(vmux->subdev.name), "%s", np->name); > + snprintf(vmux->subdev.name, sizeof(vmux->subdev.name), "%pOFn", np); > vmux->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > vmux->subdev.dev = dev; > > diff --git a/drivers/media/platform/xilinx/xilinx-dma.c > b/drivers/media/platform/xilinx/xilinx-dma.c index > d041f94be832..3c8fcf951c63 100644 > --- a/drivers/media/platform/xilinx/xilinx-dma.c > +++ b/drivers/media/platform/xilinx/xilinx-dma.c > @@ -506,8 +506,8 @@ xvip_dma_querycap(struct file *file, void *fh, struct > v4l2_capability *cap) > > strlcpy(cap->driver, "xilinx-vipp", sizeof(cap->driver)); > strlcpy(cap->card, dma->video.name, sizeof(cap->card)); > - snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s:%u", > - dma->xdev->dev->of_node->name, dma->port); > + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%pOFn:%u", > + dma->xdev->dev->of_node, dma->port); > > return 0; > } > @@ -693,8 +693,8 @@ int xvip_dma_init(struct xvip_composite_device *xdev, > struct xvip_dma *dma, dma->video.fops = &xvip_dma_fops; > dma->video.v4l2_dev = &xdev->v4l2_dev; > dma->video.queue = &dma->queue; > - snprintf(dma->video.name, sizeof(dma->video.name), "%s %s %u", > - xdev->dev->of_node->name, > + snprintf(dma->video.name, sizeof(dma->video.name), "%pOFn %s %u", > + xdev->dev->of_node, > type == V4L2_BUF_TYPE_VIDEO_CAPTURE ? "output" : "input", > port); > dma->video.vfl_type = VFL_TYPE_GRABBER; -- Regards, Laurent Pinchart